Fix ESlint errors for storage packages

[praveenkuttappan]

Fix lint errors found in storage packages by ESLint. Following are the steps to run ESLint for storage packages and reproduce this issue.

1. Set up your dev environment if not already done so as mentioned here
2. Go to <repo root>/sdk/storage/<package-name>
3. run rushx lint
4. Command in step 2 generates an html report in directory <repo root>/sdk/storage/<package-name> with name ends with lintReport.html
5. All lint errors found in this package is listed on html report.

Once all known issues are resolved, below change is required in package.json file in package root <repo root>/sdk/storage/<package-name> to treat any new lint regression as hard failure in CI.

• Remove following snippet from lint command in package.json
-f html -o <package name>-lintReport.html || exit 0

Note: HTML report name prefix may be different for each package name to differentiate the report for each package.

[abc516]

Hi @praveenkuttappan @ramya-rao-a can I take this one on too?

[ramya-rao-a]

Yes, please go ahead.

[ramya-rao-a]

@EmmaZhu Looks like we fixed things up in the blob, queue, file-share, changefeed, file-datalake packages. The below packages are pending

• storage-internal-avro
• perf-tests/storage-blob-track-1

[ramya-rao-a]

Closing this issue in favor of #17945