Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Fix the self vs window rule in storage packages #13932

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Feb 23, 2021

This PR fixes up the latest linter rule we added to our linter.
Found this when running the lint:fix script on the storage packages

More details are in #13873
Related to #10782

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Feb 23, 2021
@ramya-rao-a ramya-rao-a changed the title [Storage] Run lint:fix on all storage pkgs [Storage] Fix the self vs window rule in storage packages Feb 23, 2021
@ramya-rao-a
Copy link
Contributor Author

cc @maorleger

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@jeremymeng jeremymeng added the Client This issue points to a problem in the data-plane of the library. label Feb 24, 2021
@jeremymeng
Copy link
Member

@EmmaZhu @ljian3377 please take a look.

@ramya-rao-a ramya-rao-a merged commit 199b5b7 into Azure:master Mar 1, 2021
@ramya-rao-a ramya-rao-a deleted the storage-self branch March 1, 2021 17:21
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jun 15, 2021
[Hub Generated] Public private branch 'add-ingressStartAt' (Azure#13932)

* add ingressStartAt

* prettier

* add a new example

* Delete .npmrc

remove .npmrc

* fix prettier

fix prettier

* put readonly back for kind

* Adding descriptin to ingressStartAt

* fix failure for python track2

* Removing readonly from kind

Co-authored-by: Go Blue <[email protected]>
Co-authored-by: msyyc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants