-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Fix the self vs window rule in storage packages #13932
Conversation
cc @maorleger |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
@EmmaZhu @ljian3377 please take a look. |
[Hub Generated] Public private branch 'add-ingressStartAt' (Azure#13932) * add ingressStartAt * prettier * add a new example * Delete .npmrc remove .npmrc * fix prettier fix prettier * put readonly back for kind * Adding descriptin to ingressStartAt * fix failure for python track2 * Removing readonly from kind Co-authored-by: Go Blue <[email protected]> Co-authored-by: msyyc <[email protected]>
This PR fixes up the latest linter rule we added to our linter.
Found this when running the
lint:fix
script on the storage packagesMore details are in #13873
Related to #10782