Fix ESLint errors in storage-blob package. #16881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaZhu
requested review from
jeremymeng,
jiacfan,
ljian3377,
vinjiang and
XiaoningLiu
as code owners
ghost
added
the
ramya-rao-a
reviewed
Aug 13, 2021
sdk/storage/storage-blob/src/policies/AnonymousCredentialPolicy.ts
Outdated
Show resolved
Hide resolved
| @@ -93,6 +95,7 @@ describe("Highlevel", () => { | |||
| let eventTriggered = false; | |||
| const aborter = new AbortController(); | |||
|
|
|||
| /* eslint no-empty: ["error", { "allowEmptyCatch": true }] */ | |||
There was a problem hiding this comment.
What is the reason for ignoring the error here? Shouldnt failure to upload data also fail the test?
ramya-rao-a
reviewed
Aug 13, 2021
ramya-rao-a
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ESLint errors in storage-blob package.
#10782