Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Key Vault Certificate Readme Issue #11492

Closed
zzhxiaofeng opened this issue Sep 25, 2020 · 1 comment · Fixed by #11600
Closed

Azure Key Vault Certificate Readme Issue #11492

zzhxiaofeng opened this issue Sep 25, 2020 · 1 comment · Fixed by #11600
Assignees
@sadasant
Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault test-manual-pass
Milestone
[2020] October

Comments

@zzhxiaofeng
Copy link
Contributor

zzhxiaofeng commented Sep 25, 2020 •
edited
Loading

Section link
Screenshot 2020-09-22 150158
Reason:
No corresponding sample related to List all versions of a certificate.

Suggestion:
Delete the link related to List all versions of a certificate.

@jongio for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 25, 2020
@tzhanl tzhanl added Client This issue points to a problem in the data-plane of the library. Docs KeyVault needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass labels Sep 25, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 25, 2020
@ramya-rao-a
Copy link
Contributor

Thanks for reporting @zzhxiaofeng

@sadasant, Do you agree with the recommendation above? If not, then please provide your recommendation after which

  • add the labels bug, help wanted and good first issue
  • remove the label needs-team-triage
  • assign the issue to the backlog milestone

@sadasant sadasant added this to the [2020] October milestone Sep 28, 2020
sadasant added a commit that referenced this issue Oct 1, 2020
@sadasant
[Key Vault Certificates] Fixed bad reference in the README
3d25cd5 
Removed the following link since it lead nowhere:

```md
- [List all versions of a certificate](#list-all-versions-of-a-certificate).
```

Thank you @zzhxiaofeng !

Fixes #11492
@sadasant sadasant mentioned this issue Oct 1, 2020
Merged
@sadasant sadasant removed the needs-team-triage Workflow: This issue needs the team to triage. label Oct 1, 2020
sadasant added a commit that referenced this issue Oct 2, 2020
@sadasant
[Key Vault Certificates] Fixed bad reference in the README (#11600)
38fb9b0 
Removed the following link since it lead nowhere:

```md
- [List all versions of a certificate](#list-all-versions-of-a-certificate).
```

Thank you @zzhxiaofeng !

Fixes #11492
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Nov 11, 2020
@paulgmiller @bcho
@levimm @mainred @norshtein @bowang-666
CodeGen from PR 11588 in Azure/azure-rest-api-specs
2b1b466 
Dev containerservice microsoft.container service 2020 11 01 (Azure#11588)

* Adds base for updating Microsoft.ContainerService from version stable/2020-09-01 to version 2020-11-01

* Updates readme

* Updates API version in new specs and examples

* add autoupgradeprofile to 2020-11-01 (Azure#11363)

* add autoupgradeprofile

* add autoupgrader profile to mc

* format change

Co-authored-by: Xiahe Liu <[email protected]>

* add pod subnet id on agentpool (Azure#11310)

* aks: add pod identity profile spec (Azure#11366)

* add private dns zone property in 2020-11-01 (Azure#11311)

Co-authored-by: Li Ma <[email protected]>

* Remove invalid pattern and adjust description (Azure#11312)

* aks: fix pod identity profile field names (Azure#11484)

* aks: add missing `podIdentityProfile.enabled` field

* aks: typo

* add non upgrade channel (Azure#11492)

Co-authored-by: Xiahe Liu <[email protected]>

* Make identityProfile mutable (Azure#11458)

* Add KubeletConfig and LinuxOSConfig specs (Azure#11490)

* aks: update readme tag for 1101 (Azure#11472)

* aks: update readme tag

* aks: add `2020-11-01-only`

* resovle merge conlicts to master, adding recent master change to dev branch (Azure#11604)

Co-authored-by: Xiahe Liu <[email protected]>

Co-authored-by: Xiahe Liu <[email protected]>
Co-authored-by: Paul Miller <[email protected]>
Co-authored-by: hbc <[email protected]>
Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Qingchuan Hao <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Bo Wang <[email protected]>
Co-authored-by: Phoenix He <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault test-manual-pass
Projects
None yet
Milestone
[2020] October
Development

Successfully merging a pull request may close this issue.

[Key Vault Certificates] Fixed bad reference in the README Azure/azure-sdk-for-js
4 participants
@sadasant @ramya-rao-a @zzhxiaofeng @tzhanl