Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Record & Playback] Move to the new proxy server based recorder Part I #17994

Closed
17 of 18 tasks
jeremymeng opened this issue Oct 1, 2021 · 0 comments
Closed
17 of 18 tasks

[Record & Playback] Move to the new proxy server based recorder Part I #17994

jeremymeng opened this issue Oct 1, 2021 · 0 comments
Assignees
@timovv
Labels
Client This issue points to a problem in the data-plane of the library. Epic

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Oct 1, 2021 •
edited
Loading

Use this migration guide https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/MIGRATION.md and try migrating the ATOM management tests to use the new recorder?

And please reach out if you have feedback or for any blockers.

First batch of packages:

  • App Configuration
  • Cognitive Search
  • Container Registry
  • Event Grid
  • Form Recognizer
  • Identity
  • Key Vault
    • Key Vault - Administration
    • Key Vault - Certificates
    • Key Vault - Keys
    • Key Vault - Secrets
  • Metrics Advisor
  • Monitor Query
  • Schema Registry
    • Schema Registry - Avro
  • Service Bus (currently no playback but can have some) -- deferred
  • Tables
  • Text Analytics
@jeremymeng jeremymeng added the Client This issue points to a problem in the data-plane of the library. label Oct 1, 2021
@jeremymeng jeremymeng added this to the [2021] December milestone Oct 1, 2021
@jeremymeng jeremymeng added the Epic label Oct 1, 2021
@jeremymeng jeremymeng changed the title [Test][Record & Playback] Move to the new proxy server based recorder [Record & Playback] Move to the new proxy server based recorder Oct 1, 2021
@jeremymeng jeremymeng changed the title [Record & Playback] Move to the new proxy server based recorder [Record & Playback] Move to the new proxy server based recorder Part I Oct 1, 2021
This was referenced Oct 1, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 7, 2022
@debroy @debjyoti11
@roeybc @laithhisham @ushasan @hassanchawiche @shschwar @royrein @dosegal @akning-ms
CodeGen from PR 18025 in Azure/azure-rest-api-specs
b83b241 
Dev sentinel 2022 01 01 preview (Azure#18025)

* Adds base for updating Microsoft.SecurityInsights from version preview/2021-10-01-preview to version 2022-01-01-preview

* Updates readme

* Updates API version in new specs and examples

* SourceControl API 2022-01-01-preview version - adding new attribute to SourceControl model (Azure#17849)

* SourceControl 2022-01-01-preview version change

* fix validation error

* prettified

* prettified

Co-authored-by: debjyoti11 <[email protected]>

* New metadata API (Azure#17942)

* metadata changes

* addressed changes

* updated enum kind

* updated values as well

Co-authored-by: Roey Ben Chaim <[email protected]>

* added new enum to kind (Azure#17994)

Co-authored-by: Roey Ben Chaim <[email protected]>

* Add flag to rotate webhook secret (Azure#17989)

Co-authored-by: debjyoti11 <[email protected]>

* Align definitions with stable version (Azure#17931)

* Align definitions with stable version

* align scheduled rule and template properties with stable

* Note: We are creating a new api-version with this change. Watchlists.json 2022-01-01-preview parameter name changes (Azure#17848)

* changed source to sourceType and watchlistAlias to alias

* Update CreateWatchlistAndWatchlistItems.json

* Update CreateWatchlistItem.json

* Update DeleteWatchlist.json

* Update DeleteWatchlistItem.json

* Update GetWatchlistByAlias.json

* Update GetWatchlistItemById.json

* Update GetWatchlistItems.json

* Update GetWatchlistByAlias.json

* added missing params to match stable version

* Revert "added missing params to match stable version"

This reverts commit a30a709613f94266d0eaba6495c92be43221a282.

Reverting by 1 commit

* refreshing pipeline

* reverting lint diff change

* attempting to fix RemovedPath breaking changes

* Revert "attempting to fix RemovedPath breaking changes"

This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1.

reverting attempt at correcting breaking changes. cannot match preview
to stable without breaking everything.

* adding back source type for backwards compatibility, added response descriptions, corrected PR comments

* adding missing bracket

* ran npm run prettier-fix to correct style issues

* resolving model/definition errors

* Revert "resolving model/definition errors"

This reverts commit fd67a4f813d923965cefad50999010820446a107.

Reverting prettier changes made to other branches

* Revert "ran npm run prettier-fix to correct style issues"

This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c.

* update

* Update DeleteWatchlist.json

* Update Watchlists.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* fixing styling issues on Delete example

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* ran npm run prettier on DeleteWatchlist.json

* Update Watchlists.json

* reverting alias to watchlistAlias

Co-authored-by: Hassan Chawiche <[email protected]>

* Rename system to AutoAssigned (Azure#18061)

* Rename system to AutoAssigned

* Add example to list operations

* Update API version in NRT examples

* Execute validation tools and fix results (Azure#17733)

* Execute validation tools and fic results

* Prettyfieir GetIoTById.json

* Watchlists.json-2022-01-01-preview-parameterNameChanges (reverted PR reference for files changed -> https://github.com/Azure/azure-rest-api-specs/pull/17848/files) (Azure#18085)

* changed source to sourceType and watchlistAlias to alias

* Update CreateWatchlistAndWatchlistItems.json

* Update CreateWatchlistItem.json

* Update DeleteWatchlist.json

* Update DeleteWatchlistItem.json

* Update GetWatchlistByAlias.json

* Update GetWatchlistItemById.json

* Update GetWatchlistItems.json

* Update GetWatchlistByAlias.json

* added missing params to match stable version

* Revert "added missing params to match stable version"

This reverts commit a30a709613f94266d0eaba6495c92be43221a282.

Reverting by 1 commit

* refreshing pipeline

* reverting lint diff change

* attempting to fix RemovedPath breaking changes

* Revert "attempting to fix RemovedPath breaking changes"

This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1.

reverting attempt at correcting breaking changes. cannot match preview
to stable without breaking everything.

* adding back source type for backwards compatibility, added response descriptions, corrected PR comments

* adding missing bracket

* ran npm run prettier-fix to correct style issues

* resolving model/definition errors

* Revert "resolving model/definition errors"

This reverts commit fd67a4f813d923965cefad50999010820446a107.

Reverting prettier changes made to other branches

* Revert "ran npm run prettier-fix to correct style issues"

This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c.

* update

* Update DeleteWatchlist.json

* Update Watchlists.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* fixing styling issues on Delete example

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* ran npm run prettier on DeleteWatchlist.json

* Update Watchlists.json

* reverting alias to watchlistAlias

* fixing type version

* Update Watchlists.json

* Update DeleteWatchlist.json

* fixing commas

Co-authored-by: Hassan Chawiche <[email protected]>
Co-authored-by: Usman Hasan <[email protected]>

* Done (Azure#17843)

Co-authored-by: Roy Reinhorn <[email protected]>

* AutomationRules 2022-01-01-preview: Add constraints (Azure#18099)

* add contraints (alinged with the latest stable version)

Co-authored-by: debroy <[email protected]>
Co-authored-by: debjyoti11 <[email protected]>
Co-authored-by: RoeyBC <[email protected]>
Co-authored-by: Roey Ben Chaim <[email protected]>
Co-authored-by: Laith Hisham <[email protected]>
Co-authored-by: ushasan <[email protected]>
Co-authored-by: Hassan Chawiche <[email protected]>
Co-authored-by: shschwar <[email protected]>
Co-authored-by: Usman Hasan <[email protected]>
Co-authored-by: royrein <[email protected]>
Co-authored-by: Roy Reinhorn <[email protected]>
Co-authored-by: dosegal <[email protected]>
Co-authored-by: Arthur Ning <[email protected]>
@HarshaNalluru HarshaNalluru removed this from the [2022] April milestone Mar 22, 2022
@HarshaNalluru HarshaNalluru added this to the [2022] May milestone Mar 22, 2022
@HarshaNalluru HarshaNalluru modified the milestones: [2022] May, [2022] June May 10, 2022
@HarshaNalluru HarshaNalluru modified the milestones: [2022] June, [2022] July Jun 7, 2022
@xirzec xirzec modified the milestones: 2022-07, 2022-08 Jul 8, 2022
@xirzec xirzec modified the milestones: 2022-08, 2022-09 Aug 9, 2022
@HarshaNalluru HarshaNalluru modified the milestones: 2022-09, 2022-10 Sep 8, 2022
@HarshaNalluru HarshaNalluru assigned timovv and unassigned HarshaNalluru Oct 6, 2022
@xirzec xirzec modified the milestones: 2022-10, 2022-12 Nov 1, 2022
This was referenced Dec 19, 2022
Merged
Merged
@xirzec xirzec modified the milestones: 2022-12, 2023-02 Jan 11, 2023
This was referenced Jan 13, 2023
Merged
Merged
Merged
@xirzec xirzec removed this from the 2023-02 milestone Mar 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timovv timovv

Labels
Client This issue points to a problem in the data-plane of the library. Epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@xirzec @timovv @jeremymeng @HarshaNalluru @ramya-rao-a