Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Container Registry Readme and Samples Issue #17931

Closed
v-jiaodi opened this issue Sep 29, 2021 · 3 comments
Closed

Azure Container Registry Readme and Samples Issue #17931

v-jiaodi opened this issue Sep 29, 2021 · 3 comments
Assignees
@jeremymeng
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry Docs test-manual-pass
Milestone
[2021] October

Comments

@v-jiaodi
Copy link
Member

Section link1,link2,link3,link4:

image

Reason:
Error message: "authentication required"

Suggestion:
Add const { DefaultAzureCredential } = require("@azure/identity");
and add a parameter: new DefaultAzureCredential()

@elraikhm ,@ramya-rao-a , @jeremymeng and @AlexGhiondea for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 29, 2021
@jeremymeng
Copy link
Member

@v-jiaodi This sample is supposed to work with a registry that has anonymous pull access enabled. Did you see the error even with that?

https://docs.microsoft.com/en-us/azure/container-registry/container-registry-faq#how-do-i-enable-anonymous-pull-access-

It also requires Standard SKU if I remember correctly.

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Container Registry Docs labels Sep 29, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 29, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] October milestone Sep 29, 2021
@v-jiaodi
Copy link
Member Author

v-jiaodi commented Sep 30, 2021 •
edited
Loading

Thank you @jeremymeng. According to your reminder, I rerun the code and it passed. I'm sorry and I will close it.

@jeremymeng
Copy link
Member

@v-jiaodi Don't be sorry! I just want to ensure there isn't any issue 😃

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 7, 2022
@debroy @debjyoti11
@roeybc @laithhisham @ushasan @hassanchawiche @shschwar @royrein @dosegal @akning-ms
CodeGen from PR 18025 in Azure/azure-rest-api-specs
b83b241 
Dev sentinel 2022 01 01 preview (Azure#18025)

* Adds base for updating Microsoft.SecurityInsights from version preview/2021-10-01-preview to version 2022-01-01-preview

* Updates readme

* Updates API version in new specs and examples

* SourceControl API 2022-01-01-preview version - adding new attribute to SourceControl model (Azure#17849)

* SourceControl 2022-01-01-preview version change

* fix validation error

* prettified

* prettified

Co-authored-by: debjyoti11 <[email protected]>

* New metadata API (Azure#17942)

* metadata changes

* addressed changes

* updated enum kind

* updated values as well

Co-authored-by: Roey Ben Chaim <[email protected]>

* added new enum to kind (Azure#17994)

Co-authored-by: Roey Ben Chaim <[email protected]>

* Add flag to rotate webhook secret (Azure#17989)

Co-authored-by: debjyoti11 <[email protected]>

* Align definitions with stable version (Azure#17931)

* Align definitions with stable version

* align scheduled rule and template properties with stable

* Note: We are creating a new api-version with this change. Watchlists.json 2022-01-01-preview parameter name changes (Azure#17848)

* changed source to sourceType and watchlistAlias to alias

* Update CreateWatchlistAndWatchlistItems.json

* Update CreateWatchlistItem.json

* Update DeleteWatchlist.json

* Update DeleteWatchlistItem.json

* Update GetWatchlistByAlias.json

* Update GetWatchlistItemById.json

* Update GetWatchlistItems.json

* Update GetWatchlistByAlias.json

* added missing params to match stable version

* Revert "added missing params to match stable version"

This reverts commit a30a709613f94266d0eaba6495c92be43221a282.

Reverting by 1 commit

* refreshing pipeline

* reverting lint diff change

* attempting to fix RemovedPath breaking changes

* Revert "attempting to fix RemovedPath breaking changes"

This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1.

reverting attempt at correcting breaking changes. cannot match preview
to stable without breaking everything.

* adding back source type for backwards compatibility, added response descriptions, corrected PR comments

* adding missing bracket

* ran npm run prettier-fix to correct style issues

* resolving model/definition errors

* Revert "resolving model/definition errors"

This reverts commit fd67a4f813d923965cefad50999010820446a107.

Reverting prettier changes made to other branches

* Revert "ran npm run prettier-fix to correct style issues"

This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c.

* update

* Update DeleteWatchlist.json

* Update Watchlists.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* fixing styling issues on Delete example

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* ran npm run prettier on DeleteWatchlist.json

* Update Watchlists.json

* reverting alias to watchlistAlias

Co-authored-by: Hassan Chawiche <[email protected]>

* Rename system to AutoAssigned (Azure#18061)

* Rename system to AutoAssigned

* Add example to list operations

* Update API version in NRT examples

* Execute validation tools and fix results (Azure#17733)

* Execute validation tools and fic results

* Prettyfieir GetIoTById.json

* Watchlists.json-2022-01-01-preview-parameterNameChanges (reverted PR reference for files changed -> https://github.com/Azure/azure-rest-api-specs/pull/17848/files) (Azure#18085)

* changed source to sourceType and watchlistAlias to alias

* Update CreateWatchlistAndWatchlistItems.json

* Update CreateWatchlistItem.json

* Update DeleteWatchlist.json

* Update DeleteWatchlistItem.json

* Update GetWatchlistByAlias.json

* Update GetWatchlistItemById.json

* Update GetWatchlistItems.json

* Update GetWatchlistByAlias.json

* added missing params to match stable version

* Revert "added missing params to match stable version"

This reverts commit a30a709613f94266d0eaba6495c92be43221a282.

Reverting by 1 commit

* refreshing pipeline

* reverting lint diff change

* attempting to fix RemovedPath breaking changes

* Revert "attempting to fix RemovedPath breaking changes"

This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1.

reverting attempt at correcting breaking changes. cannot match preview
to stable without breaking everything.

* adding back source type for backwards compatibility, added response descriptions, corrected PR comments

* adding missing bracket

* ran npm run prettier-fix to correct style issues

* resolving model/definition errors

* Revert "resolving model/definition errors"

This reverts commit fd67a4f813d923965cefad50999010820446a107.

Reverting prettier changes made to other branches

* Revert "ran npm run prettier-fix to correct style issues"

This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c.

* update

* Update DeleteWatchlist.json

* Update Watchlists.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* fixing styling issues on Delete example

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* ran npm run prettier on DeleteWatchlist.json

* Update Watchlists.json

* reverting alias to watchlistAlias

* fixing type version

* Update Watchlists.json

* Update DeleteWatchlist.json

* fixing commas

Co-authored-by: Hassan Chawiche <[email protected]>
Co-authored-by: Usman Hasan <[email protected]>

* Done (Azure#17843)

Co-authored-by: Roy Reinhorn <[email protected]>

* AutomationRules 2022-01-01-preview: Add constraints (Azure#18099)

* add contraints (alinged with the latest stable version)

Co-authored-by: debroy <[email protected]>
Co-authored-by: debjyoti11 <[email protected]>
Co-authored-by: RoeyBC <[email protected]>
Co-authored-by: Roey Ben Chaim <[email protected]>
Co-authored-by: Laith Hisham <[email protected]>
Co-authored-by: ushasan <[email protected]>
Co-authored-by: Hassan Chawiche <[email protected]>
Co-authored-by: shschwar <[email protected]>
Co-authored-by: Usman Hasan <[email protected]>
Co-authored-by: royrein <[email protected]>
Co-authored-by: Roy Reinhorn <[email protected]>
Co-authored-by: dosegal <[email protected]>
Co-authored-by: Arthur Ning <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremymeng jeremymeng

Labels
Client This issue points to a problem in the data-plane of the library. Container Registry Docs test-manual-pass
Projects
None yet
Milestone
[2021] October
Development

No branches or pull requests
4 participants
@jeremymeng @ramya-rao-a @v-xuto @v-jiaodi