Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-pubsub-client] Migrate to new recorder #24316

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

minhanh-phan
Copy link
Member

Packages impacted by this PR

web-pubsub-client

Issues associated with this PR

#17994

Describe the problem that is addressed by this PR

Delete dependency on @azure-tools/test-recorder because it is not used

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ghost ghost added the WebPubSub label Dec 21, 2022
@minhanh-phan minhanh-phan marked this pull request as ready for review January 4, 2023 23:20
@minhanh-phan minhanh-phan merged commit e199238 into Azure:main Jan 4, 2023
@minhanh-phan minhanh-phan deleted the migrate-web-pubsub-client branch March 15, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants