Bump to the right version. Switch test account to team account. #4710

sima-zhu · 2019-07-30T19:25:21Z

Most of the files are playback json files. Please skip when necessary.

…into storage_tests

g2vinay · 2019-07-30T21:39:11Z

storage/client/queue/src/main/java/com/azure/storage/queue/QueueServiceClientBuilder.java

        this.sharedKeyCredential = SharedKeyCredential.fromConnectionString(connectionString);
+        getEndPointFromConnectionString(connectionString);


Don't see any javadoc changes
Should they be updated in the builder class that endpoint is optional?

It is hard to state optional as it is optional only if connectionString built in. If we only build in credential, then endpoint is still necessary.

okay, so are these scenarios specified in javadocs?
It will be helpful for the user I feel.

There are descriptions in builder class. I can add some additional doc to make it more clear.

g2vinay · 2019-07-30T21:39:18Z

...client/file/src/main/java/com/azure/storage/file/implementation/AzureFileStorageBuilder.java

@@ -74,9 +74,7 @@ public AzureFileStorageImpl build() {
            this.pipeline = RestProxy.createDefaultPipeline();
        }
        AzureFileStorageImpl client = new AzureFileStorageImpl(pipeline);
-        if (this.version != null) {


Does the version always get set from a static conig class ?

This is auto-gen class. I have the temp fix to pass the spotbugs. Loop in @jianghaolu for further discussion.

Let's track this, so it doesn't cause issues later.

…into storage_tests

srnagar · 2019-07-30T21:54:09Z

pom.client.xml

@@ -546,6 +546,7 @@
                -snippetpath ${project.basedir}/sdk/keyvault/azure-keyvault-keys/src/samples/java
                -snippetpath ${project.basedir}/sdk/keyvault/azure-keyvault-secrets/src/samples/java
                <!-- -snippetpath ${project.basedir}/storage/client/blob/src/samples/java-->


Should this be uncommented?

@alzimmermsft can we add back this line?

I wouldn't worry about uncommenting this line in this PR, blobs doesn't have any snippets yet.

Will uncommon this.

srnagar · 2019-07-30T21:57:25Z

storage/client/queue/src/main/java/com/azure/storage/queue/QueueServiceClientBuilder.java

        return this;
    }

+    private void getEndPointFromConnectionString(String connectionString) {


Naming this get.. and returning void is misleading.

Also, consider turning this into a utility method as parsing the connection string to get key-value pairs may be used in multiple places.

This will move to common utility after we extract common module. It will address all these pain.
I am doing this just to minimize the the PR's scope.

Please refer this one: #4658

srnagar · 2019-07-30T21:58:19Z

storage/client/queue/src/main/java/com/azure/storage/queue/QueueServiceClientBuilder.java

        return this;
    }

+    private void getEndPointFromConnectionString(String connectionString) {
+        HashMap<String, String> connectionStringPieces = new HashMap<>();


Use Map<String, String> connectionStringPieces. Code to the interface.

Same as above

srnagar · 2019-07-30T22:01:33Z

storage/client/queue/src/main/java/com/azure/storage/queue/QueueServiceClientBuilder.java

        return this;
    }

+    private void getEndPointFromConnectionString(String connectionString) {
+        HashMap<String, String> connectionStringPieces = new HashMap<>();
+        for (String connectionStringPiece : connectionString.split(";")) {


Since you just need the account name, do you need to look at all the connection string key-value pairs?

Alan has the refactor in his common module PR.
https://github.com/alzimmermsft/azure-sdk-for-java/blob/AzStorage_Common_Package/storage/client/queue/src/main/java/com/azure/storage/queue/QueueClientBuilder.java#L284

srnagar · 2019-07-30T22:02:06Z

storage/client/queue/src/main/java/com/azure/storage/queue/QueueServiceClientBuilder.java

+        } catch (MalformedURLException e) {
+            LOGGER.error("There is no valid account for the connection string. "
+                + "Connection String: %s", connectionString);
+            throw new IllegalArgumentException(String.format("There is no valid account for the connection string. "


The new guideline is to use logger.logAndThrow() instead.

This will address in another PR.

Bump to the right version. Switch test account to team account.

8696082

sima-zhu requested a review from alzimmermsft July 30, 2019 19:25

sima-zhu requested review from danieljurek, g2vinay, jaschrep-msft, rickle-msft and samvaity as code owners July 30, 2019 19:25

sima-zhu mentioned this pull request Jul 30, 2019

Rename fileService to fileStorage, queueService to queueStorage. #4571

Closed

jaschrep-msft approved these changes Jul 30, 2019

View reviewed changes

Fixed version stuff

e847724

sima-zhu requested review from mitchdenny and weshaggard as code owners July 30, 2019 20:51

sima-zhu added 2 commits July 30, 2019 13:53

Fixed typo

2d1e3eb

Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …

a9dc37e

…into storage_tests

alzimmermsft added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Jul 30, 2019

version tests

ed6ce97

g2vinay reviewed Jul 30, 2019

View reviewed changes

sima-zhu added 2 commits July 30, 2019 15:10

Bump the verstion

78b648c

Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …

2de5f0e

…into storage_tests

srnagar reviewed Jul 30, 2019

View reviewed changes

sima-zhu requested review from srnagar and g2vinay July 30, 2019 22:50

alzimmermsft approved these changes Jul 30, 2019

View reviewed changes

g2vinay approved these changes Jul 30, 2019

View reviewed changes

srnagar approved these changes Jul 30, 2019

View reviewed changes

Uncommon blob from codesnippet

037a807

sima-zhu merged commit 20a085f into Azure:master Jul 31, 2019

sima-zhu deleted the storage_tests branch July 31, 2019 00:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump to the right version. Switch test account to team account. #4710

Bump to the right version. Switch test account to team account. #4710

sima-zhu commented Jul 30, 2019

g2vinay Jul 30, 2019

sima-zhu Jul 30, 2019

g2vinay Jul 30, 2019

sima-zhu Jul 30, 2019

g2vinay Jul 30, 2019

sima-zhu Jul 30, 2019

g2vinay Jul 30, 2019

srnagar Jul 30, 2019

sima-zhu Jul 30, 2019 •

edited

Loading

alzimmermsft Jul 30, 2019

sima-zhu Jul 30, 2019

srnagar Jul 30, 2019

srnagar Jul 30, 2019

sima-zhu Jul 30, 2019

sima-zhu Jul 30, 2019

srnagar Jul 30, 2019

sima-zhu Jul 30, 2019

srnagar Jul 30, 2019

sima-zhu Jul 30, 2019

srnagar Jul 30, 2019

sima-zhu Jul 30, 2019

sima-zhu Jul 30, 2019

		this.sharedKeyCredential = SharedKeyCredential.fromConnectionString(connectionString);
		getEndPointFromConnectionString(connectionString);

Bump to the right version. Switch test account to team account. #4710

Bump to the right version. Switch test account to team account. #4710

Conversation

sima-zhu commented Jul 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sima-zhu Jul 30, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sima-zhu Jul 30, 2019 •

edited

Loading