Rename fileService to fileStorage, queueService to queueStorage. #4571

sima-zhu · 2019-07-24T23:51:46Z

FileService->FileStorage
QueueService -> QueueStorage

Replace file playback json files

* SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue

Removes RawClients from Storage Blobs

…to ContainerClient (Azure#4376) * Removed raw clients * Added deleteContainer to StorageClient * Added getAppendBlob with snapshot to ContainerClient

* Initial check in for storage queue

* Finished the restructure, refactor builder. Added sleep in record feature. Linting

Merges AppendBlobClientBuilder, BlobClientBuilder, BlockBlobClientBuilder, and PageBlobClientBuilder into a single builder class BlobClientBuilder. Additionally, JavaDoc comments for the other builder classes, ContainerClientBuilder and StorageAccountClientBuilder, were cleaned up and the way the endpoint is handled in builders was changed.

alzimmermsft

READMEs and some JavaDocs need cleanup

storage/client/file/src/main/java/com/azure/storage/file/FileStorageClient.java

storage/client/queue/README.md

joshfree · 2019-07-25T19:45:45Z

storage/client/file/src/test/resources/session-records/clearMetadataFromDirClient.json

@@ -1,42 +1,42 @@
 {
  "networkCallRecords" : [ {
    "Method" : "PUT",
-    "Uri" : "https://sima.file.core.windows.net/dirsharename/directory863334?restype=directory",
+    "Uri" : "https://sima.file.core.windows.net/dirsharename/directory06962b?restype=directory",


We shouldn't have checked-in tests that reference a specific dev's account. Can you create a tracking work item to move these Uri's to a team account versus an individual account?
/cc @weshaggard

Yes we should be setting up these resources more generally in our test resources subscription. @danieljurek I believe you have some docs talking about that correct?

This would be an easy change. We used azstoragesdkaccount for testing. Will use it for now.

Yes. The short version is that test resources belong in the test resources subscription .. Details here: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki?pagePath=%2FData%20Plane%20Quality%20Program%2FTesting%20Guidelines&pageId=51&wikiVersion=GBwikiMaster&anchor=best-practices

We have switched the azstoragesdkaccount team account under Azure SDK Test Resource subscription already.

…licy.

danieljurek · 2019-07-27T00:37:45Z

storage/client/file/src/test/resources/session-records/clearMetadataFromDirClient.json

@@ -1,42 +1,42 @@
 {
  "networkCallRecords" : [ {
    "Method" : "PUT",
-    "Uri" : "https://sima.file.core.windows.net/dirsharename/directory863334?restype=directory",
+    "Uri" : "https://azstoragesdkaccount.file.core.windows.net/dirsharename/directory149240?restype=directory",


My comment came in rather late so sorry to keep harping on this if you've already fixed it and just haven't pushed yet :P

I looked up the azstoragesdkaccount a few minutes ago, it's not listed in the test resources subscription. Please use a storage account in the test resources subscription.

More info here: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki?pagePath=%2FData%20Plane%20Quality%20Program%2FTesting%20Guidelines&pageId=51&wikiVersion=GBwikiMaster&anchor=best-practices

I am switching the account to Azure SDK Test Resources. This is the one created by our team and only used for java storage testing.

alzimmermsft

LGTM, just need to fix that merge conflixt

alzimmermsft · 2019-07-29T18:10:03Z

eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml

@@ -441,6 +441,8 @@
      <Class name="com.azure.storage.blob.BlobInputStream"/>
      <Class name="com.azure.storage.blob.BlobOutputStream"/>
      <Class name="com.azure.storage.queue.QueueServiceClient"/>
+<<<<<<< HEAD


Missed a merged conflict

Done with the fix. Thanks!

jaschrep-msft

Caught a naming concern but good otherwise.

jaschrep-msft · 2019-07-29T19:07:48Z

storage/client/file/src/main/java/com/azure/storage/file/FileStorageClient.java

@@ -137,11 +137,11 @@ public ShareClient getShareClient(String shareName) {
     *
     * <p>Clear CORS in the File service</p>
     *
-     * {@codesnippet com.azure.storage.file.fileServiceClient.setProperties#fileServiceProperties.clearCORS}
+     * {@codesnippet com.azure.storage.file.fileStorageClient.setProperties#fileServiceProperties.clearCORS}


Should be fileStorageProperties

Fix elsewhere as needed.

I made this comment a while ago before finishing the review. The more I look at it, the more I'm not sure what the actual name should be. @rickle-msft do you have ideas?

This class is auto-generated. To rename it, we need change swagger.

sima-zhu · 2019-07-30T19:29:05Z

Split the switch account stuff to another PR #4710.

This is blocked by the board decision about naming.

sima-zhu · 2019-08-14T21:21:39Z

Closed as it is not top priority for preview 3

gapra-msft and others added 11 commits July 12, 2019 11:57

Storage SAS implementation (Azure#4404)

1ec9438

* SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue

Merge branch 'master' into storage-post-review1-dev

78db8d4

Merge branch 'master' into storage-post-review1-dev

69026ba

Remove RawClients from Blobs (Azure#4375)

be429c3

Removes RawClients from Storage Blobs

Add deleteContainer to StorageClient and getBlobClient with Snapshot …

b00cdc6

…to ContainerClient (Azure#4376) * Removed raw clients * Added deleteContainer to StorageClient * Added getAppendBlob with snapshot to ContainerClient

Merge branch 'master' into storage-post-review1-dev

da7ebb6

Storage queue linting, builder refactor, tests (Azure#4383)

78ea66b

* Initial check in for storage queue

Initial checkin for Storage file (Azure#4414)

44fb56e

* Finished the restructure, refactor builder. Added sleep in record feature. Linting

Merge branch 'master' into storage-post-review1-dev

53b2854

Rename fileService to fileStorage, queueService to queueStorage.

23e55b1

sima-zhu requested review from JonathanGiles, rickle-msft and alzimmermsft July 24, 2019 23:51

sima-zhu self-assigned this Jul 24, 2019

Remove the extra README

6089f1c

alzimmermsft requested changes Jul 25, 2019

View reviewed changes

joshfree approved these changes Jul 25, 2019

View reviewed changes

joshfree added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Jul 25, 2019

sima-zhu changed the base branch from storage-post-review1-dev to master July 26, 2019 18:54

sima-zhu added 2 commits July 26, 2019 16:35

Switch account name and address feedback.

5e31e86

Remove the SAS token credential since it has conflicts with Record po…

a3656e0

…licy.

sima-zhu requested review from g2vinay, jaschrep-msft, mitchdenny and samvaity as code owners July 26, 2019 23:37

merge from mainline

804e30f

sima-zhu requested a review from alzimmermsft July 26, 2019 23:41

danieljurek reviewed Jul 27, 2019

View reviewed changes

sima-zhu added 2 commits July 29, 2019 11:06

Switch personal account with team account.

5965f2e

Remove useless

36b7120

alzimmermsft approved these changes Jul 29, 2019

View reviewed changes

mitchdenny approved these changes Jul 30, 2019

View reviewed changes

jaschrep-msft approved these changes Jul 30, 2019

View reviewed changes

sima-zhu closed this Aug 14, 2019

sima-zhu deleted the storage-service-rename branch February 23, 2021 19:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename fileService to fileStorage, queueService to queueStorage. #4571

Rename fileService to fileStorage, queueService to queueStorage. #4571

sima-zhu commented Jul 24, 2019

alzimmermsft left a comment

joshfree Jul 25, 2019

weshaggard Jul 25, 2019

sima-zhu Jul 25, 2019 •

edited

Loading

danieljurek Jul 26, 2019

sima-zhu Jul 29, 2019

danieljurek Jul 27, 2019

sima-zhu Jul 29, 2019

alzimmermsft left a comment

alzimmermsft Jul 29, 2019

sima-zhu Jul 29, 2019

jaschrep-msft left a comment

jaschrep-msft Jul 29, 2019

jaschrep-msft Jul 30, 2019

sima-zhu Jul 30, 2019

sima-zhu commented Jul 30, 2019

sima-zhu commented Aug 14, 2019

Rename fileService to fileStorage, queueService to queueStorage. #4571

Rename fileService to fileStorage, queueService to queueStorage. #4571

Conversation

sima-zhu commented Jul 24, 2019

alzimmermsft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sima-zhu Jul 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alzimmermsft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaschrep-msft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sima-zhu commented Jul 30, 2019

sima-zhu commented Aug 14, 2019

sima-zhu Jul 25, 2019 •

edited

Loading