-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to the right version. Switch test account to team account. #4710
Changes from 4 commits
8696082
e847724
2d1e3eb
a9dc37e
ed6ce97
78b648c
2de5f0e
037a807
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,9 +74,7 @@ public AzureFileStorageImpl build() { | |
this.pipeline = RestProxy.createDefaultPipeline(); | ||
} | ||
AzureFileStorageImpl client = new AzureFileStorageImpl(pipeline); | ||
if (this.version != null) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the version always get set from a static conig class ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is auto-gen class. I have the temp fix to pass the spotbugs. Loop in @jianghaolu for further discussion. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's track this, so it doesn't cause issues later. |
||
client.setVersion(this.version); | ||
} | ||
client.setVersion(this.version); | ||
if (this.url != null) { | ||
client.setUrl(this.url); | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{ | ||
"networkCallRecords" : [ ], | ||
"variables" : [ "file10519411" ] | ||
"variables" : [ "file59336dc2" ] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,42 +1,42 @@ | ||
{ | ||
"networkCallRecords" : [ { | ||
"Method" : "PUT", | ||
"Uri" : "https://sima.file.core.windows.net/dirsharename/directory863334?restype=directory", | ||
"Uri" : "https://azstoragesdkaccount.file.core.windows.net/dirsharename/directory909922?restype=directory", | ||
"Headers" : { | ||
"x-ms-version" : "2018-11-09", | ||
"User-Agent" : "azsdk-java-azure-storage-file/12.0.0-preview.1 1.8.0_201; Windows 10 10.0" | ||
"User-Agent" : "azsdk-java-azure-storage-file/12.0.0-preview.2 1.8.0_201; Windows 10 10.0" | ||
}, | ||
"Response" : { | ||
"x-ms-version" : "2018-11-09", | ||
"Server" : "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0", | ||
"ETag" : "\"0x8D70F8CB67B1F98\"", | ||
"Last-Modified" : "Tue, 23 Jul 2019 16:42:12 GMT", | ||
"ETag" : "\"0x8D71521CAC84923\"", | ||
"Last-Modified" : "Tue, 30 Jul 2019 19:11:57 GMT", | ||
"retry-after" : "0", | ||
"Content-Length" : "0", | ||
"StatusCode" : "201", | ||
"x-ms-request-id" : "a4781ee1-001a-006b-3775-4192c4000000", | ||
"x-ms-request-id" : "260a2c3b-901a-0077-060a-47b537000000", | ||
"x-ms-request-server-encrypted" : "true", | ||
"Date" : "Tue, 23 Jul 2019 16:42:11 GMT" | ||
"Date" : "Tue, 30 Jul 2019 19:11:57 GMT" | ||
} | ||
}, { | ||
"Method" : "PUT", | ||
"Uri" : "https://sima.file.core.windows.net/dirsharename/directory863334?restype=directory&comp=metadata", | ||
"Uri" : "https://azstoragesdkaccount.file.core.windows.net/dirsharename/directory909922?restype=directory&comp=metadata", | ||
"Headers" : { | ||
"x-ms-version" : "2018-11-09", | ||
"User-Agent" : "azsdk-java-azure-storage-file/12.0.0-preview.1 1.8.0_201; Windows 10 10.0" | ||
"User-Agent" : "azsdk-java-azure-storage-file/12.0.0-preview.2 1.8.0_201; Windows 10 10.0" | ||
}, | ||
"Response" : { | ||
"x-ms-version" : "2018-11-09", | ||
"Server" : "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0", | ||
"ETag" : "\"0x8D70F8CB6831042\"", | ||
"Last-Modified" : "Tue, 23 Jul 2019 16:42:12 GMT", | ||
"ETag" : "\"0x8D71521CACDEFC8\"", | ||
"Last-Modified" : "Tue, 30 Jul 2019 19:11:57 GMT", | ||
"retry-after" : "0", | ||
"Content-Length" : "0", | ||
"StatusCode" : "200", | ||
"x-ms-request-id" : "a4781ee2-001a-006b-3875-4192c4000000", | ||
"x-ms-request-id" : "260a2c3c-901a-0077-070a-47b537000000", | ||
"x-ms-request-server-encrypted" : "true", | ||
"Date" : "Tue, 23 Jul 2019 16:42:11 GMT" | ||
"Date" : "Tue, 30 Jul 2019 19:11:57 GMT" | ||
} | ||
} ], | ||
"variables" : [ "directory863334" ] | ||
"variables" : [ "directory909922" ] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be uncommented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alzimmermsft can we add back this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't worry about uncommenting this line in this PR, blobs doesn't have any snippets yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will uncommon this.