Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-json Updates #34279

Merged
merged 6 commits into from
Apr 3, 2023
Merged

azure-json Updates #34279

merged 6 commits into from
Apr 3, 2023

Conversation

alzimmermsft
Copy link
Member

Description

Updates to azure-json based on ApiView feedback. Also adds more testing.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core labels Mar 30, 2023
@alzimmermsft alzimmermsft self-assigned this Mar 30, 2023
lmolkova
lmolkova approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 31, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-json
azure-json-gson

@alzimmermsft alzimmermsft marked this pull request as ready for review April 3, 2023 14:55
@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft alzimmermsft merged commit f557e3a into Azure:main Apr 3, 2023
@alzimmermsft alzimmermsft deleted the AzJson_UpdatesToDesign branch April 3, 2023 14:57
@alzimmermsft
Copy link
Member Author

Check enforcer overridden as failing tests in "From Source" run were caused by another change being fixed in #34305.

@alzimmermsft alzimmermsft mentioned this pull request Apr 7, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@jairmyree jairmyree Awaiting requested review from jairmyree jairmyree is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @azure-sdk @lmolkova