Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade nimbus-jose-jwt in azure-security-attestation while upgrade issues are resolved #34305

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Downgrade nimbus-jose-jwt in azure-security-attestation while upgrade issues are resolved #34305

merged 1 commit into from
Apr 3, 2023

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Apr 3, 2023 •
edited
Loading

When upgrading azure-security-attestation to the latest version of nimbus-jose-jwt it was found that playback testing had failures. While this is being investigated azure-security-attestation will have its dependency of nimbus-jose-jwt downgraded back to the version previously being used. Live testing didn't see any issues, so this may be a simple case of test records needing to be re-recorded.

Between the versions of nimbus-jose-jwt the shaded JSON serialization being used changed from json-smart to gson as well as API changes, so this could simply be a case of harmless serialization changes causing test failures.

@alzimmermsft alzimmermsft self-assigned this Apr 3, 2023
@alzimmermsft
Copy link
Member Author

/azp run java - attestation

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 3, 2023
Merged
Merged
@alzimmermsft alzimmermsft merged commit 2783914 into Azure:main Apr 3, 2023
@alzimmermsft alzimmermsft deleted the AzAttestation_UseCustomNimbusJoseJwtVersion branch April 3, 2023 16:22
@vcolin7
Copy link
Member

vcolin7 commented Apr 24, 2023

Just ran into this while trying to release a new patch for the library. We'll have to re-record the tests at some point like you said @alzimmermsft. I discovered the newer version of the dependency is not escaping slashes (/) with a backslash (\) when calling JWSHeader.toString() anymore, for starters, which I suspect affects token serialization which would cause testSetAttestationPolicy() to fail.

vcolin7 pushed a commit that referenced this pull request Apr 24, 2023
@alzimmermsft @vcolin7
Downgrade nimbus-jose-jwt in azure-security-attestation while upgrade…
1f3b606 
… issues are resolved (#34305)
vcolin7 added a commit that referenced this pull request Apr 24, 2023
@vcolin7 @azure-sdk
@lmolkova @alzimmermsft
Prepare automated patch release for April 2023 (#34602)
1757521 
* Updated list of libraries to patch in patch-release.yml

* Reset sources for azure-communication-chat to the release version 1.3.6.

* Prepare azure-communication-chat for 1.3.7 patch release.

* Reset sources for azure-mixedreality-remoterendering to the release version 1.1.16.

* Prepare azure-mixedreality-remoterendering for 1.1.17 patch release.

* Reset sources for azure-monitor-query to the release version 1.1.2.

* Prepare azure-monitor-query for 1.1.3 patch release.

* Reset sources for azure-ai-textanalytics to the release version 5.2.5.

* Prepare azure-ai-textanalytics for 5.2.6 patch release.

* Reset sources for azure-messaging-eventgrid to the release version 4.15.0.

* Prepare azure-messaging-eventgrid for 4.15.1 patch release.

* Reset sources for azure-containers-containerregistry to the release version 1.0.13.

* Prepare azure-containers-containerregistry for 1.0.14 patch release.

* Reset sources for azure-iot-deviceupdate to the release version 1.0.5.

* Prepare azure-iot-deviceupdate for 1.0.6 patch release.

* Reset sources for azure-mixedreality-authentication to the release version 1.2.11.

* Prepare azure-mixedreality-authentication for 1.2.12 patch release.

* Reset sources for azure-security-attestation to the release version 1.1.11.

* Prepare azure-security-attestation for 1.1.12 patch release.

* Reset sources for azure-communication-phonenumbers to the release version 1.1.0.

* Prepare azure-communication-phonenumbers for 1.1.1 patch release.

* Reset sources for azure-messaging-eventhubs to the release version 5.15.3.

* Prepare azure-messaging-eventhubs for 5.15.4 patch release.

* Reset sources for azure-security-confidentialledger to the release version 1.0.7.

* Prepare azure-security-confidentialledger for 1.0.8 patch release.

* Reset sources for azure-communication-common to the release version 1.2.6.

* Prepare azure-communication-common for 1.2.7 patch release.

* Reset sources for azure-messaging-webpubsub to the release version 1.2.2.

* Prepare azure-messaging-webpubsub for 1.2.3 patch release.

* Reset sources for azure-data-schemaregistry to the release version 1.3.4.

* Prepare azure-data-schemaregistry for 1.3.5 patch release.

* Reset sources for azure-search-documents to the release version 11.5.5.

* Prepare azure-search-documents for 11.5.6 patch release.

* Reset sources for azure-data-schemaregistry-apacheavro to the release version 1.1.4.

* Prepare azure-data-schemaregistry-apacheavro for 1.1.5 patch release.

* Reset sources for azure-communication-identity to the release version 1.4.4.

* Prepare azure-communication-identity for 1.4.5 patch release.

* Reset sources for azure-ai-metricsadvisor to the release version 1.1.12.

* Prepare azure-ai-metricsadvisor for 1.1.13 patch release.

* Reset sources for azure-communication-sms to the release version 1.1.11.

* Prepare azure-communication-sms for 1.1.12 patch release.

* Reset sources for azure-messaging-eventhubs-checkpointstore-blob to the release version 1.16.4.

* Prepare azure-messaging-eventhubs-checkpointstore-blob for 1.16.5 patch release.

* Updated dependencies in libraries and READMEs via version_client.txt

* Undo perf test changes for Azure Container Registry 1.0.13

* Updated CheckStyle suppressions for Search.

* Fixed cspell issue.

* Fixed RevApi issue for Event Hubs Checkpointstore Blob.

* Added Schema Registry Apache Avro to the cspell ignore list.

* Downgrade nimbus-jose-jwt in azure-security-attestation while upgrade issues are resolved (#34305)

---------

Co-authored-by: azure-sdk <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Alan Zimmer <[email protected]>
vcolin7 pushed a commit that referenced this pull request Jun 21, 2023
@alzimmermsft @vcolin7
Downgrade nimbus-jose-jwt in azure-security-attestation while upgrade…
60304a0 
… issues are resolved (#34305)
vcolin7 pushed a commit that referenced this pull request Jun 21, 2023
@alzimmermsft @vcolin7
Downgrade nimbus-jose-jwt in azure-security-attestation while upgrade…
c290924 
… issues are resolved (#34305)
vcolin7 added a commit that referenced this pull request Jun 22, 2023
@vcolin7 @azure-sdk
@lmolkova @alzimmermsft
Prepare patch releases for June 2023 (#35565)
43a751f 
* Updated list of libraries to patch in patch-release.yml

* Reset sources for azure-security-confidentialledger to the release version 1.0.9.

* Prepare azure-security-confidentialledger for 1.0.10 patch release.

* Reset sources for azure-containers-containerregistry to the release version 1.1.0.

* Prepare azure-containers-containerregistry for 1.1.1 patch release.

* Reset sources for azure-communication-phonenumbers to the release version 1.1.2.

* Prepare azure-communication-phonenumbers for 1.1.3 patch release.

* Reset sources for azure-data-tables to the release version 12.3.11.

* Prepare azure-data-tables for 12.3.12 patch release.

* Reset sources for azure-monitor-query to the release version 1.2.0.

* Prepare azure-monitor-query for 1.2.1 patch release.

* Reset sources for azure-security-keyvault-keys to the release version 4.6.2.

* Prepare azure-security-keyvault-keys for 4.6.3 patch release.

* Reset sources for azure-data-schemaregistry to the release version 1.3.6.

* Prepare azure-data-schemaregistry for 1.3.7 patch release.

* Reset sources for azure-communication-sms to the release version 1.1.13.

* Prepare azure-communication-sms for 1.1.14 patch release.

* Reset sources for azure-communication-email to the release version 1.0.2.

* Prepare azure-communication-email for 1.0.3 patch release.

* Reset sources for azure-data-appconfiguration to the release version 1.4.5.

* Prepare azure-data-appconfiguration for 1.4.6 patch release.

* Reset sources for azure-monitor-ingestion to the release version 1.0.3.

* Prepare azure-monitor-ingestion for 1.0.4 patch release.

* Reset sources for azure-iot-deviceupdate to the release version 1.0.7.

* Prepare azure-iot-deviceupdate for 1.0.8 patch release.

* Reset sources for azure-communication-rooms to the release version 1.0.0.

* Prepare azure-communication-rooms for 1.0.1 patch release.

* Reset sources for azure-communication-chat to the release version 1.3.8.

* Prepare azure-communication-chat for 1.3.9 patch release.

* Reset sources for azure-messaging-webpubsub to the release version 1.2.4.

* Prepare azure-messaging-webpubsub for 1.2.5 patch release.

* Reset sources for azure-data-schemaregistry-apacheavro to the release version 1.1.6.

* Prepare azure-data-schemaregistry-apacheavro for 1.1.7 patch release.

* Reset sources for azure-ai-formrecognizer to the release version 4.0.7.

* Prepare azure-ai-formrecognizer for 4.0.8 patch release.

* Reset sources for azure-mixedreality-remoterendering to the release version 1.1.18.

* Prepare azure-mixedreality-remoterendering for 1.1.19 patch release.

* Reset sources for azure-ai-metricsadvisor to the release version 1.1.14.

* Prepare azure-ai-metricsadvisor for 1.1.15 patch release.

* Reset sources for azure-mixedreality-authentication to the release version 1.2.13.

* Prepare azure-mixedreality-authentication for 1.2.14 patch release.

* Reset sources for azure-security-keyvault-administration to the release version 4.3.2.

* Prepare azure-security-keyvault-administration for 4.3.3 patch release.

* Reset sources for azure-messaging-eventhubs to the release version 5.15.5.

* Prepare azure-messaging-eventhubs for 5.15.6 patch release.

* Reset sources for azure-security-keyvault-certificates to the release version 4.5.2.

* Prepare azure-security-keyvault-certificates for 4.5.3 patch release.

* Reset sources for azure-digitaltwins-core to the release version 1.3.9.

* Prepare azure-digitaltwins-core for 1.3.10 patch release.

* Reset sources for azure-security-keyvault-secrets to the release version 4.6.2.

* Prepare azure-security-keyvault-secrets for 4.6.3 patch release.

* Reset sources for azure-security-attestation to the release version 1.1.13.

* Updated dependencies in libraries and READMEs via version_client.txt

* Undo perf test changes for Azure Container Registry 1.0.13

* Fixed cspell issue.

* Added Schema Registry Apache Avro to the cspell ignore list.

* Downgrade nimbus-jose-jwt in azure-security-attestation while upgrade issues are resolved (#34305)

* Reset changes to the patch version.

* Updating the SDK dependencies for azure-messaging-eventhubs-checkpointstore-blob

* Fixed RevApi issue for Event Hubs Checkpointstore Blob.

* Reset changes to the patch version.

* Updating the SDK dependencies for azure-identity-extensions

* Reset changes to the patch version.

* Updating the SDK dependencies for azure-developer-loadtesting

* Updated missing READMEs.

* Removed broken link from Event Hubs samples README.

* Fixed revapi.json

* Fixed revapi.json issue.

* Finally fixed revapi.json issue.

* Reset changes to the patch version.

* Updating the SDK dependencies for azure-communication-callautomation

---------

Co-authored-by: azure-sdk <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Alan Zimmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssfang mssfang mssfang approved these changes

@samvaity samvaity Awaiting requested review from samvaity samvaity is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

@anilba06 anilba06 Awaiting requested review from anilba06 anilba06 is a code owner

@gkostal gkostal Awaiting requested review from gkostal gkostal is a code owner

@LarryOsterman LarryOsterman Awaiting requested review from LarryOsterman LarryOsterman is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @vcolin7 @mssfang