Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable names for $remainingPackages #23867

Merged
merged 18 commits into from
Sep 8, 2021

Conversation

danieljurek
Copy link
Member

This PR fixes the issue where new preview packages are not being properly onboarded in the docs.

@scbedd @mssfang

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚀🚀 🚀 🚀 🚀

@scbedd
Copy link
Member

scbedd commented Sep 1, 2021

@danieljurek apparently these changes makes it so that we can't NOT error out if there is an issue during the find dependencies stage of the script.

It's completing all the way to the end, then melting.

@danieljurek danieljurek marked this pull request as draft September 2, 2021 01:26
@danieljurek danieljurek marked this pull request as ready for review September 2, 2021 18:03
@danieljurek
Copy link
Member Author

This is ready for review now @weshaggard

While these changes should go in the complete fix will depend on merging: Azure/azure-sdk-tools#1977

Until then the docindex pipelines can fail if the last invocation of an external command (e.g. mvn in the case of Java) exits with a nonzero exit code.

Co-authored-by: Ben Broderick Phillips <[email protected]>
@danieljurek danieljurek enabled auto-merge (squash) September 8, 2021 18:27
@danieljurek danieljurek merged commit 6349ec9 into main Sep 8, 2021
@danieljurek danieljurek deleted the djurek/onboarding-new-packages-fix branch September 8, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants