-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update-DocsMsPackages.ps1 Explicitly exits 0 #1977
Update-DocsMsPackages.ps1 Explicitly exits 0 #1977
Conversation
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a confirmation. We expect the try/catch
above this to catch any actual issues that are thrown. This is purely to avoid the mvn
command (in that specific example) from setting $LASTEXITCODE
explicitly.
@scbedd -- Correct. The last execution of an external command sets
|
This is why I've been getting all those docindex failed emails...:D |
* Fix variable names for $remainingPackages * Route stderr to stdout to prevent errors in mvn from breaking the docs onboarding process * Stringify potential error objects * Out-String * Redirect artifact download output * Out-Null * Test exit 1 * Test powershell task behavior * Test powershell task behavior * Test powershell task behavior with an explicit exit 0 * Sparse checkout Java repo * Revert Update-DocsMsPackages.ps1. Those changes are coming in Azure/azure-sdk-tools#1977 * Revert changes to Language-Settings.ps1 to use intended variable changes only * Tweak sparse checkout * Use a single checkout: none * Use default checkout * Revert to original SkipDefaultCheckout: true * Update eng/scripts/Language-Settings.ps1 Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]>
/azp run azure-sdk-tools - sync - eng-common |
Azure Pipelines successfully started running 1 pipeline(s). |
The following pipelines have been queued for testing: |
/azp run azure-sdk-tools - sync - eng-common |
Azure Pipelines successfully started running 1 pipeline(s). |
The following pipelines have been queued for testing: |
…ate up to a failure of the pipeline
6125b91
to
31371ed
Compare
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Exit 0 so DevOps doesn't fail the build when the last command called by the domain-specific function exited with a non-zero exit code.
Specifically this mitigates issues in Java where the docindex pipeline fails because an inner
mvn
command failed during validation. The whole script succeeds because we properly handle errors but PowerShell just reads$LASTEXITCODE