Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable names for $remainingPackages #23867

Merged
merged 18 commits into from
Sep 8, 2021
Merged

Fix variable names for $remainingPackages #23867

Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4c6dbf3
Fix variable names for $remainingPackages
danieljurek Sep 1, 2021
6195a63
Route stderr to stdout to prevent errors in mvn from breaking the doc…
danieljurek Sep 1, 2021
48e57da
Stringify potential error objects
danieljurek Sep 1, 2021
843d7ca
Out-String
danieljurek Sep 1, 2021
0c27335
Redirect artifact download output
danieljurek Sep 1, 2021
02333ab
Out-Null
danieljurek Sep 1, 2021
c1a64fe
Test exit 1
danieljurek Sep 2, 2021
104d857
Test powershell task behavior
danieljurek Sep 2, 2021
df9056e
Test powershell task behavior
danieljurek Sep 2, 2021
82f9df1
Test powershell task behavior with an explicit exit 0
danieljurek Sep 2, 2021
ebb6312
Sparse checkout Java repo
danieljurek Sep 2, 2021
135b8f6
Revert Update-DocsMsPackages.ps1. Those changes are coming in https:/…
danieljurek Sep 2, 2021
15a3acd
Revert changes to Language-Settings.ps1 to use intended variable chan…
danieljurek Sep 2, 2021
fc9ea4f
Tweak sparse checkout
danieljurek Sep 2, 2021
d95dfbf
Use a single checkout: none
danieljurek Sep 2, 2021
529e8bb
Use default checkout
danieljurek Sep 2, 2021
943e727
Revert to original SkipDefaultCheckout: true
danieljurek Sep 2, 2021
07c97c4
Update eng/scripts/Language-Settings.ps1
danieljurek Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ function PackageDependenciesResolve($artifactNamePrefix, $packageDirectory) {
-f $downloadedPomPath `
dependency:copy-dependencies `
-P '!azure-mgmt-sdk-test-jar' `
-DoutputDirectory="$packageDirectory"
-DoutputDirectory="$packageDirectory" 2>&1

if ($LASTEXITCODE) {
LogWarning "Could not resolve dependencies for: $pomArtifactName"
Expand Down Expand Up @@ -461,11 +461,11 @@ function UpdateDocsMsPackages($DocConfigFile, $Mode, $DocsMetadata) {
$remainingPackages = @()
if ($Mode -eq 'preview') {
$remainingPackages = $DocsMetadata.Where({
$_.VersionPreview.Trim() -and !$outputPackagesHash.ContainsKey("$($package.packageGroupId):$($package.packageArtifactId)")
$_.VersionPreview.Trim() -and !$outputPackagesHash.ContainsKey("$($_.GroupId):$($_.Package)")
})
} else {
$remainingPackages = $DocsMetadata.Where({
$_.VersionGA.Trim() -and !$outputPackagesHash.ContainsKey("$($package.packageGroupId):$($package.packageArtifactId)")
$_.VersionGA.Trim() -and !$outputPackagesHash.ContainsKey("$($_.GroupId):$($_.Package)")
})
}

Expand All @@ -487,7 +487,7 @@ function UpdateDocsMsPackages($DocConfigFile, $Mode, $DocsMetadata) {

Write-Host "Add new package from metadata: ${packageGroupId}:$packageName"
$package = [ordered]@{
packageArtifactId = $packageArtifactId
packageArtifactId = $packageName
packageGroupId = $packageGroupId
packageVersion = $packageVersion
packageDownloadUrl = "https://repo1.maven.org/maven2"
Expand All @@ -509,7 +509,7 @@ function UpdateDocsMsPackages($DocConfigFile, $Mode, $DocsMetadata) {

$outputJson = ConvertTo-Json $packageConfig -Depth 100
Set-Content -Path $DocConfigFile -Value $outputJson
Write-Host "Onboarding configuration written to: $DocConfigFile"
Write-Host "Onboarding configuration ($Mode) written to: $DocConfigFile"
danieljurek marked this conversation as resolved.
Show resolved Hide resolved
}

# function is used to filter packages to submit to API view tool
Expand Down