Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core April GA Release #4515

Closed
wants to merge 93 commits into from
Closed

Core April GA Release #4515

wants to merge 93 commits into from

Conversation

antkmsft
Copy link
Member

@antkmsft antkmsft commented Apr 5, 2023

This PR is for review purposes only. It is not meant to be merged to main.
The GA release will be cut from this, hotfix/azure-core_1.8.1 branch.

This PR contains cherry-picked commits for the entire repo, except the few ones that we don't want to release.
As of the public features in the Core SDK code - it only includes bug fixes.
It also includes test/CI infrastructure improvements (so that the release pipelines run well when we release).
And finally, it includes one unique commit with the changelog update.

You can see the individual commits just below this PR description.

See also #4516.

Comment on lines +3 to +13
## 1.8.1 (2023-04-06)

### Bugs Fixed

- [[#4213]](https://github.com/Azure/azure-sdk-for-cpp/issues/4213) Fixed a bug where `Host` request header is not set for non-default port (80, 443).
- [[#4443]](https://github.com/Azure/azure-sdk-for-cpp/issues/4443) Fixed potentially high CPU usage on Windows.

### Other Changes

- Libcurl transport doesn't add `Content-Length` request header for GET/HEAD/DELETE requests anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RickWinter, it includes Other Changes/Content-Length header because it is the part of the same commit as Bugs Fixed/Host header (084a9f2#diff-cc1b46c667702f97b0f4104c7637ccca9da686d2df0cd9e47a39f12ced659897)

azure-sdk and others added 22 commits April 5, 2023 10:33
* Increment package version after release of azure-core

* Increment package version after release of azure-core-tracing-opentelemetry
* update artifacts

* remove error

* try

* gfd

* folderlist

* put back core
* add Files Datalake README.md

* add file share README.md

* add queues README.md
* Modify files by adding an extra space to trigger spell check on all.

* Modify newer files.

* Modify new files that got added.

* Modify all markdown files to trigger spell check on those.

* Fix spelling errors and update cspell to remove out-dated exceptions.

* Add back mypgrogram exception for the readme from azure-core.

* Revert test edits to markdown files.

* Revert test changes to source and header files.

* Remove modification to leftover source files.
* kv release

* ds

* Update sdk/keyvault/azure-security-keyvault-administration/CHANGELOG.md

Co-authored-by: Ahson Khan <[email protected]>

* core to latest GA

* 1.8.0

* update folder list

* put to stable versions

* put back to last GA

* put back to original

* try core 1.8.0

* Revert "try core 1.8.0"

This reverts commit 1e0b612.

---------

Co-authored-by: Ahson Khan <[email protected]>
* lll

* sss

* oipio

* vcvc

* enable test proxy start at test suite start for KV and storage , example created for attestation, we cannot find the base definitions for the test suites,

* Contrib

* clangs

* clangs

* test logs

* pipeline

* more clangs

* pipeline

* clang

* try try again

* try try again

* try again

* try again

* again

* update paths , moved to macro , call macro in target code

* core

* capitalization
* Identity February Release

* Accumulate changelog entries from previous Beta releases

* Update core minimum version requirement

* Best way to fix which may not work in CI

* Drop version from cmakelists

---------

Co-authored-by: Anton Kolesnyk <[email protected]>
* Attestation February Release

* Changelog (repeat Beta changes)

* Update azure core minimum version dependency

---------

Co-authored-by: Anton Kolesnyk <[email protected]>
* storage february release

* fix conversation

* fix conversation
* Increment package version after release of azure-storage-blobs

* Increment package version after release of azure-storage-files-shares
* Remove language from profile zip

* Revert "Remove language from profile zip"

This reverts commit 2f670435b25f89955338170a7bdfbe4432cbe23f.

* Remove Services parameter

* Fix path to tests-file

* Run both sync and async tests by default

* Add LanguageVersion to common perf.yml

---------

Co-authored-by: Mike Harder <[email protected]>
Co-authored-by: Konrad Jamrozik <[email protected]>
azure-sdk and others added 12 commits April 5, 2023 10:52
* rerun flag

* rerun failed stress test

* naming & commenting

* update

* function and var renaming for better readability

* readability & exit on error

---------

Co-authored-by: Albert Cheng <[email protected]>
… suffix in the value, when using `CryptographyClient`. (#4467)

* Fixed the user-agent string sent to the service to include the "keys"
suffix in the value, when using `CryptographyClient`.

* Fix clang format.
* ongoing

* Move get-codeowners scripts and tests to their own dirs

* address PR remarks

* Fix CodeOwnerFileLocation path, fix casing, and dedup param defaults

* fix param names

* add todos on needed changes in cpp repo

* Add CodeownersFileLocation to Get-Codeowners and use $null for default param values

* move get-codeowners back to scripts/ and rename -functions to .lib

* fix: use empty string as defaults instead of $nulls, to fix invocation

* fix bug with invocation of Get-Codeowners + add support for passing IncludeNonUserAliases as switch

* fix path iin Metadata-Helpers.ps1

* fix typo

* Update archetype-cpp-release.yml

---------

Co-authored-by: Konrad Jamrozik <[email protected]>
* First attempt at fixing nlohmann doctest compilation error

* fixed compilation issue

* Fixed ApiView generation for azure core
* First cut at migrating Ubuntu 18 to 22 directly in the matricses

* Try 20.04

* Remove azure.list from apt configuration on 22.04

* Parens

* gpp-8 on Ubuntu 20.04

* Remove g++-5

* Move config changes to steps/

* Remove g++-5 from live tests

* Update eng/pipelines/templates/steps/fix-linux-1es-configs.yml

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Review feedback

* Finish renaming

* Setting line coverage target to 91%

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
* Removed 'using namespace' directive from public header

* Shortened namespace names (Thanks Antkmsft)

* Update sdk/keyvault/azure-security-keyvault-administration/inc/azure/keyvault/administration/settings_client.hpp

Co-authored-by: Anton Kolesnyk <[email protected]>

---------

Co-authored-by: Anton Kolesnyk <[email protected]>
@antkmsft antkmsft force-pushed the hotfix/azure-core_1.8.1 branch from 1501169 to 98e9c4f Compare April 5, 2023 17:55
Co-authored-by: Ben Broderick Phillips <[email protected]>
@antkmsft antkmsft force-pushed the hotfix/azure-core_1.8.1 branch 2 times, most recently from 72e1bbb to c539cb6 Compare April 5, 2023 21:52
@Azure Azure deleted a comment from azure-pipelines bot Apr 5, 2023
azure-sdk and others added 3 commits April 5, 2023 21:31
* Stg87 protocol layer (#4374)

* storage stg87 protocol layer

* Storage/feature/stg87-hns encryption context (#4383)

* hns_encryption_context

* Storage/feature/stg87-trailing dot (#4389)

 trailing dot

* Storage/feature/stg87-File OAuth (#4413)

* file oauth

* enable some stg87 tests
@antkmsft antkmsft force-pushed the hotfix/azure-core_1.8.1 branch from 051f08b to ea97acc Compare April 6, 2023 04:34
@antkmsft antkmsft force-pushed the hotfix/azure-core_1.8.1 branch from ea97acc to 0a881eb Compare April 6, 2023 04:36
Copy link
Member

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit worried we have non-core commits in here (identity, keyvault, storage and their tests), even though core is at the bottom of the object dependency graph, but not sure if there's a "cleaner" alternative.

@ahsonkhan
Copy link
Member

Can you please share the list of commits that aren't included in the release?

@antkmsft
Copy link
Member Author

antkmsft commented Apr 6, 2023

@ahsonkhan, the command is git cherry -v <hotfix_branch> main.

The - indicates the commit that is present on both sides.
+ indicates the commit that is only in main.

PS C:\src\azure-sdk-for-cpp> git cherry -v hotfix/azure-core_1.8.1 main
- 6a53e4122f74937ff81ef736407128c548e4417c Increment version for core releases (#4338)
- a464844bd15cc85872e301964476376ec46a8d2e Added information for configuring linux or other OS package manager to install OpenSSL (#4336)
- 310790a5c13d8982e2e74e2302c2af8b538315bb Update artifacts for ci.yml (#4330)
- cad042256b2aec77f65203e8ae66ea8d93dd382f proper regex for win 2022 (#4339)
- e8e0680cc309424b6f35d8d6e9efb6faf5748252 update storage README(datalake&shares&queues) (#4318)
- 1abebf96615ad4c553d97b011b56880db515a566 Fix cspell flagged typos across the repo by triggering it on all files.
- 39ec586d961f2461ffb4cbd0e3bac6ffc8566b9c Feb key vault release (#4319)
- 3762c59552f4901d26c2b267f894f48fc5d319f1 Test proxy start (#4295)
- 52c77153e0364c6d2f8be9d45c981d54b12d23fa Identity February Release (#4317)
- 46fbcb914c50c24bd37662817899b713216f090e Increment package version after release of azure-security-keyvault-administration (#4340)
- 8286a1c0aeecea7afd0d38e2a3b90cb731021bc9 Increment package version after release of azure-identity (#4342)
- 08a267275d7006b43384bd205bcf07f275f2d9aa Attestation February Release (#4326)
- 2be39bcc8b428bb2e5383ee65719f74eff7967aa Increment package version after release of azure-security-attestation (#4345)
- c3dc7321577fa99ddbf473fdf2a9454c2e388702 Storage February release (#4324)
- 5ac3f00d589eb003162ed89adcc062b50dfd225c Increment version for storage releases (#4346)
- cf1490fe8013cec71125396e10a0264546123696 Sync eng/common directory with azure-sdk-tools for PR 5083 (#4348)
- fd1695ebbafe862be06a9c9f88afa87a61878c5b [Perf] Refactor tests.yml into one file per package per language (#4270)
- c8b97561f346fbdb9eec4c7bfdf4a2a4713fc276 changelog (#4350)
- dc972e1ab96f9376694ff3640053caaaf8e4bf7b Update `CODEOWNERS` paths: fix invalid paths (#4349)
- 5e0159d8faf1600998f1973b6793f25b1c50144c Improve diagnostics for copy-docs-to-blobstorage script (#4351)
+ 4d894adc51596a7d6500041d517e827e73fb99b6 Fix compilation on Visual Studio 2017 (#4352)
+ 326ec44db886c01a056b2ac915a35e2f39a66476 Update changelog to reflect community contribution (#4355)
- 466c82a361f45aafe959fe2274507c5a265c4245 Sync eng/common directory with azure-sdk-tools for PR 5427 (#4356)
- f8a1e7fc5c5ce55ffc86742339b966bf7cc5a7c2 remove obsolete tests (#4357)
- afaefd3d05d5a43f20cd1894a52f6a32f2bce5a0 Sync eng/common directory with azure-sdk-tools for PR 5456 (#4362)
- 0fc14a74646a2069c109a08066a343bb169d5cc0 Sync eng/common directory with azure-sdk-tools for PR 5103 (#4367)
- b1efed36d5fca9abbaa8d92a175622c10f0cfbd2 MMS2022 -> windows-2022 (#4368)
- 971d20be3e2e0e7dba0b0c6bf2d33df78863d9c8 Where applicable, update Windows pools used to `azsdk-pool-mms-win-2022-general` and rename `vmImage` to the `windows-20xx` format (#4360)
- 30afd1eb89f586a69f448495965311278927de55 reworked docker file (#4344)
- 889e0255a2a928a5eaf0fdc40ec53284ab7ee091 update comment (#4364)
- 9572608a5dd0fba2e5074fd030ed6cc9c31535a0 Docker comment (#4375)
- 5058f15594058b77ceded8309da7618304a7793a Trigger`keyvault` on proxy changes (#4343)
- 7da07d5072b8714974acbf51f4fb738c713d9fe9 Generate API review for C++ using new parser (#4302)
- f45d8f6b2f82734e861455d964d24fc8745f807b Add vmImage back to common perf.yml - Fixes #5466 - Partially reverts #5456 (#4376)
- 184959758055ff4a4b7486b7cbef752b611716e6 Fix pipelines path (#4358)
+ 395e9a0640eecf69ba141e8fc69e591a6c62e0e3 Test proxy & storage tests improvements (#4241)
- 78eabdc1af9b55e686935770119f3df72d681b03 Temporarily pin Node 18 to 18.13.0 - Fixes #5536 (#4378)
- 737037d1af078337d3b4cd6bdd6ebb8a9bb4b23a Storage tests improvement (#4382)
- 365966de73f4b278b481c36f35c9dabaf9400bc8 Update CODEOWNERS (#4380)
- 8cd4ecbb79b4da454570de60fd02f522733aaf24 show headers and query parameters in storage CI pipeline (#4379)
- 77a849ffac6b734476f5b821753c692f015f7693 Sync eng/common directory with azure-sdk-tools for PR 5431 #2501
- 1df70cb1044a37a73cb77dcb4954aaecaf1d8241 Sync eng/common directory with azure-sdk-tools for PR 5562 (#4384)
- 71a7cfb0c1ea7657406a796266a6fdfd4e9aff3a Fix Share Client failure #4377 (#4381)
- 5059347098c511b5de11c9d112eb11f7a330870c decrease request count to avoid throttling errors for storage tests (#4385)
- 127073119c9973d7c7ca9019a819ddc34977dd4c Sync eng/common directory with azure-sdk-tools for PR 5568 (#4387)
+ e2a1b99a0625d6309e22474332fb3c342b4a2dc6 Add support to ignore invalid cert common name (#4361)
- e48cf927042ab828bee5bdd14ed509a8f3388300 update to version 7.4 for admin. update tests (#4388)
- 4ab6a41cf1f385f52a7522c5b0fc4092f665bd87 update proxy version to include Info/Active against individual sessions + allow delayed response (#4391)
- 4c22ce6ab0f4f92b88c183fd3659c9fd01c063d9 Sync eng/common directory with azure-sdk-tools for PR 5540 (#4396)
+ c8b028dce071cd3ae582075a5063c875a4b49bad Follow-up to update changelog to reflect community contribution (#4393)
- ecb5f3db1c3b74121a788a945e180178be96820c logging api post request body (#4404)
- ab7b238197f68a638bea9ec5af76a81703e91924 Sync eng/common directory with azure-sdk-tools for PR 5595 (#4400)
- 50589d65b5b08346cd05c344cca8998fd0805d72 Always release to vcpkg when doing Daily Release (#4334)
- 2850c5d32c8a86491b49e801433b8f186fa81745 Storage March Release (#4410)
- 6706c20b2629719b4a0dd1bbf018748162a5c2b9 Add product slug for Web PubSub (#4415)
- d8f6aa9d2736661961c6546e0f1f407176f246c5 First cut at removing proxy tests (#4416)
- 3bebe6ff992b1479ebc35e0b8d372990f60e9fda Kv admin march release (#4402)
- 7159ad3e756f40109cf20534f580c24f48985d4c Update CHANGELOG.md (#4414)
- 2c64e3e83c94cd7d6f7d3254c21116e179796376 Increment version for storage releases (#4412)
- fc61bb4848157ee808fb4c7782b2010a759e7288 Add DefaultAzureCredential (#4409)
- b46ee09627d0fa906f660256da1ce8c1ceaa639b Increment package version after release of azure-security-keyvault-administration (#4423)
- d114e4d58de48958b932bb9b48dc82474f0377e6 Increment package version after release of azure-identity (#4426)
- 7946b83b9bd4445badb053d655f23597ff49b593 separate hsm tests from keys, and regen the tests (#4392)
- 5e91f5584ee1a3f8ca56e7b20376bf7900a42c46 Enable profiling in perf piplines. (#4398)
- 562ca4c69c2d2887b3241eefe2aae9a33c4037cf Fixed credscan error (#4417)
- c673e9550caaee17dc6a845a4d788e0702375c47 Update vcpkg release manifest templates per vcpkg team recommendation (#4425)
- 61003a921e7babd3a429b40a4c60b726b48fa612 Create CMakePresets.json as an alternative to cmakesettings.json (#4429)
- f0a26fd4ad149d81ab4e9c11781622eeb6c68a7f enable true version override so that other tools also have a shot at picking up the replaced version (#4440)
+ ef24dfda2ef64d9282020adc5cb351eac0cf2834 Add GetCredentialName() (#4428)
- 6f2e39a5c505326a1246886f0ec34522766397e1 Sync eng/common directory with azure-sdk-tools for PR 5702 (#4453)
+ 9f19a28af34824e45e2fdb9d27cad18b0d6183a2 Use aka.ms link to Identity troubleshooting (#4449)
+ acb8e3b9e67dc0aaca190f016990a3449de1bc1c Undocument ChainedCred usage by DefaultAzCred & remove friend and private ctor (#4447)
- f8ae5d9d8b641aefcdd664c2c3cf204a072d3934 Sync eng/common directory with azure-sdk-tools for PR 5691 (#4450)
- 14677e92be8dc2dab97ecfdbcae9bd0d3e1da894 fix cspell for readme.ms in libcurl sterss test (#4441)
+ 83f736d8ad97987f461408bc32b4f8e56533e700 Simpler identity logging (#4455)
- d5e4a5c48b87c5213bcc787986eb23a74060a974 3rd Party Libs in Samples (#4408)
- ade505d087dbc81c28f0ac61fcd82d439c89fbbd Update changelog with issue link (#4458)
- 43632ebce82cd1d61d28b37b4b05fe662ef105ac Tests: replace most `EXPECT_TRUE(a OP b)` with `EXPECT_OP(a, b)` (#4457)
- a08730142cf212c7b192ef85cdebd490a9ccc981 Revert "[check-spelling] Temporarily pin Node 18 to 18.13.0 (#5537)" (#4456)
+ ba086576be4995a14a6ca3d17aba74374a6ad1ee Fix potentially high CPU usage on Windows (#4448)
- c457e91373406de2eb3f3f2cf2b16bad2b684ed0 Ensure the comparison is unsigned to unsigned (#4464)
- bd98ee06ec610a6f42c93b8bd59e0c68d7969fb4 Sync eng/common directory with azure-sdk-tools for PR 5742 (#4465)
- a91ff6345e2788e3d4ad0f4ae8895f2fa5a34762 Update CODEOWNERS (#4461)
+ 2a39a3422b1ffaceea8ccf73dcc3e807ebf814b8 Organize applying Identity log prefix (#4459)
- e9f900f7d27c95b1b1c279991606079939bec8fc Explicitly set PSNativeCommandArgumentPassing to Legacy for git push script (#4481)
- ef5aec8b4c8633bd5d41333191bc3200ad0a4fdb Fix unmatched parenthesis in doc (#4482)
- 42017bf69e71ee9dc82ba9c3e61ccc76581bb778 fix concurrent upload failures (#4484)
- 97c7630c2d31f52c79d5a44a0b4d6f8af973ee76 Sync eng/common directory with azure-sdk-tools for PR 5726 (#4488)
- 57a4f8de9a8357ecd4fd9c0de0f67bc7d01b2fcd Fixed the user-agent string sent to the service to include the "keys" suffix in the value, when using `CryptographyClient`. (#4467)
- cef3d3144b1005a36194fd126eebf742364b5a6a Temporarily update platform-matrix.json to remove openssl_111n configuration (#4493)
- 699957280939d4ba7d8c6e0606f0b71cd59f2970 Sync eng/common directory with azure-sdk-tools for PR 5608 (#4411)
- 6e810750bee4ca4f2f5204c0e9d349cf4219c2f3 First attempt at fixing nlohmann doctest compilation error (#4499)
- 3d17447cceec68f2e191ebc2f8e5b6a49241d833 update doctest lib to 2.4.11 (#4501)
- c2e845266bc976079abc26143973740d9449ff1e Migrate Ubuntu 18 to 22 directly in the matricses (#4442)
- 02bb09aac17c0b45a9ed12d759a44eca5176120a Add support for Ubuntu 22 to Get-BinarySzies.ps1 (#4511)
+ fd687c32fa18bd8f1daacadd8c8aff870eb08e26 Add support for challenge-based and multi-tenant authentication (#4506)
- 3cb49934238aad9a1615e4ce98dbf360d48158c6 Removed 'using namespace' directive from public header (#4514)
- d55e2906077b6edcbb42d51ad2becd0492f1ffcf Bump credscan to 2.3.12.23 (#4519)
- 92886eec9473da70a54c7f4cc2b4bac6cb6bc1a4 Fix regression - base name overrides in CI (#4520)
- 58bfb483c68638804f6136ea8a1f1305a1a3b119 Storage April Release (#4513)
- 779c268a7f218c0a5a341f9ba4d402d3cfc3cac8 Use new ApiView parser (#4521)
+ 0a881eb6a9d7d69483b22d33b9af7cfbd7dd90af Core April GA Release

@antkmsft
Copy link
Member Author

antkmsft commented Apr 6, 2023

@ahsonkhan and I think the reason it has 395e9a0640eecf69ba141e8fc69e591a6c62e0e3 as "+" is that I needed to resolve a conflict for it (different lines in CHANGELOG.md), so therefore it got different SHA.

@antkmsft antkmsft closed this Apr 6, 2023
@antkmsft antkmsft deleted the hotfix/azure-core_1.8.1 branch April 6, 2023 21:51
@ahsonkhan
Copy link
Member

ahsonkhan commented Apr 6, 2023

`+ ba08657 Fix potentially high CPU usage on Windows (#4448)

I am surprised that shows up as a + for a commit that is only in main.

Also, I wouldn't expect this to be in the main branch, as that's only for the GA'd release branch:

`+ 0a881eb Core April GA Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.