-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage/feature/stg87-trailing dot #4389
Merged
microzchang
merged 3 commits into
Azure:feature/storage-stg87
from
microzchang:stg87_trailing_dot
Mar 7, 2023
Merged
Storage/feature/stg87-trailing dot #4389
microzchang
merged 3 commits into
Azure:feature/storage-stg87
from
microzchang:stg87_trailing_dot
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microzchang
requested review from
vinjiang,
katmsft,
Jinming-Hu,
EmmaZhu,
antkmsft,
vhvb1989,
gearama and
LarryOsterman
as code owners
February 27, 2023 09:11
microzchang
force-pushed
the
stg87_trailing_dot
branch
from
February 28, 2023 02:45
54e34e2
to
cb66702
Compare
microzchang
requested review from
danieljurek,
weshaggard,
benbp,
jsquire,
RickWinter,
ronniegeraghty,
gkostal,
anilba06,
olkroshk,
ahmadmsft and
ahsonkhan
as code owners
February 28, 2023 02:45
microzchang
force-pushed
the
stg87_trailing_dot
branch
from
March 6, 2023 05:42
cb66702
to
b1b8b98
Compare
Jinming-Hu
reviewed
Mar 6, 2023
sdk/storage/azure-storage-files-shares/test/ut/share_directory_client_test.cpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-files-shares/test/ut/share_directory_client_test.cpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-files-shares/test/ut/share_directory_client_test.cpp
Outdated
Show resolved
Hide resolved
Jinming-Hu
approved these changes
Mar 6, 2023
/azp run cpp - storage |
Azure Pipelines successfully started running 1 pipeline(s). |
microzchang
added a commit
to microzchang/azure-sdk-for-cpp
that referenced
this pull request
Apr 4, 2023
trailing dot
microzchang
added a commit
to microzchang/azure-sdk-for-cpp
that referenced
this pull request
Apr 4, 2023
trailing dot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.