Feb key vault release #4319
Merged
Feb key vault release #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gearama
requested review from
vhvb1989,
antkmsft and
RickWinter
as code owners
|
I think we rather should update the core minimum version from "1.5.0" to "1.8.0" in |
antkmsft
reviewed
Feb 2, 2023
sdk/keyvault/azure-security-keyvault-administration/CHANGELOG.md
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Feb 2, 2023
sdk/keyvault/azure-security-keyvault-administration/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ahson Khan <[email protected]>
|
but 1.8.0 has not been released, we are also releasing 1.8.0-beta4 , the last GA one is 1.7.2 |
|
@gearama, we are releasing Core 1.8.0 tomorrow. But sorry for the rather bad suggestion about updating the CMakeLists.txt. But the other two files from the |
antkmsft
reviewed
Feb 2, 2023
sdk/keyvault/azure-security-keyvault-administration/CMakeLists.txt
Outdated
Show resolved
Hide resolved
antkmsft
approved these changes
Feb 3, 2023
antkmsft
reviewed
Feb 3, 2023
…nto FebKVRelease
This reverts commit 1e0b612.
antkmsft
pushed a commit
that referenced
this pull request
Apr 5, 2023
* kv release * ds * Update sdk/keyvault/azure-security-keyvault-administration/CHANGELOG.md Co-authored-by: Ahson Khan <[email protected]> * core to latest GA * 1.8.0 * update folder list * put to stable versions * put back to last GA * put back to original * try core 1.8.0 * Revert "try core 1.8.0" This reverts commit 1e0b612. --------- Co-authored-by: Ahson Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.