-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #8458
[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #8458
Conversation
…eDays (#8457) Co-authored-by: gdlxm <[email protected]> Co-authored-by: iscai-msft <[email protected]>
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
* Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching.
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side.
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
The validation passed, I checked the two checkboxes in the issue description which retriggered the pipelines, then they failed (i.e. no code changes). @akning-ms can your team look into this? |
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run automation - sdk Timeout in JavaScript SDK generation - the other ones that previous failed without code change passed. |
No pipelines are associated with this pull request. |
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
…stable/2019-09-01 (Azure#8458) * Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays (Azure#8457) Co-authored-by: gdlxm <[email protected]> Co-authored-by: iscai-msft <[email protected]> * Added `enableRbacAuthorization` property to Key Vault management plane (Azure#8468) * Add default=90 to softDeleteRetentionInDays (Azure#8476) * Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching. Co-authored-by: gdlxm <[email protected]> Co-authored-by: iscai-msft <[email protected]> Co-authored-by: Fernando Colombo <[email protected]>
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: