Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #8458

Merged
merged 3 commits into from
Feb 22, 2020
Merged

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #8458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6efd36a
Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverabl…
heaths Feb 21, 2020
aa3b9ee
Added `enableRbacAuthorization` property to Key Vault management plan…
msfcolombo Feb 21, 2020
6b46480
Add default=90 to softDeleteRetentionInDays (#8476)
gdlxm Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
/specification/insights/ @gucalder
/specification/intune/ @vrmurthy01
/specification/iothub/ @rkmanda
/specification/keyvault/ @schaabs
/specification/keyvault/ @schaabs @heaths
/specification/logic/ @pankajsn @tonytang-microsoft-com
/specification/machinelearning/ @nonstatic2014
/specification/machinelearningcompute/ @shutchings
Expand Down
6 changes: 4 additions & 2 deletions .../resource-manager/Microsoft.KeyVault/preview/2018-02-14-preview/examples/deleteVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
},
"responses": {
"200": {
"headers": {},
"body": ""
"headers": {}
},
"204": {
"headers": {}
}
}
}
8 changes: 2 additions & 6 deletions ...rce-manager/Microsoft.KeyVault/preview/2018-02-14-preview/examples/purgeDeletedVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
"api-version": "2018-02-14-preview"
},
"responses": {
"200": {
"body": ""
},
"202": {
"body": ""
}
"200": {},
"202": {}
}
}
3 changes: 3 additions & 0 deletions ...ion/keyvault/resource-manager/Microsoft.KeyVault/preview/2018-02-14-preview/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,9 @@
"responses": {
"200": {
"description": "OK Response."
},
"204": {
"description": "No Content."
}
},
"x-ms-examples": {
Expand Down
26 changes: 24 additions & 2 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,19 @@
},
"enableSoftDelete": {
"type": "boolean",
"description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If omitted, assume true as default value. Once set to true, cannot be reverted to false."
"default": true,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If it's not set to any value(true or false) when creating new key vault, it will be set to true by default. Once it's been set to true value, it can NOT be reverted to false."
},
"softDeleteRetentionInDays": {
majastrz marked this conversation as resolved.
Show resolved Hide resolved
"type": "integer",
"format": "int32",
"default": 90,
"description": "softDelete data retention days. It accepts >=7 and <=90."
},
"enableRbacAuthorization": {
"type": "boolean",
"default": false,
"description": "Property that controls how data actions are authorized. When true, the key vault will use Role Based Access Control (RBAC) for authorization of data actions, and the access policies specified in vault properties will be ignored (warning: this is a preview feature). When false, the key vault will use the access policies specified in vault properties, and any policy stored on Azure Resource Manager will be ignored. If null or not specified, the vault is created with the default value of false. Note that management actions are always authorized with RBAC."
},
"createMode": {
"type": "string",
Expand Down Expand Up @@ -1191,7 +1203,17 @@
},
"enableSoftDelete": {
"type": "boolean",
"description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If omitted, assume true as default value. Once set to true, cannot be reverted to false."
"default": false,
"description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If omitted, assume false as default value when patching an existing vault. Once set to true, cannot be reverted to false."
},
"softDeleteRetentionInDays": {
"type": "integer",
"format": "int32",
"description": "softDelete data retention days. It accepts >=7 and <=90."
},
"enableRbacAuthorization": {
"type": "boolean",
"description": "Property that controls how data actions are authorized. When true, the key vault will use Role Based Access Control (RBAC) for authorization of data actions, and the access policies specified in vault properties will be ignored (warning: this is a preview feature). When false, the key vault will use the access policies specified in vault properties, and any policy stored on Azure Resource Manager will be ignored. If null or not specified, the value of this property will not change."
},
"createMode": {
"type": "string",
Expand Down