-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added enableRbacAuthorization
property to Key Vault management plane
#8468
Added enableRbacAuthorization
property to Key Vault management plane
#8468
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
Please address whether this is breaking change. Also you might want to check whether enum would be better. This is not master branch? What kind of review do you need? Do you need ARM review? |
azure-sdk-for-java
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-net
|
azure-sdk-for-python
|
a9df905
to
1493075
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks for quick reply. This is not a breaking change. Old clients doesn't have to specify the new property and the vault will be created as before. Old clients may also perform get-modify-patch without risk of overwriting data from new clients (if the old client removes the property, the service will not modify existing value). We have considered enum, but this will be displayed as a checkbox in the Portal and there is no plan to support more values than yes/no. Hence a bool was considered more consistent. I have amended with improved descriptions matching the PUT and PATCH semantics. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
aa3b9ee
into
Azure:dev-keyvault-Microsoft.KeyVault-2019-09-01
Yes, this is going into a feature branch for a final review of complete features (for preview). This is a common practice throughout Microsoft (and most GitHub projects) that OpenAPI Hub doesn't yet support. |
…stable/2019-09-01 (#8458) * Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays (#8457) Co-authored-by: gdlxm <[email protected]> Co-authored-by: iscai-msft <[email protected]> * Added `enableRbacAuthorization` property to Key Vault management plane (#8468) * Add default=90 to softDeleteRetentionInDays (#8476) * Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching. Co-authored-by: gdlxm <[email protected]> Co-authored-by: iscai-msft <[email protected]> Co-authored-by: Fernando Colombo <[email protected]>
…stable/2019-09-01 (Azure#8458) * Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays (Azure#8457) Co-authored-by: gdlxm <[email protected]> Co-authored-by: iscai-msft <[email protected]> * Added `enableRbacAuthorization` property to Key Vault management plane (Azure#8468) * Add default=90 to softDeleteRetentionInDays (Azure#8476) * Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching. Co-authored-by: gdlxm <[email protected]> Co-authored-by: iscai-msft <[email protected]> Co-authored-by: Fernando Colombo <[email protected]>
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.