Add privateLinkConnectionProperties to network interface.

[bowen0106]

Adding one property in network interface to display private link connection properties.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[AutorestCI]

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpczu0297z/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpczu0297z/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[9424:0x2744cc0]   139457 ms: Mark-sweep 1378.7 (1426.7) -> 1378.7 (1427.2) MB, 3093.7 / 0.0 ms  (average mu = 0.107, current mu = 0.000) allocation failure GC in old space requested
[9424:0x2744cc0]   142680 ms: Mark-sweep 1379.6 (1427.2) -> 1379.5 (1427.7) MB, 3219.5 / 0.0 ms  (average mu = 0.053, current mu = 0.001) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x26015b95be1d]
Security context: 0x04753a59e6e9 <JSObject>
    1: newScalar [0x2715bdbe42e1] [/node_modules/yaml-ast-parser/dist/src/yamlAST.js:~38] [pc=0x26015c04ded6](this=0x2ff0aeeff4a1 <Object map = 0x1eb258221b51>,v=0x2f03758826f1 <undefined>)
    2: arguments adaptor frame: 0->1
    3: readDoubleQuotedScalar(aka readDoubleQuotedScalar) [0x2715bdbe4949] [/node_modules/yaml-ast-parser/dist/src/loader.js:~530] [p...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x26015b95be1d

[anton-evseev]

Need to target 2019-07-01

[anton-evseev]

LGTM except a few nitpicks about descriptions

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5755

[anton-evseev]

@pilor @KrisBash please review this from ARM's side

[pilor]

The "properties" suffix seems unnecessary. "publicIPAddress" and "subnet" aren't using the suffix and its not typical across other resources.

[bowen0106]

Hi Pilor,
So regarding to your question, the property's name is 'privateLinkConnectionProperties' from the Networking RP server side, it's been public and we cannot change it. So I think we should keep the name as is. Thank you.

[pilor]

Public how? If this is already public then what am I reviewing here?

[bowen0106]

Hi Pilor,
My meaning is the NRP side has already released the REST api for this part. And the property is already there for a while which named 'privateLinkConnectionProperties'. So I don't think there is a reason to change the name.
I attached one of example of return json string for network interface for your reference:

{
  "name": "PEVnet1.nic.b9414b57-e682-40b9-ada8-312e40e2c88b",
  "id":
"/subscriptions/15aa9ba4-9bd3-499f-ba12-9a5736d0cd68/resourceGroups/PrivateEndpointRunnerTestToStaticRGRGWestcentralusSLBV2Dev/providers/Microsoft.Network/networkInterfaces/PEVnet1.nic.b9414b57-e682-40b9-ada8-312e40e2c88b",
  "etag": "W/\"b2dd33b7-92d1-460a-baa6-d5f55960e4aa\"",
  "properties": {
    "provisioningState": "Succeeded",
    "resourceGuid": "7e3a996f-09a0-41e2-9f6d-0841110f7823",
    "ipConfigurations": [
      {
        "name": "sqlServer-sqlServer.privateEndpoint",
        "id":
"/subscriptions/15aa9ba4-9bd3-499f-ba12-9a5736d0cd68/resourceGroups/PrivateEndpointRunnerTestToStaticRGRGWestcentralusSLBV2Dev/providers/Microsoft.Network/networkInterfaces/PEVnet1.nic.b9414b57-e682-40b9-ada8-312e40e2c88b/ipC
onfigurations/sqlServer-sqlServer.privateEndpoint",
        "etag": "W/\"b2dd33b7-92d1-460a-baa6-d5f55960e4aa\"",
        "type": "Microsoft.Network/networkInterfaces/ipConfigurations",
        "properties": {
          "provisioningState": "Succeeded",
          "privateIPAddress": "10.0.0.4",
          "privateIPAllocationMethod": "Dynamic",
          "subnet": {
            "id":
"/subscriptions/15aa9ba4-9bd3-499f-ba12-9a5736d0cd68/resourceGroups/PrivateEndpointRunnerTestToStaticRGRGWestcentralusSLBV2Dev/providers/Microsoft.Network/virtualNetworks/vNet1-nr3kriysgtcxk/subnets/subnet1"
          },
          "primary": true,
          "privateIPAddressVersion": "IPv4",
          "privateLinkConnectionProperties": {
            "groupId": "sqlServer",
            "requiredMemberName": "sqlServer",
            "fqdns": [
              "sql-for-test-4nuppzq4x37iq.database.windows.net"
            ]
          }
        }
      }
    ],
    "dnsSettings": {
      "dnsServers": [],
      "appliedDnsServers": [],
      "internalDomainNameSuffix": "vji40krafe4ujcvrvvzyhdrltc.yx.internal.cloudapp.net"
    },
    "macAddress": "",
    "enableAcceleratedNetworking": false,
    "enableIPForwarding": false,
    "hostedWorkloads": [],
    "tapConfigurations": [],
    "privateEndpoint": {
      "id": "/subscriptions/15aa9ba4-9bd3-499f-ba12-9a5736d0cd68/resourceGroups/PrivateEndpointRunnerTestToStaticRGRGWestcentralusSLBV2Dev/providers/Microsoft.Network/privateEndpoints/PEVnet1"
    }
  },
  "type": "Microsoft.Network/networkInterfaces"
}

[anton-evseev]

Since @pilor is OOF, @KrisBash could you please review this PR? Chris' comments were addressed

[KrisBash]

signing off for ARM