Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed required properties in TrafficAnalyticsProperties: networkWatce… #7080

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Fixed required properties in TrafficAnalyticsProperties: networkWatce… #7080

merged 1 commit into from
Sep 5, 2019

Conversation

irrogozh
Copy link
Member

…hr.json

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpsrqlwji1/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpsrqlwji1/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4392)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[15681:0x3339cc0]   143395 ms: Mark-sweep 1380.3 (1426.6) -> 1380.2 (1427.1) MB, 2973.6 / 0.0 ms  (average mu = 0.188, current mu = 0.132) allocation failure GC in old space requested
[15681:0x3339cc0]   145961 ms: Mark-sweep 1381.0 (1427.1) -> 1380.9 (1427.6) MB, 2562.6 / 0.0 ms  (average mu = 0.106, current mu = 0.001) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x1168d40dbe1d]
Security context: 0x070f9329e6e9 <JSObject>
    1: storeMappingPair(aka storeMappingPair) [0x1c9d914d9641] [/node_modules/yaml-ast-parser/dist/src/loader.js:~270] [pc=0x1168d46f735a](this=0x298d47d026f1 <undefined>,state=0x00b362902201 <State map = 0x20f797b327c9>,_result=0x3f6d42958189 <Object map = 0x309fe4068d79>,keyTag=0x298d47d022b1 <null>,keyNode=0x2b8189e7fed1 <Object map = 0x309fe40696c1>,valu...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x1168d40dbe1d

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 30, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@sergey-shandar sergey-shandar added potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 30, 2019
@anton-evseev
Copy link
Contributor

@sergey-shandar I'm not sure if that's a breaking change. This is the diff for Net SDK based on this PR: anton-evseev/azure-sdk-for-net@b194174
With other SDKs it should be fine too, since they are multi-API

@anton-evseev
Copy link
Contributor

@anthony-c-martin could you please review this PR from ARM's side?

@anton-evseev
Copy link
Contributor

@KrisBash could you please review this from ARM team's side?

Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 4, 2019
@anton-evseev
Copy link
Contributor

Rebased PR to include fixes for CI that were merged into network-august-branch recently
@sergey-shandar, can we remove potential-sdk-breaking-change since ARM team approved this PR? It doesn't look like this PR will cause any breaking changes

@sergey-shandar sergey-shandar merged commit bf9991c into Azure:network-august-release Sep 5, 2019
anton-evseev pushed a commit to anton-evseev/azure-rest-api-specs that referenced this pull request Sep 13, 2019
sarangan12 pushed a commit that referenced this pull request Sep 13, 2019
* Adds base for updating Microsoft.Network from version stable/2019-06-01 to version 2019-07-01

* Updates readme

* Updates API version in new specs and examples

* Update API version in VMSS' specs (#7008)

* Add reference to existing base definition & fix errors in descriptions of Network's provisioningState property (#7026)

* Improve Network's descriptions (#6974)

* New Skus and Generations for VirtualNetworkVpnGateways (#7089)

* New Skus and generations for VirtualNetwork VpnGateways

* Minor Typo fix

* update [email protected] (#7054)

* Lock typescript version to fix compile error (#7068)

* Fix description for vpnGatewayGeneration.

* Add VirtualRouter top level resource Identity under Microsoft.Network/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink (#7005)

* Fixed required properties in TrafficAnalyticsProperties: networkWatcehr.json (#7080)

* Added traffic selector policy definition to virtualNetworkGateway.json (#7066)

* Support for changes in ConnectionMonitor API (#7075)

* Updating Network Config Diagnostics API desc (#7117)

* Added priority field in the request routing rule (#7131)

* Added priority field in the request routing rule

* Added min and max

* Minor

* Added new owner to Azure Networking (#7145)

added number213 to Az NW

* Add Mssql value to Application Rule Type enum (#7169)

* Add privateLinkConnectionProperties to network interface. (#7189)

* Add privateLinkConnectionProperties to network interface on 2019-07-01.

* Small changes for descriptions in the property.

* make the new property to be read-only.

* Brooklyn Gateway Packet Capture feature (#7151)

* PacketCaptureOperationforVPNGateways

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionStopPacketCapture.json

* Update VirtualNetworkGatewayStopPacketCapture.json

* Update VirtualNetworkGatewayStopPacketCapture.json

* Update VirtualNetworkGatewayConnectionStopPacketCapture.json

* Update VirtualNetworkGatewayConnectionStartPacketCapture.json

* Update VirtualNetworkGatewayStartPacketCapture.json

* Update virtualNetworkGateway.json

* fixing examples

* fixing virtualNetworkGateway.json

* fixing params

* fixing path params

* response body

* example errors

* example errors

* example errors

* filterdata

* Update virtualNetworkGateway.json

* fixing Comments

* Fixing ARM Comments

* Remove duplicate definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants