Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add privateLinkConnectionProperties to network interface. #7189

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Add privateLinkConnectionProperties to network interface. #7189

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb19311
Add privateLinkConnectionProperties to network interface on 2019-07-01.
bowen0106 Sep 11, 2019
56cdcf4
Small changes for descriptions in the property.
bowen0106 Sep 11, 2019
b512e57
make the new property to be read-only.
bowen0106 Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions ...cation/network/resource-manager/Microsoft.Network/stable/2019-07-01/networkInterface.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,10 +897,34 @@
"provisioningState": {
"$ref": "./network.json#/definitions/ProvisioningState",
"description": "The provisioning state of the network interface IP configuration."
},
"privateLinkConnectionProperties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "properties" suffix seems unnecessary. "publicIPAddress" and "subnet" aren't using the suffix and its not typical across other resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pilor,
So regarding to your question, the property's name is 'privateLinkConnectionProperties' from the Networking RP server side, it's been public and we cannot change it. So I think we should keep the name as is. Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public how? If this is already public then what am I reviewing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pilor,
My meaning is the NRP side has already released the REST api for this part. And the property is already there for a while which named 'privateLinkConnectionProperties'. So I don't think there is a reason to change the name.
I attached one of example of return json string for network interface for your reference:

{
  "name": "PEVnet1.nic.b9414b57-e682-40b9-ada8-312e40e2c88b",
  "id":
"/subscriptions/15aa9ba4-9bd3-499f-ba12-9a5736d0cd68/resourceGroups/PrivateEndpointRunnerTestToStaticRGRGWestcentralusSLBV2Dev/providers/Microsoft.Network/networkInterfaces/PEVnet1.nic.b9414b57-e682-40b9-ada8-312e40e2c88b",
  "etag": "W/\"b2dd33b7-92d1-460a-baa6-d5f55960e4aa\"",
  "properties": {
    "provisioningState": "Succeeded",
    "resourceGuid": "7e3a996f-09a0-41e2-9f6d-0841110f7823",
    "ipConfigurations": [
      {
        "name": "sqlServer-sqlServer.privateEndpoint",
        "id":
"/subscriptions/15aa9ba4-9bd3-499f-ba12-9a5736d0cd68/resourceGroups/PrivateEndpointRunnerTestToStaticRGRGWestcentralusSLBV2Dev/providers/Microsoft.Network/networkInterfaces/PEVnet1.nic.b9414b57-e682-40b9-ada8-312e40e2c88b/ipC
onfigurations/sqlServer-sqlServer.privateEndpoint",
        "etag": "W/\"b2dd33b7-92d1-460a-baa6-d5f55960e4aa\"",
        "type": "Microsoft.Network/networkInterfaces/ipConfigurations",
        "properties": {
          "provisioningState": "Succeeded",
          "privateIPAddress": "10.0.0.4",
          "privateIPAllocationMethod": "Dynamic",
          "subnet": {
            "id":
"/subscriptions/15aa9ba4-9bd3-499f-ba12-9a5736d0cd68/resourceGroups/PrivateEndpointRunnerTestToStaticRGRGWestcentralusSLBV2Dev/providers/Microsoft.Network/virtualNetworks/vNet1-nr3kriysgtcxk/subnets/subnet1"
          },
          "primary": true,
          "privateIPAddressVersion": "IPv4",
          "privateLinkConnectionProperties": {
            "groupId": "sqlServer",
            "requiredMemberName": "sqlServer",
            "fqdns": [
              "sql-for-test-4nuppzq4x37iq.database.windows.net"
            ]
          }
        }
      }
    ],
    "dnsSettings": {
      "dnsServers": [],
      "appliedDnsServers": [],
      "internalDomainNameSuffix": "vji40krafe4ujcvrvvzyhdrltc.yx.internal.cloudapp.net"
    },
    "macAddress": "",
    "enableAcceleratedNetworking": false,
    "enableIPForwarding": false,
    "hostedWorkloads": [],
    "tapConfigurations": [],
    "privateEndpoint": {
      "id": "/subscriptions/15aa9ba4-9bd3-499f-ba12-9a5736d0cd68/resourceGroups/PrivateEndpointRunnerTestToStaticRGRGWestcentralusSLBV2Dev/providers/Microsoft.Network/privateEndpoints/PEVnet1"
    }
  },
  "type": "Microsoft.Network/networkInterfaces"
}

"$ref": "#/definitions/NetworkInterfaceIPConfigurationPrivateLinkConnectionProperties",
"description": "PrivateLinkConnection properties for the network interface."
}
},
"description": "Properties of IP configuration."
},
"NetworkInterfaceIPConfigurationPrivateLinkConnectionProperties": {
pilor marked this conversation as resolved.
Show resolved Hide resolved
"properties": {
"groupId": {
"type": "string",
"description": "The group ID for current private link connection."
},
"requiredMemberName": {
"type": "string",
"description": "The required member name for current private link connection."
},
"fqdns": {
"type": "array",
"items": {
"type": "string"
},
"description": "List of FQDNs for current private link connection."
}
},
"description": "PrivateLinkConnection properties for the network interface."
},
"NetworkInterfaceIPConfiguration": {
"properties": {
"properties": {
Expand Down