Modify some PE/PLS properties for update #6894

bowen0106 · 2019-08-07T20:44:20Z

Description

Updated some properties in PrivateLinkService and PrivateEndpoint

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-08-07T20:46:39Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpgaaoq33w/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpgaaoq33w/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4390)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[3330:0x3f7acc0]    73596 ms: Mark-sweep 1372.8 (1425.6) -> 1372.7 (1426.1) MB, 1389.0 / 0.0 ms  (average mu = 0.118, current mu = 0.002) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x332ddc4dbe1d]
Security context: 0x1ce4df11e6e9 <JSObject>
    1: readPlainScalar(aka readPlainScalar) [0x30a75e122c89] [/node_modules/yaml-ast-parser/dist/src/loader.js:~398] [pc=0x332ddca45970](this=0x0b835ff026f1 <undefined>,state=0x37c7a9482201 <State map = 0x3c0f8f0fff01>,nodeIndent=0,withinFlowCollection=0x0b835ff028c9 <true>)
    2: composeNode(aka composeNode) [0x30a75e122149] [/node_modules/yaml-ast-parser/...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x332ddc4dbe1d

azuresdkci · 2019-08-07T21:04:51Z

Can one of the admins verify this patch?

AutorestCI · 2019-08-07T21:14:44Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5512

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/privateEndpoint.json

...ication/network/resource-manager/Microsoft.Network/stable/2019-06-01/privateLinkService.json

anton-evseev

LGTM

anton-evseev · 2019-08-12T17:07:03Z

@zikalino @Azure/arm-api-review-board could you please review this PR?

anton-evseev · 2019-08-13T14:37:27Z

@ryansbenson could you please review this PR?

openapi-sdkautomation · 2019-08-14T00:48:01Z

In Testing, Please Ignore

[Logs] (Generated from 20c37f0, Iteration 1)

Python: test-repo-billy/azure-sdk-for-python [Logs]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs]

Package generation in progress.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

No packages generated.

anton-evseev · 2019-08-14T00:51:09Z

Rebased and retargeted to master
@bowen0106 please check that I didn't miss anything

ravbhatnagar · 2019-08-14T02:02:01Z

...ication/network/resource-manager/Microsoft.Network/stable/2019-06-01/privateLinkService.json

@@ -740,13 +754,13 @@
          "$ref": "./virtualNetwork.json#/definitions/Subnet",
          "description": "The reference of the subnet resource."
        },
-        "publicIPAddress": {


removing an existing property (stable/GA api version) is considered as a breaking change. @bowen0106 - why do you need to remove this property. Anton Evseev tells me that this API is behind a feature flag and all the customers using it have been notified of this change. Can you please confirm?

Yes. It’s confirmed. This feature currently is testing with limited access guarded by feature flag from Subscription Level.

Currently there is no external customer using this feature.

ravbhatnagar · 2019-08-14T02:20:10Z

Signing off from ARM side. This feature is guarded by AFEC and no external customer should be using it. Its still a breaking change, but impact should be limited.

bowen0106 requested a review from MikhailTryakhov as a code owner August 7, 2019 20:44

azuresdkci assigned zikalino Aug 7, 2019

azuresdkci requested a review from zikalino August 7, 2019 20:45

anton-evseev suggested changes Aug 8, 2019

View reviewed changes

anton-evseev approved these changes Aug 8, 2019

View reviewed changes

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 12, 2019

anton-evseev changed the base branch from network-july-release to master August 14, 2019 00:47

Update PE/PLS

36ba645

anton-evseev force-pushed the bowen/network-july branch from 20c37f0 to 36ba645 Compare August 14, 2019 00:50

ravbhatnagar reviewed Aug 14, 2019

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 14, 2019

AutorestCI mentioned this pull request Aug 14, 2019

[AutoPR network/resource-manager] Modify some PE/PLS properties for update Azure/azure-sdk-for-go#5511

Merged

sergey-shandar approved these changes Aug 14, 2019

View reviewed changes

sergey-shandar merged commit bb084c2 into Azure:master Aug 14, 2019

anton-evseev mentioned this pull request Aug 14, 2019

Update 2019-04-01 API as changes from 2019-06-01. #6959

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify some PE/PLS properties for update #6894

Modify some PE/PLS properties for update #6894

bowen0106 commented Aug 7, 2019 •

edited

Loading

AutorestCI commented Aug 7, 2019 •

edited

Loading

azuresdkci commented Aug 7, 2019

AutorestCI commented Aug 7, 2019 •

edited

Loading

anton-evseev left a comment

anton-evseev commented Aug 12, 2019

anton-evseev commented Aug 13, 2019

openapi-sdkautomation bot commented Aug 14, 2019 •

edited

Loading

anton-evseev commented Aug 14, 2019

ravbhatnagar Aug 14, 2019

bowen0106 Aug 14, 2019

bowen0106 Aug 14, 2019

ravbhatnagar commented Aug 14, 2019

Modify some PE/PLS properties for update #6894

Modify some PE/PLS properties for update #6894

Conversation

bowen0106 commented Aug 7, 2019 • edited Loading

Description

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Aug 7, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Aug 7, 2019

AutorestCI commented Aug 7, 2019 • edited Loading

Automation for azure-sdk-for-go

anton-evseev left a comment

Choose a reason for hiding this comment

anton-evseev commented Aug 12, 2019

anton-evseev commented Aug 13, 2019

openapi-sdkautomation bot commented Aug 14, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 20c37f0, Iteration 1)

anton-evseev commented Aug 14, 2019

ravbhatnagar Aug 14, 2019

Choose a reason for hiding this comment

bowen0106 Aug 14, 2019

Choose a reason for hiding this comment

bowen0106 Aug 14, 2019

Choose a reason for hiding this comment

ravbhatnagar commented Aug 14, 2019

bowen0106 commented Aug 7, 2019 •

edited

Loading

AutorestCI commented Aug 7, 2019 •

edited

Loading

AutorestCI commented Aug 7, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 14, 2019 •

edited

Loading