Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 2019-04-01 API as changes from 2019-06-01. #6959

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Update 2019-04-01 API as changes from 2019-06-01. #6959

merged 2 commits into from
Aug 29, 2019

Conversation

bowen0106
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 92006e4, Iteration 4)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Failed Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@azuresdkci azuresdkci requested a review from tjprescott August 14, 2019 18:09
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 14, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpcwedc1dz/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpcwedc1dz/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4390)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[29638:0x4018cc0]    67142 ms: Mark-sweep 1379.6 (1425.1) -> 1379.5 (1425.6) MB, 1249.8 / 0.0 ms  (average mu = 0.130, current mu = 0.015) allocation failure scavenge might not succeed
[29638:0x4018cc0]    68779 ms: Mark-sweep 1380.2 (1425.6) -> 1380.1 (1426.6) MB, 1634.2 / 0.0 ms  (average mu = 0.060, current mu = 0.001) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x2a8ce755be1d]
Security context: 0x0ea553c1e6e9 <JSObject>
    1: storeMappingPair(aka storeMappingPair) [0x3328f5c466a9] [/node_modules/yaml-ast-parser/dist/src/loader.js:~270] [pc=0x2a8ce7ad841a](this=0x25168d7826f1 <undefined>,state=0x044de9b02201 <State map = 0x1ad5358e7149>,_result=0x114124acf1a1 <Object map = 0xbaf2f666e89>,keyTag=0x25168d7822b1 <null>,keyNode=0x0559bae7fe39 <Object map = 0xbaf2f6677d1>,valueN...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x2a8ce755be1d

@anton-evseev
Copy link
Contributor

Copied changes from #6894 to older API version
ARM has already signed these changes off

@AutorestCI AutorestCI mentioned this pull request Aug 14, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Aug 14, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5632

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 15, 2019
Closed
@anton-evseev
Copy link
Contributor

CI failed due to SDK Java getting timed out after 2 hours
@tjprescott could you please take a look at this PR? This is a copy of changes from another API version, ARM has already signed off them (#6894)

@PhoenixHe-NV PhoenixHe-NV mentioned this pull request Aug 16, 2019
Closed
@tjprescott
Copy link
Member

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@tjprescott
Copy link
Member

Restarting CI. I can't merge PRs unless all required checks pass.

@anton-evseev anton-evseev mentioned this pull request Aug 20, 2019
Closed
5 tasks
@tjprescott
Copy link
Member

@sergey-shandar this keeps failing on the Java step, preventing me from merging.

@anton-evseev
Copy link
Contributor

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@anton-evseev
Copy link
Contributor

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@anton-evseev
Copy link
Contributor

Ping @sergey-shandar @zikalino @lirenhe

@yungezz yungezz closed this Aug 28, 2019
@yungezz yungezz reopened this Aug 28, 2019
@yungezz
Copy link
Member

yungezz commented Aug 28, 2019

reopen PR to trigger CI. prevoius CI failed due to SDK java 2 hours timeout

@AutorestCI AutorestCI mentioned this pull request Aug 28, 2019
Merged
@anton-evseev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@anton-evseev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@anton-evseev
Copy link
Contributor

All failed jobs failed with the same error. Don't think it's related to changes in PR since I see that other PRs have the same error

scripts/multiapi.ts(95,40): error TS2345: Argument of type 'Set<string>' is not assignable to parameter of type 'Iterable<any>'.
  Types of property '[Symbol.iterator]' are incompatible.
    Type '() => IterableIterator<string>' is not assignable to type '() => Iterator<any>'.
      Type 'IterableIterator<string>' is not assignable to type 'Iterator<any>'.
        Types of property 'next' are incompatible.
          Type '(...args: [] | [undefined]) => IteratorResult<string, any>' is not assignable to type '() => IteratorResult<any>'.
            Type 'IteratorResult<string, any>' is not assignable to type 'IteratorResult<any>'.
              Type 'IteratorYieldResult<string>' is not assignable to type 'IteratorResult<any>'.
                Types of property 'done' are incompatible.
                  Type 'false | undefined' is not assignable to type 'boolean'.
                    Type 'undefined' is not assignable to type 'boolean'.
npm ERR! Test failed.  See above for more details.

@yungezz yungezz closed this Aug 29, 2019
@yungezz yungezz reopened this Aug 29, 2019
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 29, 2019
Merged
@yungezz yungezz merged commit 59db1e6 into Azure:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-evseev anton-evseev anton-evseev approved these changes

@tjprescott tjprescott tjprescott approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@tjprescott tjprescott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bowen0106 @azuresdkci @AutorestCI @anton-evseev @tjprescott @yungezz