Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify some PE/PLS properties for update #6894

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Modify some PE/PLS properties for update #6894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions ...ication/network/resource-manager/Microsoft.Network/stable/2019-06-01/privateEndpoint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@
},
"etag": {
"type": "string",
"description": "Gets a unique read-only string that changes whenever the resource is updated."
"description": "A unique read-only string that changes whenever the resource is updated."
}
},
"allOf": [
Expand All @@ -421,9 +421,8 @@
"description": "Gets an array of references to the network interfaces created for this private endpoint."
},
"provisioningState": {
"readOnly": true,
"type": "string",
"description": "The provisioning state of the private endpoint. Possible values are: 'Updating', 'Deleting', and 'Failed'."
"$ref": "./network.json#/definitions/ProvisioningState",
"description": "The provisioning state of the private endpoint."
},
"privateLinkServiceConnections": {
"type": "array",
Expand Down Expand Up @@ -452,6 +451,16 @@
"name": {
"type": "string",
"description": "The name of the resource that is unique within a resource group. This name can be used to access the resource."
},
"type": {
"readOnly": true,
"type": "string",
"description": "The resource type."
},
"etag": {
"readOnly": true,
"type": "string",
"description": "A unique read-only string that changes whenever the resource is updated."
}
},
"allOf": [
Expand All @@ -463,6 +472,10 @@
},
"PrivateLinkServiceConnectionProperties": {
"properties": {
"provisioningState": {
bowen0106 marked this conversation as resolved.
Show resolved Hide resolved
"$ref": "./network.json#/definitions/ProvisioningState",
"description": "The provisioning state of the private link service connection."
},
"privateLinkServiceId": {
"type": "string",
"description": "The resource id of private link service."
Expand Down
46 changes: 37 additions & 9 deletions ...tion/network/resource-manager/Microsoft.Network/stable/2019-06-01/privateLinkService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@
},
"etag": {
"type": "string",
"description": "Gets a unique read-only string that changes whenever the resource is updated."
"description": "A unique read-only string that changes whenever the resource is updated."
}
},
"allOf": [
Expand Down Expand Up @@ -658,9 +658,8 @@
"description": "Gets an array of references to the network interfaces created for this private link service."
},
"provisioningState": {
"readOnly": true,
"type": "string",
"description": "The provisioning state of the private link service. Possible values are: 'Updating', 'Succeeded', and 'Failed'."
"$ref": "./network.json#/definitions/ProvisioningState",
"description": "The provisioning state of the private link service."
},
"privateEndpointConnections": {
"type": "array",
Expand Down Expand Up @@ -722,8 +721,23 @@
"name": {
"type": "string",
"description": "The name of private link service ip configuration."
},
"etag": {
"readOnly": true,
"type": "string",
"description": "A unique read-only string that changes whenever the resource is updated."
},
"type": {
"readOnly": true,
"type": "string",
"description": "The resource type."
}
},
"allOf": [
{
"$ref": "./network.json#/definitions/SubResource"
}
],
"description": "The private link service ip configuration."
},
"PrivateLinkServiceIpConfigurationProperties": {
Expand All @@ -740,13 +754,13 @@
"$ref": "./virtualNetwork.json#/definitions/Subnet",
"description": "The reference of the subnet resource."
},
"publicIPAddress": {
bowen0106 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing an existing property (stable/GA api version) is considered as a breaking change. @bowen0106 - why do you need to remove this property. Anton Evseev tells me that this API is behind a feature flag and all the customers using it have been notified of this change. Can you please confirm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It’s confirmed. This feature currently is testing with limited access guarded by feature flag from Subscription Level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is no external customer using this feature.

"$ref": "./publicIpAddress.json#/definitions/PublicIPAddress",
"description": "The reference of the public IP resource."
"primary": {
"type": "boolean",
"description": "Whether the ip configuration is primary or not."
},
"provisioningState": {
"type": "string",
"description": "Gets the provisioning state of the public IP resource. Possible values are: 'Updating', 'Deleting', and 'Failed'."
"$ref": "./network.json#/definitions/ProvisioningState",
"description": "The provisioning state of the private link service ip configuration."
},
"privateIPAddressVersion": {
"$ref": "./network.json#/definitions/IPVersion",
Expand All @@ -765,6 +779,16 @@
"name": {
"type": "string",
"description": "The name of the resource that is unique within a resource group. This name can be used to access the resource."
},
"type": {
"readOnly": true,
"type": "string",
"description": "The resource type."
},
"etag": {
"readOnly": true,
"type": "string",
"description": "A unique read-only string that changes whenever the resource is updated."
}
},
"allOf": [
Expand All @@ -783,6 +807,10 @@
"privateLinkServiceConnectionState": {
"$ref": "#/definitions/PrivateLinkServiceConnectionState",
"description": "A collection of information about the state of the connection between service consumer and provider."
},
"provisioningState": {
bowen0106 marked this conversation as resolved.
Show resolved Hide resolved
"$ref": "./network.json#/definitions/ProvisioningState",
"description": "The provisioning state of the private endpoint connection."
}
},
"description": "Properties of the PrivateEndpointConnectProperties."
Expand Down