Improve Network's examples

[anton-evseev]

• Responses for LoadBalancer with Basic SKU don't have outboundRules property so removed it from examples
• Added missing read-only properties like type and etag to LoadBalancer's examples & specs
• Removed read-only fields from VPN Gateway's example for PUT

---

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[AutorestCI]

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpt8w7tzlu/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpt8w7tzlu/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4387)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[23097:0x3f14cc0]    88015 ms: Mark-sweep 1381.7 (1425.3) -> 1381.4 (1425.8) MB, 3403.1 / 0.0 ms  (average mu = 0.106, current mu = 0.005) allocation failure scavenge might not succeed
[23097:0x3f14cc0]    90392 ms: Mark-sweep 1382.2 (1425.8) -> 1381.9 (1426.3) MB, 2374.2 / 0.0 ms  (average mu = 0.059, current mu = 0.001) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x0ee4ad99e6e9 <JSObject>
    0: builtin exit frame: stringify(this=0x0ee4ad991a21 <Object map = 0x2b878db042a9>,0x1bb3380826f1 <undefined>,0x1bb3380826f1 <undefined>,0x11775cbce8c9 <JSArray[7]>,0x0ee4ad991a21 <Object map = 0x2b878db042a9>)

    1: arguments adaptor frame: 1->3
    2: IdentitySourceMapping [0x3551e19754d1] [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-cor...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xe9f655  [node]
11: 0xea6eca v8::internal::Factory::NewRawOneByteString(int, v8::internal::PretenureFlag) [node]
12: 0x11d6b25 v8::internal::IncrementalStringBuilder::Extend() [node]
13: 0xf9b348 v8::internal::JsonStringifier::SerializeString(v8::internal::Handle<v8::internal::String>) [node]
14: 0xf9f7cf v8::internal::JsonStringifier::Result v8::internal::JsonStringifier::Serialize_<false>(v8::internal::Handle<v8::internal::Object>, bool, v8::internal::Handle<v8::internal::Object>) [node]
15: 0xfa0626 v8::internal::JsonStringifier::Result v8::internal::JsonStringifier::Serialize_<false>(v8::internal::Handle<v8::internal::Object>, bool, v8::internal::Handle<v8::internal::Object>) [node]
16: 0xfa1719 v8::internal::JsonStringifier::Stringify(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>) [node]
17: 0xba9121 v8::internal::Builtin_JsonStringify(int, v8::internal::Object**, v8::internal::Isolate*) [node]
18: 0x205e8da5bf7d

[AutorestCI]

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

[anton-evseev]

Please ignore error in NetworkValidation, it's not related to this PR, it failed due to NuGet not being able to resolve dependencies. I've already reported this error to SDK & Azure PowerShell teams.

D:\a\1\s\Out\azure-powershell\src\Network\Network\Network.csproj : error NU1605: Detected package downgrade: Microsoft.Rest.ClientRuntime from 2.3.20 to 2.3.19. Reference the package directly from the project to select a different version.  [D:\a\1\s\Out\azure-powershell\src\Network\Network.sln]

[tjprescott]

@number213 what about your JS SDK issue?

[anton-evseev]

@tjprescott doesn't look like error is related to changes in PR.

INFO:swaggertosdk.autorest_tools:  Error: Unable to resolve package 'foo@@microsoft.azure/autorest.typescript'. 
ERROR:swaggertosdk.autorest_tools:Command '['/usr/local/bin/autorest', '/git-restapi/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmph_u9ld91/azure-sdk-for-js', '[email protected]/autorest.typescript']' returned non-zero exit status 1.

I think this is the step that was removed by @sergey-shandar (#6391)

[tjprescott]

/azurepipelines run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[tjprescott]

@number213 it is still failing. @sergey-shandar it is okay to merge this with the JS SDK failing?

[kpajdzik]

@number213 it is still failing. @sergey-shandar it is okay to merge this with the JS SDK failing?

Yes, go ahead. Are spell checker failures unrelated?

[anton-evseev]

@kpajdzik yes, failures are because spellchecker's config with exceptions in this branch is out of sync with master, this PR doesn't introduce any new errors