Skip to content

Commit

Permalink
Improve Network's examples (#6493)
Browse files Browse the repository at this point in the history
* Removed read-only props from VPNGW example

* Fixed LoadBalancer examples:
* "outboundRules" array isn't returned for "Basic" SKU load balancer
* added example for external LB with outboundRules
* added missing read-only properties

* Replace "regionName" in examples with real location

* Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer
  • Loading branch information
anton-evseev authored and tjprescott committed Jul 9, 2019
1 parent bf45d1d commit d3acd59
Show file tree
Hide file tree
Showing 23 changed files with 642 additions and 40 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"parameters": {
"api-version": "2019-06-01",
"location": "regionName",
"location": "westcentralus",
"subscriptionId": "subId",
"resourceGroupName": "rg1"
},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"parameters": {
"api-version": "2019-06-01",
"location": "regionName",
"location": "westcentralus",
"subscriptionId": "subId"
},
"responses": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"body": {
"name": "backend",
"id": "/subscriptions/subid/resourceGroups/testrg/providers/Microsoft.Network/loadBalancers/lb/backendAddressPools/backend",
"etag": "W/\\\"00000000-0000-0000-0000-000000000000\\\"",
"etag": "W/\"00000000-0000-0000-0000-000000000000\"",
"type": "Microsoft.Network/loadBalancers/backendAddressPools",
"properties": {
"provisioningState": "Succeeded",
"backendIPConfigurations": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
{
"name": "backend",
"id": "/subscriptions/subid/resourceGroups/testrg/providers/Microsoft.Network/loadBalancers/lb/backendAddressPools/backend",
"etag": "W/\\\"00000000-0000-0000-0000-000000000000\\\"",
"etag": "W/\"00000000-0000-0000-0000-000000000000\"",
"type": "Microsoft.Network/loadBalancers/backendAddressPools",
"properties": {
"provisioningState": "Succeeded",
"backendIPConfigurations": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@
}
}
],
"inboundNatPools": [],
"outboundRules": []
"inboundNatPools": []
}
}
},
Expand All @@ -85,16 +84,20 @@
"name": "lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb",
"type": "Microsoft.Network/loadBalancers",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"location": "eastus",
"sku": {
"name": "Basic"
},
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-00000000",
"frontendIPConfigurations": [
{
"name": "fe-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb",
"type": "Microsoft.Network/loadBalancers/frontendIPConfigurations",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"privateIPAddress": "10.0.1.4",
Expand All @@ -119,6 +122,8 @@
{
"name": "be-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/backendAddressPools/be-lb",
"type": "Microsoft.Network/loadBalancers/backendAddressPools",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"loadBalancingRules": [
Expand All @@ -133,6 +138,8 @@
{
"name": "rulelb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/loadBalancingRules/rulelb",
"type": "Microsoft.Network/loadBalancers/loadBalancingRules",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"frontendIPConfiguration": {
Expand All @@ -159,6 +166,8 @@
{
"name": "probe-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/probes/probe-lb",
"type": "Microsoft.Network/loadBalancers/probes",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"protocol": "Http",
Expand All @@ -178,6 +187,8 @@
{
"name": "in-nat-rule",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/inboundNatRules/in-nat-rule",
"type": "Microsoft.Network/loadBalancers/inboundNatRules",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"frontendIPConfiguration": {
Expand All @@ -192,7 +203,6 @@
}
}
],
"outboundRules": [],
"inboundNatPools": []
}
}
Expand All @@ -202,16 +212,20 @@
"name": "lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb",
"type": "Microsoft.Network/loadBalancers",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"location": "eastus",
"sku": {
"name": "Basic"
},
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-00000000",
"frontendIPConfigurations": [
{
"name": "fe-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb",
"type": "Microsoft.Network/loadBalancers/frontendIPConfigurations",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"privateIPAddress": "10.0.1.4",
Expand All @@ -236,6 +250,8 @@
{
"name": "be-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/backendAddressPools/be-lb",
"type": "Microsoft.Network/loadBalancers/backendAddressPools",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"loadBalancingRules": [
Expand All @@ -250,6 +266,8 @@
{
"name": "rulelb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/loadBalancingRules/rulelb",
"type": "Microsoft.Network/loadBalancers/loadBalancingRules",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"frontendIPConfiguration": {
Expand All @@ -276,6 +294,8 @@
{
"name": "probe-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/probes/probe-lb",
"type": "Microsoft.Network/loadBalancers/probes",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"protocol": "Http",
Expand All @@ -295,6 +315,8 @@
{
"name": "in-nat-rule",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/inboundNatRules/in-nat-rule",
"type": "Microsoft.Network/loadBalancers/inboundNatRules",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"frontendIPConfiguration": {
Expand All @@ -309,7 +331,6 @@
}
}
],
"outboundRules": [],
"inboundNatPools": []
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,20 @@
"name": "lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb",
"type": "Microsoft.Network/loadBalancers",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"location": "eastus",
"sku": {
"name": "Standard"
},
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-00000000",
"frontendIPConfigurations": [
{
"name": "fe-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb",
"type": "Microsoft.Network/loadBalancers/frontendIPConfigurations",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"privateIPAddress": "10.0.1.4",
Expand All @@ -120,6 +124,8 @@
{
"name": "be-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/backendAddressPools/be-lb",
"type": "Microsoft.Network/loadBalancers/backendAddressPools",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"loadBalancingRules": [
Expand All @@ -134,6 +140,8 @@
{
"name": "rulelb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/loadBalancingRules/rulelb",
"type": "Microsoft.Network/loadBalancers/loadBalancingRules",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"frontendIPConfiguration": {
Expand All @@ -159,6 +167,8 @@
{
"name": "probe-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/probes/probe-lb",
"type": "Microsoft.Network/loadBalancers/probes",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"protocol": "Http",
Expand All @@ -178,6 +188,8 @@
{
"name": "in-nat-rule",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/inboundNatRules/in-nat-rule",
"type": "Microsoft.Network/loadBalancers/inboundNatRules",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"frontendIPConfiguration": {
Expand All @@ -201,16 +213,20 @@
"name": "lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb",
"type": "Microsoft.Network/loadBalancers",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"location": "eastus",
"sku": {
"name": "Standard"
},
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-00000000",
"frontendIPConfigurations": [
{
"name": "fe-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb",
"type": "Microsoft.Network/loadBalancers/frontendIPConfigurations",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"privateIPAddress": "10.0.1.4",
Expand All @@ -235,6 +251,8 @@
{
"name": "be-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/backendAddressPools/be-lb",
"type": "Microsoft.Network/loadBalancers/backendAddressPools",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"loadBalancingRules": [
Expand All @@ -249,6 +267,8 @@
{
"name": "rulelb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/loadBalancingRules/rulelb",
"type": "Microsoft.Network/loadBalancers/loadBalancingRules",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"frontendIPConfiguration": {
Expand All @@ -274,6 +294,8 @@
{
"name": "probe-lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/probes/probe-lb",
"type": "Microsoft.Network/loadBalancers/probes",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"protocol": "Http",
Expand All @@ -293,6 +315,8 @@
{
"name": "in-nat-rule",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/inboundNatRules/in-nat-rule",
"type": "Microsoft.Network/loadBalancers/inboundNatRules",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"frontendIPConfiguration": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"loadBalancingRules": [],
"probes": [],
"inboundNatRules": [],
"outboundRules": [],
"inboundNatPools": [
{
"properties": {
Expand All @@ -48,8 +49,7 @@
"name": "test",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/inboundNatPools/test"
}
],
"outboundRules": []
]
}
}
},
Expand All @@ -59,16 +59,20 @@
"name": "lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb",
"type": "Microsoft.Network/loadBalancers",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"location": "eastus",
"sku": {
"name": "Standard"
},
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-00000000",
"frontendIPConfigurations": [
{
"name": "test",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/test",
"type": "Microsoft.Network/loadBalancers/frontendIPConfigurations",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"privateIPAddress": "10.0.1.4",
Expand All @@ -93,6 +97,8 @@
{
"name": "test",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/inboundNatPools/test",
"type": "Microsoft.Network/loadBalancers/inboundNatPools",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"frontendPortRangeStart": 8080,
Expand All @@ -116,16 +122,20 @@
"name": "lb",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb",
"type": "Microsoft.Network/loadBalancers",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"location": "eastus",
"sku": {
"name": "Standard"
},
"properties": {
"provisioningState": "Succeeded",
"resourceGuid": "00000000-0000-0000-0000-00000000",
"frontendIPConfigurations": [
{
"name": "test",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/test",
"type": "Microsoft.Network/loadBalancers/frontendIPConfigurations",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"privateIPAddress": "10.0.1.4",
Expand All @@ -150,6 +160,8 @@
{
"name": "test",
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/inboundNatPools/test",
"type": "Microsoft.Network/loadBalancers/inboundNatPools",
"etag": "W/\"00000000-0000-0000-0000-00000000\"",
"properties": {
"provisioningState": "Succeeded",
"frontendPortRangeStart": 8080,
Expand Down
Loading

0 comments on commit d3acd59

Please sign in to comment.