-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… #6164
Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… #6164
Conversation
Automation for azure-sdk-for-javaEncountered a Subprocess error: (azure-sdk-for-java)
Command: ['/usr/local/bin/autorest', '/tmp/tmp_yeao6v7/rest/specification/network/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpw8cxuijw'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
at main (/opt/node_modules/autorest/dist/app.js:232:19)
at <anonymous>
/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
autorest_core_1.Shutdown();
^
ReferenceError: autorest_core_1 is not defined
at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
at emitOne (events.js:121:20)
at process.emit (events.js:211:7)
at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
return binding.close(fd);
^
Error: EBADF: bad file descriptor, close
at Object.fs.closeSync (fs.js:612:18)
at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
at process._fatalException (bootstrap_node.js:391:26) |
Automation for azure-sdk-for-pythonEncountered a Subprocess error: (azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmp7pin62v9/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp7pin62v9/sdk/sdk', '[email protected]/[email protected]', '--version=preview'] AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4377)
Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .
<--- Last few GCs --->
[18065:0x4073c70] 85898 ms: Mark-sweep 1380.7 (1425.5) -> 1380.2 (1426.0) MB, 3675.7 / 0.0 ms (average mu = 0.079, current mu = 0.001) allocation failure scavenge might not succeed
[18065:0x4073c70] 88402 ms: Mark-sweep 1381.1 (1426.0) -> 1380.7 (1426.5) MB, 2501.1 / 0.0 ms (average mu = 0.044, current mu = 0.001) allocation failure scavenge might not succeed
<--- JS stacktrace --->
==== JS stack trace =========================================
Security context: 0x3a9d0bf1e6e9 <JSObject>
0: builtin exit frame: concat(this=0x3d988afc6d79 <JSArray[4]>,0x3d988afc84e9 <JSArray[1]>,0x3d988afc6d79 <JSArray[4]>)
1: Descendants [0x1bd81c5fe8b1] [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~29] [pc=0x3287792cf15](this=0x1bd81c5fe4b9 <Object map = 0x2f6e56864a19>,/* anonymous */=0x04be07882801 <the_hole>...
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
1: 0x8dc510 node::Abort() [node]
2: 0x8dc55c [node]
3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
5: 0xec7bf2 [node]
6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea0466 v8::internal::Factory::AllocateRawArray(int, v8::internal::PretenureFlag) [node]
11: 0xea0cea v8::internal::Factory::NewFixedArrayWithFiller(v8::internal::Heap::RootListIndex, int, v8::internal::Object*, v8::internal::PretenureFlag) [node]
12: 0xead6d1 v8::internal::Factory::NewJSArrayStorage(v8::internal::Handle<v8::internal::JSArray>, int, int, v8::internal::ArrayStorageAllocationMode) [node]
13: 0xead9cc v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [node]
14: 0xe66e01 v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int, unsigned int) [node]
15: 0xb63d99 [node]
16: 0xb6d498 v8::internal::Builtin_ArrayConcat(int, v8::internal::Object**, v8::internal::Isolate*) [node]
17: 0x3287755bf7d |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: ['/usr/local/bin/autorest', '/tmp/tmpr64r82l1/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpr64r82l1/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '[email protected]/autorest.go@~2.1.133', '--use-onever', '--verbose'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
Including configuration file 'file:///tmp/tmpr64r82l1/rest/specification/network/resource-manager/readme.go.md'
Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.133->2.1.133)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-02"} .
Including configuration file 'file:///tmp/tmpr64r82l1/rest/specification/network/resource-manager/readme.go.md'
<--- Last few GCs --->
[25600:0x23878c0] 130284 ms: Mark-sweep 1387.4 (1475.4) -> 1387.4 (1477.4) MB, 1908.3 / 0.0 ms allocation failure GC in old space requested
[25600:0x23878c0] 132152 ms: Mark-sweep 1387.4 (1477.4) -> 1387.3 (1440.9) MB, 1867.6 / 0.0 ms last resort GC in old space requested
[25600:0x23878c0] 135718 ms: Mark-sweep 1387.3 (1440.9) -> 1387.3 (1438.4) MB, 3565.7 / 0.0 ms last resort GC in old space requested
<--- JS stacktrace --->
==== JS stack trace =========================================
Security context: 0x2d74bb2a5879 <JSObject>
1: set [native weak-collection.js:~27] [pc=0x48099a7c369](this=0x2b0bf39d6a41 <JSWeakMap>,key=0x9e6993bbd21 <Object map = 0x11fd6a198151>,value=0x309bb22826f9 <String[6]: String>)
2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0x48099a61d39](this=0x274f00e022d1 <un...
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
1: node::Abort() [node]
2: 0x8cbf4c [node]
3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x480999042fd |
Automation for azure-sdk-for-jsEncountered a Subprocess error: (azure-sdk-for-js)
Command: ['/usr/local/bin/autorest', '/tmp/tmpox34u388/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmpox34u388/azure-sdk-for-js', '[email protected]/[email protected]'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4299)
Loading AutoRest extension '@microsoft.azure/autorest.typescript' (4.0.0->4.0.0)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)
<--- Last few GCs --->
[16345:0x2c45860] 152454 ms: Mark-sweep 1396.8 (1479.1) -> 1396.8 (1479.6) MB, 1869.5 / 0.0 ms allocation failure GC in old space requested
[16345:0x2c45860] 154484 ms: Mark-sweep 1396.8 (1479.6) -> 1396.8 (1440.6) MB, 2029.4 / 0.0 ms last resort GC in old space requested
[16345:0x2c45860] 156200 ms: Mark-sweep 1396.8 (1440.6) -> 1396.8 (1440.6) MB, 1715.4 / 0.1 ms last resort GC in old space requested
<--- JS stacktrace --->
==== JS stack trace =========================================
Security context: 0x27763ea25879 <JSObject>
1: readLineBreak(aka readLineBreak) [/node_modules/yaml-ast-parser/dist/src/loader.js:~300] [pc=0x271ee213c602](this=0x25db593022d1 <undefined>,state=0x9ba68c45d81 <State map = 0x251268aec2c1>)
2: readFlowCollection(aka readFlowCollection) [/node_modules/yaml-ast-parser/dist/src/loader.js:~596] [pc=0x271ee2135270](this=0x25db593022d1 <undefined>,state=0x9ba68c45d81 <State map = 0x251268a...
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
1: node::Abort() [node]
2: 0x8cbf4c [node]
3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
5: v8::internal::Factory::NewUninitializedFixedArray(int) [node]
6: 0xd7fc13 [node]
7: v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [node]
8: 0x271ee1e042fd |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Can one of the admins verify this patch? |
specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/loadBalancer.json
Outdated
Show resolved
Hide resolved
Fixed examples.
|
network-may-release branch has the latest version of 2019-06-01. Please port these changes to this version if needed. |
I've added changes to 2019-06-01. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01 * Updates readme * Updates API version in new specs and examples * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (#6164) * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties. * Fixed LB examples * Fix examples in 2019-06-01 * Remove API version number in privateIPAddressVersion description. * Add privateIPAddressVersion in LoadBalancer examples. * Add privateIPAddressVersion in 2019-06-01 API version. * Update specs to avoid readOnly in the request body (#6228) * typo: netowork May double word the (#6206) * Update cipher suites (#6213) * removing resource group name from PrepareNetworkPoliciesRequest (#6232) * Add exception for property "Conditon" in Network's webapplicationfirewall.json (#6335) * Extend long-running ops fixes to new API version; Suppression (#6336) * Update long-running for new API version * Add suppression for new API * Updated examples to have valid bodies for live put (#6349) * More examples fix after live testing (#6382) * Improved more examples after live testing * Fix validations * Improve descriptions in Network to align with Swagger guidelines (#6350) * Improve descriptions in Network to align with Swagger guidelines * Fix for CI * More examples improvements (#6444) * Add PATCH to Azure Firewall supported operations (#6486) * Add PATCH to Azure Firewall supported operations * Name the parameter how validation expects it * Patch is not a long running operation, so update the specs accordingly * PrivateEndpoint & PrivateLinkService APIs update (#6332) * Add two properties on Subnet for privateIp. Add two new APIs to support privateIp. Minor modify on readme.md file. * Fix some issue found by Model Validation. * Merge all apis relative to private end point / private link service to its json file. * Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property. * Change AutoApprovedPrivateLinkService structure to fit with NRP side. * Delete suppress for merged APIs in readme.md. * 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service. * Minor fix for model validation. * Revert opertion id changes for AvailablePrivateEndpointType to previous name. * 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter. * Improve Network's examples (#6493) * Removed read-only props from VPNGW example * Fixed LoadBalancer examples: * "outboundRules" array isn't returned for "Basic" SKU load balancer * added example for external LB with outboundRules * added missing read-only properties * Replace "regionName" in examples with real location * Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer * chore: jsonfmt network (#6592) * Adding VpnSiteLink and VpnSiteLinkConnection properties. (#6528) * Added VpnSiteLink/VpnSiteLinkConnection operations. * Sdk changes for vpn site link. * Fixing error. * Fixing more comments. * Fixing json error. * Fixing json files. * Fixing comments. * Fixing more issues. * Fixing more errors. * Fixing more error. * Prettify JSON in VpnConnectionGet.json * Resolving more comments. * Fixing typo. * Adding type in examples of put. * Removing Child resource type. * chore: jsonfmt network-may * Fix incorrect examples
* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01 * Updates readme * Updates API version in new specs and examples * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (Azure#6164) * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties. * Fixed LB examples * Fix examples in 2019-06-01 * Remove API version number in privateIPAddressVersion description. * Add privateIPAddressVersion in LoadBalancer examples. * Add privateIPAddressVersion in 2019-06-01 API version. * Update specs to avoid readOnly in the request body (Azure#6228) * typo: netowork May double word the (Azure#6206) * Update cipher suites (Azure#6213) * removing resource group name from PrepareNetworkPoliciesRequest (Azure#6232) * Add exception for property "Conditon" in Network's webapplicationfirewall.json (Azure#6335) * Extend long-running ops fixes to new API version; Suppression (Azure#6336) * Update long-running for new API version * Add suppression for new API * Updated examples to have valid bodies for live put (Azure#6349) * More examples fix after live testing (Azure#6382) * Improved more examples after live testing * Fix validations * Improve descriptions in Network to align with Swagger guidelines (Azure#6350) * Improve descriptions in Network to align with Swagger guidelines * Fix for CI * More examples improvements (Azure#6444) * Add PATCH to Azure Firewall supported operations (Azure#6486) * Add PATCH to Azure Firewall supported operations * Name the parameter how validation expects it * Patch is not a long running operation, so update the specs accordingly * PrivateEndpoint & PrivateLinkService APIs update (Azure#6332) * Add two properties on Subnet for privateIp. Add two new APIs to support privateIp. Minor modify on readme.md file. * Fix some issue found by Model Validation. * Merge all apis relative to private end point / private link service to its json file. * Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property. * Change AutoApprovedPrivateLinkService structure to fit with NRP side. * Delete suppress for merged APIs in readme.md. * 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service. * Minor fix for model validation. * Revert opertion id changes for AvailablePrivateEndpointType to previous name. * 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter. * Improve Network's examples (Azure#6493) * Removed read-only props from VPNGW example * Fixed LoadBalancer examples: * "outboundRules" array isn't returned for "Basic" SKU load balancer * added example for external LB with outboundRules * added missing read-only properties * Replace "regionName" in examples with real location * Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer * chore: jsonfmt network (Azure#6592) * Adding VpnSiteLink and VpnSiteLinkConnection properties. (Azure#6528) * Added VpnSiteLink/VpnSiteLinkConnection operations. * Sdk changes for vpn site link. * Fixing error. * Fixing more comments. * Fixing json error. * Fixing json files. * Fixing comments. * Fixing more issues. * Fixing more errors. * Fixing more error. * Prettify JSON in VpnConnectionGet.json * Resolving more comments. * Fixing typo. * Adding type in examples of put. * Removing Child resource type. * chore: jsonfmt network-may * Fix incorrect examples
…operties.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.