Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.HealthcareApis to add version preview/2018-08-20-preview #6244

Merged
merged 6 commits into from
Jul 1, 2019
Merged

[Hub Generated] Review request for Microsoft.HealthcareApis to add version preview/2018-08-20-preview #6244

merged 6 commits into from
Jul 1, 2019

Conversation

YazanMSFT
Copy link
Contributor

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 6, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 263297a)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI AutorestCI mentioned this pull request Jun 6, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5581

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#4070

@AutorestCI AutorestCI mentioned this pull request Jun 6, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5172

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from amarzavery June 6, 2019 18:10
@amarzavery amarzavery added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 14, 2019
@AutorestCI AutorestCI mentioned this pull request Jun 24, 2019
Merged
@YazanMSFT
Copy link
Contributor Author

@ravbhatnagar Could you review this please?

@ravbhatnagar
Copy link
Contributor

@YazanMSFT - new writable properties have been added to existing api-version. What is the service behavior if these properties are missing in the request body (and say for example they were set previously using portal)

@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 27, 2019
@YazanMSFT
Copy link
Contributor Author

@ravbhatnagar the service is fully backwards compatible in that case, the request will be accepted and their service will continue to behave as it did before.

@ravbhatnagar
Copy link
Contributor

Confirmed with @YazanMSFT, in the current modeling, customer can unintentionally wipe out the value set for these new properties. This is not ideal. But seems like this change is already rolled out on the service side. it has been brought to the attention of the team that design first approach must be followed.
Signing off on this. It will break private preview customers, but service team will communicate it to the current customers.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 27, 2019
@amarzavery amarzavery merged commit 7fb2d7a into Azure:master Jul 1, 2019
@poadhika poadhika mentioned this pull request Jul 1, 2019
Closed
8 tasks
@poadhika poadhika mentioned this pull request Jul 8, 2019
Merged
8 tasks
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@YazanMSFT @celikcigdem
[Hub Generated] Review request for Microsoft.HealthcareApis to add ve…
c905506 
…rsion preview/2018-08-20-preview (Azure#6244)

* Merge over updates to add Cors and Authentication, remove move from our operations.

* Remove node.js, add python, add preview to tags

* Remove move resource example

* Remove uuid format from subscriptionid as no other RP does this and it is causing issues with the .net SDK
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@AzureRestAPISpecReview
[AutoSync] 53f5039 update 2021-12-01-privatepreview of dryrun api (#6244
13b0036 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@amarzavery amarzavery amarzavery approved these changes

Assignees

@amarzavery amarzavery

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YazanMSFT @AutorestCI @azuresdkci @ravbhatnagar @nschonni @amarzavery