Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing HealthcareApis #6766

Closed
wants to merge 16 commits into from
Closed

Introducing HealthcareApis #6766

wants to merge 16 commits into from

Conversation

poadhika
Copy link
Contributor

@poadhika poadhika commented Jul 1, 2019

Adding HealthcareApis into Azure SDK.

This PR comprises of new modules for HealthcareApis that is used to manage HealthcareApis accounts such as (Get/Create/Update/Delete)

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please add REST spec PR link to the SDK PR
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines

  • Title of the pull request is clear and informative.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

REST spec PR: Azure/azure-rest-api-specs-pr:
Azure/azure-rest-api-specs#5096
Azure/azure-rest-api-specs#6244

<PackageReference Include="Microsoft.Azure.Management.ResourceManager.Fluent" Version="1.22.2" />
<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure.TestFramework" Version="1.7.6" />
<PackageReference Include="xunit" Version="2.3.1" />
</ItemGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 24,25 and 27 are unnecessary because they are included in AzSdk.test.reference.targets

<TargetFrameworks>$(SdkTargetFx)</TargetFrameworks>
<SignAssembly>false</SignAssembly>
</PropertyGroup>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss PackageReleaseNotes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 14 specifies the PackageReleaseNotes. I will fix the intendation though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format this file.

@@ -0,0 +1,7 @@
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
Copy link
Member

@erich-wang erich-wang Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from management plane perspective:

  1. All the files should be put in sdk instead of src/SDKs because of structure refactoring
  2. Use lower case heaalthcareapis for folder name of this service
  3. The folder name and project names should start with Microsoft.Azure.


<PropertyGroup>
<TargetFrameworks>$(SdkTargetFx)</TargetFrameworks>
<SignAssembly>false</SignAssembly>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line 19

@erich-wang
Copy link
Member

@poadhika, please close this PR and create two separate PRs for data plane and management plane respectively, please also address all comments for management plane.

<OutputType>Library</OutputType>
<StartupObject />
</PropertyGroup>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove line 3-8

<OutputPath>bin\Debug\</OutputPath>
<DocumentationFile>obj\Debug\netcoreapp2.0\HealthcareApis.Tests.xml</DocumentationFile>
</PropertyGroup>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove line 17-21

@erich-wang erich-wang self-assigned this Jul 4, 2019
@poadhika poadhika closed this Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants