-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing HealthcareApis #6766
Conversation
Updates on Generated Code and New Tests added in .Net SDK
<PackageReference Include="Microsoft.Azure.Management.ResourceManager.Fluent" Version="1.22.2" /> | ||
<PackageReference Include="Microsoft.Rest.ClientRuntime.Azure.TestFramework" Version="1.7.6" /> | ||
<PackageReference Include="xunit" Version="2.3.1" /> | ||
</ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 24,25 and 27 are unnecessary because they are included in AzSdk.test.reference.targets
<TargetFrameworks>$(SdkTargetFx)</TargetFrameworks> | ||
<SignAssembly>false</SignAssembly> | ||
</PropertyGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
miss PackageReleaseNotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 14 specifies the PackageReleaseNotes. I will fix the intendation though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format this file.
@@ -0,0 +1,7 @@ | |||
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments from management plane perspective:
- All the files should be put in sdk instead of src/SDKs because of structure refactoring
- Use lower case heaalthcareapis for folder name of this service
- The folder name and project names should start with Microsoft.Azure.
|
||
<PropertyGroup> | ||
<TargetFrameworks>$(SdkTargetFx)</TargetFrameworks> | ||
<SignAssembly>false</SignAssembly> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove line 19
@poadhika, please close this PR and create two separate PRs for data plane and management plane respectively, please also address all comments for management plane. |
<OutputType>Library</OutputType> | ||
<StartupObject /> | ||
</PropertyGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove line 3-8
<OutputPath>bin\Debug\</OutputPath> | ||
<DocumentationFile>obj\Debug\netcoreapp2.0\HealthcareApis.Tests.xml</DocumentationFile> | ||
</PropertyGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove line 17-21
Adding HealthcareApis into Azure SDK.
This PR comprises of new modules for HealthcareApis that is used to manage HealthcareApis accounts such as (Get/Create/Update/Delete)
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
REST spec PR: Azure/azure-rest-api-specs-pr:
Azure/azure-rest-api-specs#5096
Azure/azure-rest-api-specs#6244