Introducing HealthcareApis #6839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checkin Related to HealthcareApis
|
I closed the PR#6766 as suggested and opened this new one. |
erich-wang
suggested changes
Jul 9, 2019
| <OutputType>Library</OutputType> | ||
| <StartupObject /> | ||
| <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
@poadhika , please remove line 19-22, and format this file
| <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.6.0-preview" /> | ||
| <PackageReference Update="Microsoft.Azure.Test.HttpRecorder" Version="1.13.3" /> | ||
| <ProjectReference Include="..\src\Microsoft.Azure.Management.HealthcareApis.csproj" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Line 24,25 and 27 are unnecessary because they are included in AzSdk.test.reference.targets
There was a problem hiding this comment.
Line 27 is required as it is referring to the src project "Microsoft.Azure.Management.HealthcareApis.csproj".
| <Description>Provides management capabilities for Microsoft Azure Healthcare Apis.</Description> | ||
| <AssemblyTitle>Microsoft Azure Healthcare Apis Management</AssemblyTitle> | ||
| <AssemblyName>Microsoft.Azure.Management.HealthcareApis</AssemblyName> | ||
| <Version>1.0.5-preview</Version> |
There was a problem hiding this comment.
Suggest to use major version 0 for brand new preview feature, e.g. 0.8.0-preview
| <ApplicationIcon /> | ||
| <OutputType>Library</OutputType> | ||
| <StartupObject /> | ||
| </PropertyGroup> |
|
Please fix CI errors as well. |
Changes as per feedback
|
Updated the PR with the suggested changes. Also fixed the CI errors. |
erich-wang
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding HealthcareApis into Azure SDK.
This PR comprises of new modules for HealthcareApis that is used to manage HealthcareApis accounts such as (Get/Create/Update/Delete)
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
REST spec PR: Azure/azure-rest-api-specs-pr:
Azure/azure-rest-api-specs#5096
Azure/azure-rest-api-specs#6244