Add a new field to SignalR Resource property #5661
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -236,6 +236,9 @@ | |
| } | ||
| }, | ||
| "x-ms-long-running-operation": true, | ||
| "x-ms-long-running-operation-options": { | ||
| "final-state-via": "azure-async-operation" | ||
| }, | ||
| "x-ms-examples": { | ||
| "SignalR_RegenerateKey": { | ||
| "$ref": "./examples/SignalR_RegenerateKey.json" | ||
|
|
@@ -319,6 +322,9 @@ | |
| } | ||
| }, | ||
| "x-ms-long-running-operation": true, | ||
| "x-ms-long-running-operation-options": { | ||
| "final-state-via": "azure-async-operation" | ||
| }, | ||
| "x-ms-examples": { | ||
| "SignalR_CreateOrUpdate": { | ||
| "$ref": "./examples/SignalR_CreateOrUpdate.json" | ||
|
|
@@ -354,6 +360,9 @@ | |
| } | ||
| }, | ||
| "x-ms-long-running-operation": true, | ||
| "x-ms-long-running-operation-options": { | ||
| "final-state-via": "azure-async-operation" | ||
|
There was a problem hiding this comment. @juniwang same as above, why specify for delete? |
||
| }, | ||
| "x-ms-examples": { | ||
| "SignalR_Delete": { | ||
| "$ref": "./examples/SignalR_Delete.json" | ||
|
|
@@ -401,6 +410,9 @@ | |
| } | ||
| }, | ||
| "x-ms-long-running-operation": true, | ||
| "x-ms-long-running-operation-options": { | ||
| "final-state-via": "azure-async-operation" | ||
| }, | ||
| "x-ms-examples": { | ||
| "SignalR_Update": { | ||
| "$ref": "./examples/SignalR_Update.json" | ||
|
|
@@ -438,6 +450,9 @@ | |
| } | ||
| }, | ||
| "x-ms-long-running-operation": true, | ||
| "x-ms-long-running-operation-options": { | ||
| "final-state-via": "azure-async-operation" | ||
| }, | ||
| "x-ms-examples": { | ||
| "SignalR_Restart": { | ||
| "$ref": "./examples/SignalR_Restart.json" | ||
|
|
@@ -777,18 +792,18 @@ | |
| "x-ms-azure-resource": true | ||
| }, | ||
| "ResourceSku": { | ||
| "description": "The billing information of the SignalR resource.", | ||
| "required": [ | ||
| "name" | ||
| ], | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "description": "The name of the SKU. Required.\r\n\r\nAllowed values: Standard_S1, Free_F1", | ||
| "type": "string" | ||
| }, | ||
| "tier": { | ||
| "description": "Optional tier of this particular SKU. 'Standard' or 'Free'. \r\n\r\n`Basic` is deprecated, use `Standard` instead.", | ||
| "enum": [ | ||
| "Free", | ||
| "Basic", | ||
|
|
@@ -802,16 +817,16 @@ | |
| } | ||
| }, | ||
| "size": { | ||
| "description": "Optional string. For future use.", | ||
| "type": "string" | ||
| }, | ||
| "family": { | ||
| "description": "Optional string. For future use.", | ||
| "type": "string" | ||
| }, | ||
| "capacity": { | ||
| "format": "int32", | ||
| "description": "Optional, integer. The unit count of SignalR resource. 1 by default.\r\n\r\nIf present, following values are allowed:\r\n Free: 1\r\n Standard: 1,2,5,10,20,50,100", | ||
| "type": "integer" | ||
| } | ||
| } | ||
|
|
@@ -880,6 +895,48 @@ | |
| "hostNamePrefix": { | ||
| "description": "Prefix for the hostName of the SignalR service. Retained for future use.\r\nThe hostname will be of format: <hostNamePrefix>.service.signalr.net.", | ||
| "type": "string" | ||
| }, | ||
| "features": { | ||
| "description": "List of SignalR featureFlags. e.g. ServiceMode.\r\n\r\nFeatureFlags that are not included in the parameters for the update operation will not be modified.\r\nAnd the response will only include featureFlags that are explicitly set. \r\nWhen a featureFlag is not explicitly set, SignalR service will use its globally default value. \r\nBut keep in mind, the default value doesn't mean \"false\". It varies in terms of different FeatureFlags.", | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/SignalRFeature" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "SignalRFeature": { | ||
| "description": "Feature of a SignalR resource, which controls the SignalR runtime behavior.", | ||
| "required": [ | ||
| "flag", | ||
| "value" | ||
| ], | ||
| "type": "object", | ||
| "properties": { | ||
| "flag": { | ||
| "description": "Name of the feature. Required.", | ||
|
There was a problem hiding this comment. The description is a bit confusing since there can only be a limited number of values. There was a problem hiding this comment. I don't see any changes, not blocker though |
||
| "enum": [ | ||
| "ServiceMode" | ||
| ], | ||
| "type": "string", | ||
| "x-ms-enum": { | ||
| "name": "FeatureFlags", | ||
| "modelAsString": true | ||
| } | ||
| }, | ||
| "value": { | ||
| "description": "Value of the feature flag. See Azure SignalR service document https://docs.microsoft.com/en-us/azure/azure-signalr/ for allowed values.", | ||
| "maxLength": 128, | ||
| "minLength": 1, | ||
| "type": "string" | ||
| }, | ||
| "properties": { | ||
| "description": "Optional properties related to this feature.", | ||
| "type": "object", | ||
| "additionalProperties": { | ||
| "type": "string" | ||
| }, | ||
| "x-ms-client-flatten": false | ||
|
There was a problem hiding this comment. nit: This doesn't need to be set explicitly There was a problem hiding this comment. Removed. This produces a warning: If it doens't matter, we may suppress the warning in future. There was a problem hiding this comment. I see, we discourage too many levels of nesting especially on input parameters hence the warning. Please mark |
||
| } | ||
| } | ||
| }, | ||
|
|
@@ -1029,11 +1086,7 @@ | |
| "in": "query", | ||
| "description": "Client Api Version.", | ||
| "required": true, | ||
| "type": "string" | ||
| }, | ||
| "SubscriptionIdParameter": { | ||
| "name": "subscriptionId", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juniwang any reason you are adding this to PUT operations? I was under the impression that this is only for POST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Telling from this doc: When x-ms-long-running-operation is specified, there should also be a x-ms-long-running-operation-options specified..
Will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed