Add a new field to SignalR Resource property #5661

juniwang · 2019-04-16T07:23:41Z

Changes:

Add new property features to SignalRResource, which will used to query or update the FeatureFlags of SignalR resource. Corresponding examples updated.
remove enum property of api-version. The extra enum will fail .NET SDK generation
Add x-ms-long-running-operation-options for long runnint operations.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

AutorestCI · 2019-04-16T07:24:29Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5532

AutorestCI · 2019-04-16T07:24:38Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3268

AutorestCI · 2019-04-16T07:25:18Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#2514

AutorestCI · 2019-04-16T07:26:13Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4903

AutorestCI · 2019-04-16T07:26:18Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpemwsrxce/rest/specification/signalr/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmphook_9rm']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

azuresdkci · 2019-04-16T08:01:16Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5661' REST Spec PR Author 'juniwang' REST Spec PR Last commit

adxsdknet · 2019-04-16T08:06:38Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5823
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@5ebc936
adxsdknet/azure-sdk-for-net@0686f82
adxsdknet/azure-sdk-for-net@9eed052

dsgouda · 2019-04-16T16:21:09Z

@juniwang Please fix the merge conflicts

dsgouda

LGTM

dsgouda · 2019-04-16T21:16:40Z

stable version but additive changes, don't need ARM approval.

dsgouda

Will approve once merge conflicts are resolved.

juniwang · 2019-04-17T06:57:12Z

Will approve once merge conflicts are resolved.
@dsgouda Conflicts resolved

dsgouda · 2019-04-17T16:52:03Z

@shahabhijeet @NelsonDaniel Please approve

dsgouda

@juniwang the diffs here are hard to read, can you pull latest changes from master and reapply your chanes

juniwang · 2019-04-18T01:52:51Z

@dsgouda Thanks. Resetted using master branch and applid changes.

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

juniwang · 2019-04-25T03:37:04Z

@dsgouda @shahabhijeet Could you have a review again?

dsgouda · 2019-04-25T16:05:10Z

@shahabhijeet PTAL

juniwang · 2019-05-13T06:44:22Z

Hi @shahabhijeet, Could you please have another review? It seems that the PR is blocked by you

REST Spec PR 'Azure/azure-rest-api-specs#5661' REST Spec PR Author 'juniwang' REST Spec PR Last commit

dsgouda

Left a couple of comments

dsgouda · 2019-05-13T18:05:48Z

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

+          "additionalProperties": {
+            "type": "string"
+          },
+          "x-ms-client-flatten": false


nit: This doesn't need to be set explicitly

Removed. This produces a warning:

WARNING (AvoidNestedProperties/R2001/SDKViolation): Consider using x-ms-client-flatten to provide a better end user experience - file:///mnt/d/workspace/github/juniwang/azure-rest-api-specs/specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json:924:8 ($.definitions.SignalRFeature.properties.properties)

If it doens't matter, we may suppress the warning in future.

I see, we discourage too many levels of nesting especially on input parameters hence the warning. Please mark x-ms-client-flatten: true

dsgouda · 2019-05-13T18:07:15Z

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

+      "type": "object",
+      "properties": {
+        "flag": {
+          "description": "Name of the feature. Required.",


The description is a bit confusing since there can only be a limited number of values. Type/kind of feature makes more sense?

I don't see any changes, not blocker though

shahabhijeet · 2019-05-13T18:10:10Z

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

@@ -319,6 +322,9 @@
          }
        },
        "x-ms-long-running-operation": true,
+        "x-ms-long-running-operation-options": {
+          "final-state-via": "azure-async-operation"


@juniwang any reason you are adding this to PUT operations? I was under the impression that this is only for POST.

Telling from this doc: When x-ms-long-running-operation is specified, there should also be a x-ms-long-running-operation-options specified..

Will remove it.

shahabhijeet · 2019-05-13T18:10:37Z

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json

@@ -354,6 +360,9 @@
          }
        },
        "x-ms-long-running-operation": true,
+        "x-ms-long-running-operation-options": {
+          "final-state-via": "azure-async-operation"


@juniwang same as above, why specify for delete?

REST Spec PR 'Azure/azure-rest-api-specs#5661' REST Spec PR Author 'juniwang' REST Spec PR Last commit

juniwang · 2019-05-14T03:23:30Z

@shahabhijeet @dsgouda spec updated to rosolve comments

juniwang · 2019-05-20T06:49:14Z

@shahabhijeet PTAL

juniwang · 2019-05-28T03:07:03Z

@shahabhijeet any other comments? Or can someone review again on behalf of Abhijeet?

AutorestCI mentioned this pull request Apr 16, 2019

[AutoPR signalr/resource-manager] Add a new field to SignalR Resource property Azure/azure-sdk-for-python#4865

Closed

AutorestCI mentioned this pull request Apr 16, 2019

[AutoPR signalr/resource-manager] Add a new field to SignalR Resource property Azure/azure-sdk-for-js#2276

Closed

AutorestCI mentioned this pull request Apr 16, 2019

[AutoPR signalr/resource-manager] Add a new field to SignalR Resource property Azure/azure-sdk-for-ruby#2401

Closed

AutorestCI mentioned this pull request Apr 16, 2019

[AutoPR signalr/resource-manager] Add a new field to SignalR Resource property Azure/azure-sdk-for-go#4553

Closed

AutorestCI mentioned this pull request Apr 16, 2019

[AutoPR signalr/resource-manager] Add a new field to SignalR Resource property Azure/azure-sdk-for-java#3385

Closed

azuresdkci assigned dsgouda Apr 16, 2019

azuresdkci requested a review from dsgouda April 16, 2019 07:47

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 16, 2019

.NET SDK Resource Provider:'SignalR'

5ebc936

REST Spec PR 'Azure/azure-rest-api-specs#5661' REST Spec PR Author 'juniwang' REST Spec PR Last commit

dsgouda requested review from shahabhijeet and NelsonDaniel April 16, 2019 16:20

dsgouda added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 16, 2019

dsgouda approved these changes Apr 16, 2019

View reviewed changes

dsgouda removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 16, 2019

dsgouda suggested changes Apr 16, 2019

View reviewed changes

AutorestCI mentioned this pull request Apr 17, 2019

[AutoPR signalr/resource-manager] Add a new field to SignalR Resource property Azure/azure-sdk-for-js#2313

Closed

dsgouda suggested changes Apr 17, 2019

View reviewed changes

add new property of SignalR resource

540a8bc

juniwang force-pushed the signalrfeature branch from e8762b6 to 540a8bc Compare April 18, 2019 01:34

AutorestCI mentioned this pull request Apr 18, 2019

[AutoPR signalr/resource-manager] Add a new field to SignalR Resource property Azure/azure-sdk-for-js#2342

Closed

NelsonDaniel approved these changes Apr 18, 2019

View reviewed changes

shahabhijeet requested changes Apr 18, 2019

View reviewed changes

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json Outdated Show resolved Hide resolved

update description of features

73fdc5d

This was referenced May 13, 2019

[AutoPR signalr/resource-manager] Add a new field to SignalR Resource property Azure/azure-sdk-for-js#2854

Closed

[AutoPR signalr/resource-manager] Add a new field to SignalR Resource property Azure/azure-sdk-for-go#4784

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 13, 2019

.NET SDK Resource Provider:'SignalR'

0686f82

REST Spec PR 'Azure/azure-rest-api-specs#5661' REST Spec PR Author 'juniwang' REST Spec PR Last commit

dsgouda approved these changes May 13, 2019

View reviewed changes

dsgouda suggested changes May 13, 2019

View reviewed changes

shahabhijeet requested changes May 13, 2019

View reviewed changes

remove async-operation options

57833e3

AutorestCI mentioned this pull request May 14, 2019

[AutoPR signalr/resource-manager] Add a new field to SignalR Resource property Azure/azure-sdk-for-js#2881

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 14, 2019

.NET SDK Resource Provider:'SignalR'

9eed052

REST Spec PR 'Azure/azure-rest-api-specs#5661' REST Spec PR Author 'juniwang' REST Spec PR Last commit

dsgouda approved these changes May 14, 2019

View reviewed changes

shahabhijeet approved these changes May 29, 2019

View reviewed changes

dsgouda merged commit 33ff643 into Azure:master May 29, 2019

juniwang mentioned this pull request Jun 18, 2019

[SignalR] Update .net SDK for swagger PR 5661 Azure/azure-sdk-for-net#6610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a new field to SignalR Resource property #5661

Add a new field to SignalR Resource property #5661

juniwang commented Apr 16, 2019

AutorestCI commented Apr 16, 2019 •

edited

Loading

AutorestCI commented Apr 16, 2019 •

edited

Loading

AutorestCI commented Apr 16, 2019 •

edited

Loading

AutorestCI commented Apr 16, 2019 •

edited

Loading

AutorestCI commented Apr 16, 2019 •

edited

Loading

azuresdkci commented Apr 16, 2019

adxsdknet commented Apr 16, 2019 •

edited

Loading

dsgouda commented Apr 16, 2019

dsgouda left a comment

dsgouda commented Apr 16, 2019

dsgouda left a comment

juniwang commented Apr 17, 2019

dsgouda commented Apr 17, 2019

dsgouda left a comment

juniwang commented Apr 18, 2019

juniwang commented Apr 25, 2019

dsgouda commented Apr 25, 2019

juniwang commented May 13, 2019

dsgouda left a comment

dsgouda May 13, 2019

juniwang May 14, 2019

dsgouda May 14, 2019 •

edited

Loading

dsgouda May 13, 2019

juniwang May 14, 2019

dsgouda May 14, 2019

shahabhijeet May 13, 2019

juniwang May 14, 2019

juniwang May 14, 2019

shahabhijeet May 13, 2019

juniwang May 14, 2019

juniwang commented May 14, 2019

juniwang commented May 20, 2019

juniwang commented May 28, 2019

Add a new field to SignalR Resource property #5661

Add a new field to SignalR Resource property #5661

Conversation

juniwang commented Apr 16, 2019

Changes:

Contribution checklist:

AutorestCI commented Apr 16, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 16, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Apr 16, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Apr 16, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Apr 16, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Apr 16, 2019

adxsdknet commented Apr 16, 2019 • edited Loading

Automation for azure-sdk-for-net

dsgouda commented Apr 16, 2019

dsgouda left a comment

Choose a reason for hiding this comment

dsgouda commented Apr 16, 2019

dsgouda left a comment

Choose a reason for hiding this comment

juniwang commented Apr 17, 2019

dsgouda commented Apr 17, 2019

dsgouda left a comment

Choose a reason for hiding this comment

juniwang commented Apr 18, 2019

juniwang commented Apr 25, 2019

dsgouda commented Apr 25, 2019

juniwang commented May 13, 2019

dsgouda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsgouda May 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juniwang commented May 14, 2019

juniwang commented May 20, 2019

juniwang commented May 28, 2019

AutorestCI commented Apr 16, 2019 •

edited

Loading

AutorestCI commented Apr 16, 2019 •

edited

Loading

AutorestCI commented Apr 16, 2019 •

edited

Loading

AutorestCI commented Apr 16, 2019 •

edited

Loading

AutorestCI commented Apr 16, 2019 •

edited

Loading

adxsdknet commented Apr 16, 2019 •

edited

Loading

dsgouda May 14, 2019 •

edited

Loading