Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new field to SignalR Resource property #5661

Merged
merged 3 commits into from
May 29, 2019
Merged

Add a new field to SignalR Resource property #5661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
540a8bc
add new property of SignalR resource
juniwang Apr 18, 2019
73fdc5d
update description of features
juniwang May 13, 2019
57833e3
remove async-operation options
juniwang May 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions ...e-manager/Microsoft.SignalRService/stable/2018-10-01/examples/SignalR_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,14 @@
"capacity": 1
},
"properties": {
"hostNamePrefix": null
"hostNamePrefix": null,
"features": [
{
"flag": "ServiceMode",
"value": "Serverless",
"properties": {}
}
]
}
},
"api-version": "2018-10-01",
Expand All @@ -31,11 +38,18 @@
"properties": {
"provisioningState": "Succeeded",
"externalIP": "10.0.0.1",
"hostName": "myservice.service.signalr.net",
"hostName": "mysignalrservice.service.signalr.net",
"publicPort": 443,
"serverPort": 443,
"version": "1.0-preview",
"hostNamePrefix": null
"version": "1.0",
"hostNamePrefix": null,
"features": [
{
"flag": "ServiceMode",
"value": "Serverless",
"properties": {}
}
]
},
"location": "eastus",
"tags": {
Expand Down
13 changes: 10 additions & 3 deletions ...alr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/examples/SignalR_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,18 @@
"properties": {
"provisioningState": "Succeeded",
"externalIP": "10.0.0.1",
"hostName": "myservice.service.signalr.net",
"hostName": "mysignalrservice.service.signalr.net",
"publicPort": 443,
"serverPort": 443,
"version": "1.0-preview",
"hostNamePrefix": null
"version": "1.0",
"hostNamePrefix": null,
"features": [
{
"flag": "ServiceMode",
"value": "Serverless",
"properties": {}
}
]
},
"location": "eastus",
"tags": {
Expand Down
13 changes: 10 additions & 3 deletions ...ager/Microsoft.SignalRService/stable/2018-10-01/examples/SignalR_ListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,18 @@
"properties": {
"provisioningState": "Succeeded",
"externalIP": "10.0.0.1",
"hostName": "myservice.service.signalr.net",
"hostName": "mysignalrservice.service.signalr.net",
"publicPort": 443,
"serverPort": 443,
"version": "1.0-preview",
"hostNamePrefix": null
"version": "1.0",
"hostNamePrefix": null,
"features": [
{
"flag": "ServiceMode",
"value": "Serverless",
"properties": {}
}
]
},
"location": "eastus",
"tags": {
Expand Down
13 changes: 10 additions & 3 deletions ...nager/Microsoft.SignalRService/stable/2018-10-01/examples/SignalR_ListBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,18 @@
"properties": {
"provisioningState": "Succeeded",
"externalIP": "10.0.0.1",
"hostName": "myservice.service.signalr.net",
"hostName": "mysignalrservice.service.signalr.net",
"publicPort": 443,
"serverPort": 443,
"version": "1.0-preview",
"hostNamePrefix": null
"version": "1.0",
"hostNamePrefix": null,
"features": [
{
"flag": "ServiceMode",
"value": "Serverless",
"properties": {}
}
]
},
"location": "eastus",
"tags": {
Expand Down
22 changes: 18 additions & 4 deletions .../resource-manager/Microsoft.SignalRService/stable/2018-10-01/examples/SignalR_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,14 @@
"capacity": 1
},
"properties": {
"hostNamePrefix": null
"hostNamePrefix": null,
"features": [
{
"flag": "ServiceMode",
"value": "Serverless",
"properties": {}
}
]
}
},
"api-version": "2018-10-01",
Expand All @@ -30,11 +37,18 @@
"properties": {
"provisioningState": "Succeeded",
"externalIP": "10.0.0.1",
"hostName": "myservice.service.signalr.net",
"hostName": "mysignalrservice.service.signalr.net",
"publicPort": 443,
"serverPort": 443,
"version": "1.0-preview",
"hostNamePrefix": null
"version": "1.0",
"hostNamePrefix": null,
"features": [
{
"flag": "ServiceMode",
"value": "Serverless",
"properties": {}
}
]
},
"location": "eastus",
"tags": {
Expand Down
65 changes: 54 additions & 11 deletions ...fication/signalr/resource-manager/Microsoft.SignalRService/stable/2018-10-01/signalr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,9 @@
}
},
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "azure-async-operation"
},
"x-ms-examples": {
"SignalR_RegenerateKey": {
"$ref": "./examples/SignalR_RegenerateKey.json"
Expand Down Expand Up @@ -438,6 +441,9 @@
}
},
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "azure-async-operation"
},
"x-ms-examples": {
"SignalR_Restart": {
"$ref": "./examples/SignalR_Restart.json"
Expand Down Expand Up @@ -777,18 +783,18 @@
"x-ms-azure-resource": true
},
"ResourceSku": {
"description": "The billing information of the resource.(e.g. basic vs. standard)",
"description": "The billing information of the SignalR resource.",
"required": [
"name"
],
"type": "object",
"properties": {
"name": {
"description": "The name of the SKU. This is typically a letter + number code, such as A0 or P3. Required (if sku is specified)",
"description": "The name of the SKU. Required.\r\n\r\nAllowed values: Standard_S1, Free_F1",
"type": "string"
},
"tier": {
"description": "Optional tier of this particular SKU. `Basic` is deprecated, use `Standard` instead.",
"description": "Optional tier of this particular SKU. 'Standard' or 'Free'. \r\n\r\n`Basic` is deprecated, use `Standard` instead.",
"enum": [
"Free",
"Basic",
Expand All @@ -802,16 +808,16 @@
}
},
"size": {
"description": "Optional, string. When the name field is the combination of tier and some other value, this would be the standalone code.",
"description": "Optional string. For future use.",
"type": "string"
},
"family": {
"description": "Optional, string. If the service has different generations of hardware, for the same SKU, then that can be captured here.",
"description": "Optional string. For future use.",
"type": "string"
},
"capacity": {
"format": "int32",
"description": "Optional, integer. If the SKU supports scale out/in then the capacity integer should be included. If scale out/in is not \r\npossible for the resource this may be omitted.",
"description": "Optional, integer. The unit count of SignalR resource. 1 by default.\r\n\r\nIf present, following values are allowed:\r\n Free: 1\r\n Standard: 1,2,5,10,20,50,100",
"type": "integer"
}
}
Expand Down Expand Up @@ -880,6 +886,47 @@
"hostNamePrefix": {
"description": "Prefix for the hostName of the SignalR service. Retained for future use.\r\nThe hostname will be of format: <hostNamePrefix>.service.signalr.net.",
"type": "string"
},
"features": {
"description": "List of SignalR featureFlags. e.g. ServiceMode.\r\n\r\nFeatureFlags that are not included in the parameters for the update operation will not be modified.\r\nAnd the response will only include featureFlags that are explicitly set. \r\nWhen a featureFlag is not explicitly set, SignalR service will use its globally default value. \r\nBut keep in mind, the default value doesn't mean \"false\". It varies in terms of different FeatureFlags.",
"type": "array",
"items": {
"$ref": "#/definitions/SignalRFeature"
}
}
}
},
"SignalRFeature": {
"description": "Feature of a SignalR resource, which controls the SignalR runtime behavior.",
"required": [
"flag",
"value"
],
"type": "object",
"properties": {
"flag": {
"description": "Kind of feature. Required.",
"enum": [
"ServiceMode"
],
"type": "string",
"x-ms-enum": {
"name": "FeatureFlags",
"modelAsString": true
}
},
"value": {
"description": "Value of the feature flag. See Azure SignalR service document https://docs.microsoft.com/en-us/azure/azure-signalr/ for allowed values.",
"maxLength": 128,
"minLength": 1,
"type": "string"
},
"properties": {
"description": "Optional properties related to this feature.",
"type": "object",
"additionalProperties": {
"type": "string"
}
}
}
},
Expand Down Expand Up @@ -1029,11 +1076,7 @@
"in": "query",
"description": "Client Api Version.",
"required": true,
"type": "string",
"enum": [
"2018-03-01-preview",
"2018-10-01"
]
"type": "string"
},
"SubscriptionIdParameter": {
"name": "subscriptionId",
Expand Down