Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workbooks api to include sourceId #10781

Conversation

yves-chan
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 14, 2020

[Staging] Swagger Validation Report

BreakingChange: 3 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L384:9
Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L385:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L384:9
Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L385:9
1041 - AddedPropertyInResponse The new version has a new property 'sourceId' in response that was not found in the old version.
New: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L355:7
Old: Microsoft.Insights/preview/2018-06-17-preview/workbooks_API.json#L356:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 14, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 14, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 5ca1949 with merge commit e354da0. SDK Automation 13.0.17.20200909.5
  • ️✔️appinsights/mgmt/2015-05-01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 15 Sep 2020 02:23:47 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:4997:CAD3DF:2034098:5F6025B3","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 14, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 5ca1949 with merge commit e354da0. SDK Automation 13.0.17.20200909.5
  • ️✔️@azure/arm-appinsights [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/applicationInsightsManagementClient.js → ./dist/arm-appinsights.js...
    [npmPack] created ./dist/arm-appinsights.js in 651ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 6.0kB   esm/operations/analyticsItems.js                                   
    [npmPack] npm notice 505B    esm/models/analyticsItemsMappers.js                                
    [npmPack] npm notice 6.1kB   esm/operations/annotations.js                                      
    [npmPack] npm notice 470B    esm/models/annotationsMappers.js                                   
    [npmPack] npm notice 5.3kB   esm/operations/aPIKeys.js                                          
    [npmPack] npm notice 499B    esm/models/aPIKeysMappers.js                                       
    [npmPack] npm notice 3.1kB   esm/applicationInsightsManagementClient.js                         
    [npmPack] npm notice 2.6kB   esm/applicationInsightsManagementClientContext.js                  
    [npmPack] npm notice 228.5kB dist/arm-appinsights.js                                            
    [npmPack] npm notice 81.8kB  dist/arm-appinsights.min.js                                        
    [npmPack] npm notice 2.1kB   esm/operations/componentAvailableFeatures.js                       
    [npmPack] npm notice 552B    esm/models/componentAvailableFeaturesMappers.js                    
    [npmPack] npm notice 3.5kB   esm/operations/componentCurrentBillingFeatures.js                  
    [npmPack] npm notice 514B    esm/models/componentCurrentBillingFeaturesMappers.js               
    [npmPack] npm notice 2.1kB   esm/operations/componentFeatureCapabilities.js                     
    [npmPack] npm notice 472B    esm/models/componentFeatureCapabilitiesMappers.js                  
    [npmPack] npm notice 6.1kB   esm/operations/componentLinkedStorageAccountsOperations.js         
    [npmPack] npm notice 937B    esm/models/componentLinkedStorageAccountsOperationsMappers.js      
    [npmPack] npm notice 2.0kB   esm/operations/componentQuotaStatus.js                             
    [npmPack] npm notice 456B    esm/models/componentQuotaStatusMappers.js                          
    [npmPack] npm notice 10.9kB  esm/operations/components.js                                       
    [npmPack] npm notice 1.0kB   esm/models/componentsMappers.js                                    
    [npmPack] npm notice 7.6kB   esm/operations/exportConfigurations.js                             
    [npmPack] npm notice 507B    esm/models/exportConfigurationsMappers.js                          
    [npmPack] npm notice 7.2kB   esm/operations/favorites.js                                        
    [npmPack] npm notice 442B    esm/models/favoritesMappers.js                                     
    [npmPack] npm notice 345B    esm/models/index.js                                                
    [npmPack] npm notice 1.1kB   esm/operations/index.js                                            
    [npmPack] npm notice 1.7kB   esm/operations/liveToken.js                                        
    [npmPack] npm notice 426B    esm/models/liveTokenMappers.js                                     
    [npmPack] npm notice 72.7kB  esm/models/mappers.js                                              
    [npmPack] npm notice 7.3kB   esm/operations/myWorkbooks.js                                      
    [npmPack] npm notice 916B    esm/models/myWorkbooksMappers.js                                   
    [npmPack] npm notice 3.6kB   esm/operations/operations.js                                       
    [npmPack] npm notice 522B    esm/models/operationsMappers.js                                    
    [npmPack] npm notice 8.4kB   esm/models/parameters.js                                           
    [npmPack] npm notice 5.2kB   esm/operations/proactiveDetectionConfigurations.js                 
    [npmPack] npm notice 889B    esm/models/proactiveDetectionConfigurationsMappers.js              
    [npmPack] npm notice 1.0kB   rollup.config.js                                                   
    [npmPack] npm notice 2.0kB   esm/operations/webTestLocations.js                                 
    [npmPack] npm notice 503B    esm/models/webTestLocationsMappers.js                              
    [npmPack] npm notice 9.9kB   esm/operations/webTests.js                                         
    [npmPack] npm notice 898B    esm/models/webTestsMappers.js                                      
    [npmPack] npm notice 6.3kB   esm/operations/workbooks.js                                        
    [npmPack] npm notice 910B    esm/models/workbooksMappers.js                                     
    [npmPack] npm notice 8.0kB   esm/operations/workItemConfigurations.js                           
    [npmPack] npm notice 543B    esm/models/workItemConfigurationsMappers.js                        
    [npmPack] npm notice 1.7kB   package.json                                                       
    [npmPack] npm notice 457B    tsconfig.json                                                      
    [npmPack] npm notice 2.6kB   esm/operations/analyticsItems.d.ts.map                             
    [npmPack] npm notice 3.4kB   esm/operations/analyticsItems.js.map                               
    [npmPack] npm notice 213B    esm/models/analyticsItemsMappers.d.ts.map                          
    [npmPack] npm notice 226B    esm/models/analyticsItemsMappers.js.map                            
    [npmPack] npm notice 2.5kB   esm/operations/annotations.d.ts.map                                
    [npmPack] npm notice 3.4kB   esm/operations/annotations.js.map                                  
    [npmPack] npm notice 224B    esm/models/annotationsMappers.d.ts.map                             
    [npmPack] npm notice 237B    esm/models/annotationsMappers.js.map                               
    [npmPack] npm notice 2.3kB   esm/operations/aPIKeys.d.ts.map                                    
    [npmPack] npm notice 3.0kB   esm/operations/aPIKeys.js.map                                      
    [npmPack] npm notice 209B    esm/models/aPIKeysMappers.d.ts.map                                 
    [npmPack] npm notice 222B    esm/models/aPIKeysMappers.js.map                                   
    [npmPack] npm notice 1.3kB   esm/applicationInsightsManagementClient.d.ts.map                   
    [npmPack] npm notice 1.9kB   esm/applicationInsightsManagementClient.js.map                     
    [npmPack] npm notice 505B    esm/applicationInsightsManagementClientContext.d.ts.map            
    [npmPack] npm notice 1.4kB   esm/applicationInsightsManagementClientContext.js.map              
    [npmPack] npm notice 528.5kB dist/arm-appinsights.js.map                                        
    [npmPack] npm notice 68.4kB  dist/arm-appinsights.min.js.map                                    
    [npmPack] npm notice 829B    esm/operations/componentAvailableFeatures.d.ts.map                 
    [npmPack] npm notice 1.1kB   esm/operations/componentAvailableFeatures.js.map                   
    [npmPack] npm notice 250B    esm/models/componentAvailableFeaturesMappers.d.ts.map              
    [npmPack] npm notice 263B    esm/models/componentAvailableFeaturesMappers.js.map                
    [npmPack] npm notice 1.4kB   esm/operations/componentCurrentBillingFeatures.d.ts.map            
    [npmPack] npm notice 1.8kB   esm/operations/componentCurrentBillingFeatures.js.map              
    [npmPack] npm notice 247B    esm/models/componentCurrentBillingFeaturesMappers.d.ts.map         
    [npmPack] npm notice 260B    esm/models/componentCurrentBillingFeaturesMappers.js.map           
    [npmPack] npm notice 833B    esm/operations/componentFeatureCapabilities.d.ts.map               
    [npmPack] npm notice 1.1kB   esm/operations/componentFeatureCapabilities.js.map                 
    [npmPack] npm notice 228B    esm/models/componentFeatureCapabilitiesMappers.d.ts.map            
    [npmPack] npm notice 241B    esm/models/componentFeatureCapabilitiesMappers.js.map              
    [npmPack] npm notice 2.4kB   esm/operations/componentLinkedStorageAccountsOperations.d.ts.map   
    [npmPack] npm notice 3.2kB   esm/operations/componentLinkedStorageAccountsOperations.js.map     
    [npmPack] npm notice 478B    esm/models/componentLinkedStorageAccountsOperationsMappers.d.ts.map
    [npmPack] npm notice 491B    esm/models/componentLinkedStorageAccountsOperationsMappers.js.map  
    [npmPack] npm notice 817B    esm/operations/componentQuotaStatus.d.ts.map                       
    [npmPack] npm notice 1.1kB   esm/operations/componentQuotaStatus.js.map                         
    [npmPack] npm notice 212B    esm/models/componentQuotaStatusMappers.d.ts.map                    
    [npmPack] npm notice 225B    esm/models/componentQuotaStatusMappers.js.map                      

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 14, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 5ca1949 with merge commit e354da0. SDK Automation 13.0.17.20200909.5
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.ApplicationInsights [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 15 Sep 2020 02:23:13 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0440:512E:2A0B8D4:4791A3F:5F602591","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 14, 2020

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 5ca1949 with merge commit e354da0. SDK Automation 13.0.17.20200909.5
    • ️✔️sdk/applicationinsights/mgmt-v2015_05_01 [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 15 Sep 2020 02:23:22 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0403:2BD3:8CC8B36:AA063B8:5F60259A","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 14, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 5ca1949 with merge commit e354da0. SDK Automation 13.0.17.20200909.5
    • ⚠️azure-mgmt-applicationinsights [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-applicationinsights
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-applicationinsights
      [after_scripts|python] INFO:__main__:Default API version will be: v2020_03_01_preview
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 15 Sep 2020 02:21:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:6057:25CC7A2:40CE8D1:5F60251E","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 19.419% size of original (original: 79805 chars, delta: 15497 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model AzureResourceProperties has a new parameter system_data
      [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter ingestion_mode
      [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter la_migration_date
      [ChangeLog]   - Model OperationDisplay has a new parameter description
      [ChangeLog]   - Model Operation has a new parameter origin
      [ChangeLog]   - Model Operation has a new parameter is_data_action
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery has a new parameter system_data
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery has a new parameter tags
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery has a new parameter log_analytics_query_pack_query_id
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery has a new parameter properties
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery has a new parameter related
      [ChangeLog]   - Model Workbook has a new parameter source_id
      [ChangeLog]   - Added operation QueriesOperations.update
      [ChangeLog]   - Added operation QueriesOperations.search
      [ChangeLog]   - Added operation group MyWorkbooksOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Operation QueriesOperations.get has a new signature
      [ChangeLog]   - Operation QueriesOperations.delete has a new signature
      [ChangeLog]   - Operation QueriesOperations.put has a new signature
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery no longer has parameter categories
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery no longer has parameter labels
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery no longer has parameter resource_types
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery no longer has parameter linked_resource_id
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery no longer has parameter query_id
      [ChangeLog]   - Model LogAnalyticsQueryPackQuerySearchProperties has a new signature

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 14, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 14, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 14, 2020

    azure-resource-manager-schemas - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 5ca1949 with merge commit e354da0. Schema Automation 13.0.17.20200909.5
    • ⚠️applicationinsights [View full logs]  [Release Schema Changes]
        AzureResourceSchema has no registered package commands.
        Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 15 Sep 2020 02:20:32 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0403:5EC2:200D4E0:37C9B8A:5F6024F0","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @yves-chan
      Copy link
      Contributor Author

      yves-chan commented Sep 15, 2020

      We were missing a 'sourceId' property in the schema but it was flagged as a breaking change. From our conversation before, no one was really using this API as the paths were broken, so even though its 'breaking change' it does not affect any customers yet

      @@ -350,8 +350,7 @@
      "required": [
      "displayName",
      "category",
      "serializedData",
      "userId"
      Copy link
      Contributor

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      why is this one required and readonly?

      Copy link
      Contributor Author

      @yves-chan yves-chan Sep 15, 2020

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      thanks, userId is actually not required at all, I removed this

      @mmyyrroonn mmyyrroonn added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 15, 2020
      @mmyyrroonn
      Copy link
      Contributor

      /azp run

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 3 pipeline(s).

      @mmyyrroonn mmyyrroonn merged commit e354da0 into Azure:master Sep 15, 2020
      nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
      * fix schema
      
      * fix schema 2
      
      * remove optional from description
      
      * remove required sourceId
      
      Co-authored-by: O Yves Chan <[email protected]>
      iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 14, 2020
      …into formrecognizer_regeneration
      
      * 'master' of https://github.com/Azure/azure-rest-api-specs: (21 commits)
        [Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.HealthcareApis-2020-03-15' to public (Azure#10757)
        added new api version (Azure#10784)
        updated apispec (Azure#10719)
        Bump up version number for "old" preview api (Azure#10768)
        [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (Azure#10699)
        [ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. (Azure#10487)
        Update provisioningStatus field name for assignment (Azure#10754)
        [Microsoft.ApiManagement][2019-12-01] Content management resources: Collapsed the reference to metadata. (Azure#10755)
        Add Metrics Advisor API Properties. (Azure#10722)
        Remove LiveVideoAnalytics Swagger and samples from Azure repo, as this should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796)
        Update keys.json (Azure#10495)
        Add new API version 2020-09-01 (Azure#10737)
        Corrected Examples for Resource Mover to generate documentation examp… (Azure#10791)
        Add support for filter by deviceId (Azure#10771)
        Update openapi-authoring-automated-guidelines.md (Azure#10606)
        Adding request body for listcredential for Microsoft.Kubernetes (Azure#10766)
        Add new resource to Microsoft.Sql "ServerTrustGroup". (Azure#10705)
        add alias for auto_rev_minor_version to fix az CLI linter error (Azure#10789)
        Update workbooks api to include sourceId (Azure#10781)
        [NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (Azure#10753)
        ...
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      2 participants