-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix #10753
Merged
ruowan
merged 8 commits into
Azure:master
from
audunn:ANF-6195-SwaggerRESTAPI-To2020-06-01-Bugfix
Sep 15, 2020
Merged
[NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix #10753
ruowan
merged 8 commits into
Azure:master
from
audunn:ANF-6195-SwaggerRESTAPI-To2020-06-01-Bugfix
Sep 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ANF-6195-SwaggerRESTAPI-To2020-06-01-Bugfix
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
Rule | Message |
---|---|
1034 - AddedRequiredProperty |
The new version has new required property 'snapshotsToKeep' that was not found in the old version. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L4233:7 |
1034 - AddedRequiredProperty |
The new version has new required property 'snapshotsToKeep' that was not found in the old version. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L4200:7 |
1034 - AddedRequiredProperty |
The new version has new required property 'minute' that was not found in the old version. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L4150:7 |
1034 - AddedRequiredProperty |
The new version has new required property 'usedBytes' that was not found in the old version. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L4150:7 |
1034 - AddedRequiredProperty |
The new version has new required property 'snapshotsToKeep' that was not found in the old version. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L4172:7 |
1034 - AddedRequiredProperty |
The new version has new required property 'hour' that was not found in the old version. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L4172:7 |
1034 - AddedRequiredProperty |
The new version has new required property 'minute' that was not found in the old version. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L4172:7 |
1034 - AddedRequiredProperty |
The new version has new required property 'usedBytes' that was not found in the old version. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L4172:7 |
1034 - AddedRequiredProperty |
The new version has new required property 'snapshotsToKeep' that was not found in the old version. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L4150:7 |
1034 - AddedRequiredProperty |
The new version has new required property 'day' that was not found in the old version. New: Microsoft.NetApp/stable/2020-06-01/netapp.json#L4200:7 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
Trenton Generation - Release
|
This was referenced Sep 10, 2020
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 10, 2020
This was referenced Sep 10, 2020
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@audunn If no customer impact, I will label it with approvedBreakingChange. |
@jianyexi Could we add a new linter rule to check this issue? Swagger items could be set in array data type only. |
@ruowan there should not be customer impact. |
ruowan
added
the
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
label
Sep 15, 2020
ruowan
approved these changes
Sep 15, 2020
This was referenced Sep 15, 2020
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
* Fix snapshot snapshotPolicyProperties * Fix linter issue, prettier * one more pretty * param in example * remove param in example * Remove whitespace * Remove valiation on readonly properties Co-authored-by: Audunn Baldvinsson <[email protected]>
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Oct 14, 2020
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (21 commits) [Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.HealthcareApis-2020-03-15' to public (Azure#10757) added new api version (Azure#10784) updated apispec (Azure#10719) Bump up version number for "old" preview api (Azure#10768) [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (Azure#10699) [ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. (Azure#10487) Update provisioningStatus field name for assignment (Azure#10754) [Microsoft.ApiManagement][2019-12-01] Content management resources: Collapsed the reference to metadata. (Azure#10755) Add Metrics Advisor API Properties. (Azure#10722) Remove LiveVideoAnalytics Swagger and samples from Azure repo, as this should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796) Update keys.json (Azure#10495) Add new API version 2020-09-01 (Azure#10737) Corrected Examples for Resource Mover to generate documentation examp… (Azure#10791) Add support for filter by deviceId (Azure#10771) Update openapi-authoring-automated-guidelines.md (Azure#10606) Adding request body for listcredential for Microsoft.Kubernetes (Azure#10766) Add new resource to Microsoft.Sql "ServerTrustGroup". (Azure#10705) add alias for auto_rev_minor_version to fix az CLI linter error (Azure#10789) Update workbooks api to include sourceId (Azure#10781) [NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (Azure#10753) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
LintRuleCandidate
Lint Rule Candidate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
This is a bugfix for the NetAppFiles API to address an issue in SDK generation where snapshotPolicy schedule objects, hourly- daily- weeklySchedule were presented as objects instead of actual classes in generated SDK such as .net.
This would make it more cumbersome for SDK users to consume the objects than it needs to be.
Note the feature is in preview. the spec is new-ly created and generated SDK's have not been released yet, may be considered breaking but addresses a bug that we would like to fix.
Before
After
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.