Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 #10699

Conversation

paornela
Copy link
Contributor

@paornela paornela commented Sep 4, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 4, 2020

[Staging] Swagger Validation Report

BreakingChange: 9 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.CostManagement/exports' removed or restructured?
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1101:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}' removed or restructured?
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1155:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}/run' removed or restructured?
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1334:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}/runHistory' removed or restructured?
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1388:5
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Export' removed or renamed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1133:3
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1477:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ExportProperties' removed or renamed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1133:3
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1477:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ExportSchedule' removed or renamed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1133:3
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1477:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ExportRecurrencePeriod' removed or renamed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1133:3
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1477:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'exportNameParameter' removed or renamed?
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L2402:3
Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L2996:3
LintDiff: 1 Errors, 0 Warnings [Detail] [Expand]
Rule Message
R4005 - UniqueXmsEnumName Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique. The duplicate x-ms-enum name is operatortype
New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.exports.json#L648
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e6c45ce with merge commit 1b98adc. SDK Automation 13.0.17.20200909.5
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.CostManagement [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:27:12 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:5038:305E93:709FF2:5F618610","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

Azure CLI Extension Generation - Release

  • Installation instruction for service costmanagement [Preview Changes]
    curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/10699/azure-cli-extensions/costmanagement/costmanagement-0.1.0-py3-none-any.whl" -o costmanagement-0.1.0-py3-none-any.whl
    az extension add --source=costmanagement-0.1.0-py3-none-any.whl
    
️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e6c45ce with merge commit 1b98adc. Azure CLI Automation 13.0.17.20200909.5
    Only show 100 items here, please refer to log for details.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigTimePeriod' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigDataset' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigDatasetConfiguration' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigAggregation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigSorting' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigGrouping' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ReportConfigComparisonExpression' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ProxyResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DismissAlertPayload' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ForecastDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ForecastDataset' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryTimePeriod' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryDataset' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryDatasetConfiguration' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryAggregation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryGrouping' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QueryComparisonExpression' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    [AutoRest] WARNING (Modeler/MissingType): The schema 'AlertProperties-details-resourceGroupFilterItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (Modeler/MissingType): The schema 'AlertProperties-details-resourceFilterItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (Modeler/MissingType): The schema 'AlertProperties-details-meterFilterItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (Modeler/MissingType): The schema 'QueryProperties-rows-itemsItem' has no type or format information whatsoever. Location:
    [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    [AutoRest] 
    [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
    [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
    [AutoRest] --------------------------------------------------------
    [AutoRest]   test-scenario:
    [AutoRest]     - name: /Alerts/get/BillingAccountAlerts
    [AutoRest]     - name: /Alerts/get/BillingProfileAlerts
    [AutoRest]     - name: /Alerts/get/DepartmentAlerts
    [AutoRest]     - name: /Alerts/get/EnrollmentAccountAlerts
    [AutoRest]     - name: /Alerts/get/ExternalBillingAccountAlerts
    [AutoRest]     - name: /Alerts/get/ExternalSubscriptionAlerts
    [AutoRest]     - name: /Alerts/get/InvoiceSectionAlerts
    [AutoRest]     - name: /Alerts/get/ResourceGroupAlerts
    [AutoRest]     - name: /Alerts/get/ResourceGroupAlerts
    [AutoRest]     - name: /Alerts/get/SubscriptionAlerts
    [AutoRest]     - name: /Alerts/get/SubscriptionAlerts
    [AutoRest]     - name: /Alerts/patch/ResourceGroupAlerts
    [AutoRest]     - name: /Alerts/patch/SubscriptionAlerts
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/BillingProfileDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/BillingProfileDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/BillingProfileDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/CustomerDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/CustomerDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/CustomerDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/DepartmentDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/DepartmentDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/DepartmentDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/EnrollmentAccountDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/ExternalBillingAccountDimensionList
    [AutoRest]     - name: /Dimensions/get/ExternalSubscriptionDimensionList
    [AutoRest]     - name: /Dimensions/get/InvoiceSectionDimensionsList-Modern
    [AutoRest]     - name: /Dimensions/get/InvoiceSectionDimensionsListExpandAndTop-Modern
    [AutoRest]     - name: /Dimensions/get/InvoiceSectionDimensionsListWithFilter-Modern
    [AutoRest]     - name: /Dimensions/get/ManagementGroupDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/ManagementGroupDimensionsListExpandAndTop-Legacy
    [AutoRest]     - name: /Dimensions/get/ManagementGroupDimensionsListWithFilter-Legacy
    [AutoRest]     - name: /Dimensions/get/ResourceGroupDimensionsList-Legacy
    [AutoRest]     - name: /Dimensions/get/SubscriptionDimensionsList-Legacy
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByBillingAccount
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByDepartment
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByEnrollmentAccount
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByManagementGroup
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateByResourceGroup
    [AutoRest]     - name: /Exports/put/ExportCreateOrUpdateBySubscription
    [AutoRest]     - name: /Exports/get/ExportGetByBillingAccount
    [AutoRest]     - name: /Exports/get/ExportGetByDepartment
    [AutoRest]     - name: /Exports/get/ExportGetByEnrollmentAccount
    [AutoRest]     - name: /Exports/get/ExportGetByManagementGroup
    [AutoRest]     - name: /Exports/get/ExportGetByResourceGroup
    [AutoRest]     - name: /Exports/get/ExportGetBySubscription
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByBillingAccount
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByDepartment
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByEnrollmentAccount
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByManagementGroup
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetByResourceGroup
    [AutoRest]     - name: /Exports/get/ExportRunHistoryGetBySubscription
    [AutoRest]     - name: /Exports/get/ExportsGetByBillingAccount
    [AutoRest]     - name: /Exports/get/ExportsGetByDepartment
    [AutoRest]     - name: /Exports/get/ExportsGetByEnrollmentAccount
    [AutoRest]     - name: /Exports/get/ExportsGetByManagementGroup
    [AutoRest]     - name: /Exports/get/ExportsGetByResourceGroup
  • ️✔️costmanagement [View full logs]  [Release Azure CLI Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:24:10 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C0:13D23:B76F2C3:DCDAEAB:5F61855A","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from e6c45ce with merge commit 1b98adc. SDK Automation 13.0.17.20200909.5
  • ⚠️azure-mgmt-costmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-costmanagement
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-costmanagement
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:24:53 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:2981:198FB15:387CA5B:5F618585","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 64.270% size of original (original: 34282 chars, delta: 22033 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model Export has a new parameter next_run_time_estimate
    [ChangeLog]   - Model Export has a new parameter run_history
    [ChangeLog]   - Model Export has a new parameter e_tag
    [ChangeLog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
    [ChangeLog]   - Model CommonExportProperties has a new parameter run_history
    [ChangeLog]   - Model ExportExecution has a new parameter error
    [ChangeLog]   - Added operation DimensionsOperations.by_external_cloud_provider_type
    [ChangeLog]   - Added operation QueryOperations.usage_by_external_cloud_provider_type
    [ChangeLog]   - Added operation group ForecastOperations
    [ChangeLog]   - Added operation group AlertsOperations
    [ChangeLog]   - Added operation group ViewsOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Operation ExportsOperations.get has a new signature
    [ChangeLog]   - Operation ExportsOperations.list has a new signature
    [ChangeLog]   - Model Export no longer has parameter tags

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 4, 2020

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from e6c45ce with merge commit 1b98adc. Schema Automation 13.0.17.20200909.5
    [AutoRest] WARNING: Found duplicate definition for variable-named type Microsoft.CostManagement/reports. Skipping definition with path '/providers/Microsoft.Billing/departments/{departmentId}/providers/Microsoft.CostManagement/reports/{reportName}'.
    [AutoRest] WARNING: Found duplicate definition for variable-named type Microsoft.CostManagement/reports. Using definition with path '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/Microsoft.CostManagement/reports/{reportName}'.
  • ⚠️cost-management [View full logs]  [Release Schema Changes]
      AzureResourceSchema has no registered package commands.
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 16 Sep 2020 03:25:10 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0782:561B:3772CE:474DEB:5F618596","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @paornela
    Copy link
    Contributor Author

    paornela commented Sep 4, 2020

    /openapi pipeline

    @openapi-sdkautomation
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    @openapi-pipeline-app
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation or run instead.

    @paornela
    Copy link
    Contributor Author

    paornela commented Sep 4, 2020

    /openapi pipeline

    @openapi-pipeline-app
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation or run instead.

    @openapi-sdkautomation
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    @paornela
    Copy link
    Contributor Author

    paornela commented Sep 4, 2020

    /openapi pipeline

    @openapi-sdkautomation
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation instead.

    @openapi-pipeline-app
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation or run instead.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-pipeline-app
    Copy link

    /openapi pipeline

    Unrecognized OpenAPI bot command (pipeline).
    Try sdkautomation or run instead.

    @paornela paornela marked this pull request as ready for review September 8, 2020 16:19
    @paornela paornela requested a review from InsanePup September 8, 2020 16:19
    @paornela paornela added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR labels Sep 8, 2020
    @paornela paornela requested review from InsanePup and removed request for InsanePup September 9, 2020 23:34
    @chiragg4u
    Copy link
    Contributor

    Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued.

    @chiragg4u chiragg4u removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 11, 2020
    @chiragg4u
    Copy link
    Contributor

    Only change is spliting the file, no ARM API review required, Removing the WaitForARMFeedback tag.

    @raych1
    Copy link
    Member

    raych1 commented Sep 14, 2020

    @paornela , can you resolve the lintDiff failures about duplicate Enum name defined?

    @raych1 raych1 added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Sep 14, 2020
    @raych1
    Copy link
    Member

    raych1 commented Sep 14, 2020

    Hi @changlong-liu , could you review the breaking change in python SDK? Are they caused by this PR change?

    @changlong-liu
    Copy link
    Member

    Hi @changlong-liu Changlong Liu FTE , could you review the breaking change in python SDK? Are they caused by this PR change?

    Hi @raych1 , the breaking changes don't come from this PR.

    @paornela
    Copy link
    Contributor Author

    @raych1 I checked and the lintDiff failures about duplicate Enum name defined are incorrect as far as I can tell. The changes on this PR do not add a type with the same enum, so I'm not sure why that error is showing up. In the file costmanagment.exports.json, there is only one enum type operationType. In costmanagement.json, there are 2 operationType, but those were not implemented through this PR. Please provide guidance on how to proceed.

    @raych1
    Copy link
    Member

    raych1 commented Sep 14, 2020

    @raych1 I checked and the lintDiff failures about duplicate Enum name defined are incorrect as far as I can tell. The changes on this PR do not add a type with the same enum, so I'm not sure why that error is showing up. In the file costmanagment.exports.json, there is only one enum type operationType. In costmanagement.json, there are 2 operationType, but those were not implemented through this PR. Please provide guidance on how to proceed.

    @paornela , it doesn't allow the same enum name across multiple swagger files defined in a tag in readme.md.

    @paornela
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @paornela
    Copy link
    Contributor Author

    @raych1 I checked and the lintDiff failures about duplicate Enum name defined are incorrect as far as I can tell. The changes on this PR do not add a type with the same enum, so I'm not sure why that error is showing up. In the file costmanagment.exports.json, there is only one enum type operationType. In costmanagement.json, there are 2 operationType, but those were not implemented through this PR. Please provide guidance on how to proceed.

    @paornela , it doesn't allow the same enum name across multiple swagger files defined in a tag in readme.md.

    @raych1 If this were the case, wouldn't it have flagged ExportType, TimeframeType, and more that have the same enum name across both swagger files? Also, when I re-ran the validation checks on OpenApi Hub for this latest commit, there are no lint checker errors.

    @jianyexi
    Copy link
    Contributor

    @raych1 I checked and the lintDiff failures about duplicate Enum name defined are incorrect as far as I can tell. The changes on this PR do not add a type with the same enum, so I'm not sure why that error is showing up. In the file costmanagment.exports.json, there is only one enum type operationType. In costmanagement.json, there are 2 operationType, but those were not implemented through this PR. Please provide guidance on how to proceed.

    @paornela , it doesn't allow the same enum name across multiple swagger files defined in a tag in readme.md.

    @raych1 If this were the case, wouldn't it have flagged ExportType, TimeframeType, and more that have the same enum name across both swagger files? Also, when I re-ran the validation checks on OpenApi Hub for this latest commit, there are no lint checker errors.

    You can't have the same enum name with different definition, The reason is the operationType here has two option values while others have only one option

    @paornela
    Copy link
    Contributor Author

    @raych1 I checked and the lintDiff failures about duplicate Enum name defined are incorrect as far as I can tell. The changes on this PR do not add a type with the same enum, so I'm not sure why that error is showing up. In the file costmanagment.exports.json, there is only one enum type operationType. In costmanagement.json, there are 2 operationType, but those were not implemented through this PR. Please provide guidance on how to proceed.

    @paornela , it doesn't allow the same enum name across multiple swagger files defined in a tag in readme.md.

    @raych1 If this were the case, wouldn't it have flagged ExportType, TimeframeType, and more that have the same enum name across both swagger files? Also, when I re-ran the validation checks on OpenApi Hub for this latest commit, there are no lint checker errors.

    You can't have the same enum name with different definition, The reason is the operationType here has two option values while others have only one option

    @jianyexi The goal of this PR is to separate the existing Swagger costmanagement.json into 2 Swagger files without breaking anything. I see what you're saying regarding the two different definitions, but the duplicate enum name "operatorType" already existed in the original swagger before this PR as you can see here. Since this PR did not introduce this change, I am not sure why it is blocking validation here.

    @raych1
    Copy link
    Member

    raych1 commented Sep 16, 2020

    @raych1 I checked and the lintDiff failures about duplicate Enum name defined are incorrect as far as I can tell. The changes on this PR do not add a type with the same enum, so I'm not sure why that error is showing up. In the file costmanagment.exports.json, there is only one enum type operationType. In costmanagement.json, there are 2 operationType, but those were not implemented through this PR. Please provide guidance on how to proceed.

    @paornela , it doesn't allow the same enum name across multiple swagger files defined in a tag in readme.md.

    @raych1 If this were the case, wouldn't it have flagged ExportType, TimeframeType, and more that have the same enum name across both swagger files? Also, when I re-ran the validation checks on OpenApi Hub for this latest commit, there are no lint checker errors.

    You can't have the same enum name with different definition, The reason is the operationType here has two option values while others have only one option

    @jianyexi The goal of this PR is to separate the existing Swagger costmanagement.json into 2 Swagger files without breaking anything. I see what you're saying regarding the two different definitions, but the duplicate enum name "operatorType" already existed in the original swagger before this PR as you can see here. Since this PR did not introduce this change, I am not sure why it is blocking validation here.

    @paornela , the lintDiff failure isn't introduced by your change in this PR. It exists in current swagger file. Two values are different for this same enum name type. e.g. value 1 and value 2
    Regard to this PR, I will approve and merge it. However, can you create a task in backlog to fix this conflict issue in the future PR?

    @raych1
    Copy link
    Member

    raych1 commented Sep 16, 2020

    /azp run automation - sdk

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @raych1 raych1 added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Sep 16, 2020
    @raych1 raych1 merged commit 1b98adc into Azure:master Sep 16, 2020
    nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
    …rsion stable/2019-11-01 (Azure#10699)
    
    * Created Separate Swagger for Exports
    
    * add exports swagger to readme.md
    iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 14, 2020
    …into formrecognizer_regeneration
    
    * 'master' of https://github.com/Azure/azure-rest-api-specs: (21 commits)
      [Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.HealthcareApis-2020-03-15' to public (Azure#10757)
      added new api version (Azure#10784)
      updated apispec (Azure#10719)
      Bump up version number for "old" preview api (Azure#10768)
      [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (Azure#10699)
      [ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. (Azure#10487)
      Update provisioningStatus field name for assignment (Azure#10754)
      [Microsoft.ApiManagement][2019-12-01] Content management resources: Collapsed the reference to metadata. (Azure#10755)
      Add Metrics Advisor API Properties. (Azure#10722)
      Remove LiveVideoAnalytics Swagger and samples from Azure repo, as this should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796)
      Update keys.json (Azure#10495)
      Add new API version 2020-09-01 (Azure#10737)
      Corrected Examples for Resource Mover to generate documentation examp… (Azure#10791)
      Add support for filter by deviceId (Azure#10771)
      Update openapi-authoring-automated-guidelines.md (Azure#10606)
      Adding request body for listcredential for Microsoft.Kubernetes (Azure#10766)
      Add new resource to Microsoft.Sql "ServerTrustGroup". (Azure#10705)
      add alias for auto_rev_minor_version to fix az CLI linter error (Azure#10789)
      Update workbooks api to include sourceId (Azure#10781)
      [NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (Azure#10753)
      ...
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants