-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 #10699
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 #10699
Conversation
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.CostManagement/exports' removed or restructured? Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1101:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}' removed or restructured? Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1155:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}/run' removed or restructured? Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1334:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.CostManagement/exports/{exportName}/runHistory' removed or restructured? Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1388:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'Export' removed or renamed? New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1133:3 Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1477:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ExportProperties' removed or renamed? New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1133:3 Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1477:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ExportSchedule' removed or renamed? New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1133:3 Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1477:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ExportRecurrencePeriod' removed or renamed? New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1133:3 Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L1477:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'exportNameParameter' removed or renamed? New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L2402:3 Old: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L2996:3 |
️❌
LintDiff: 1 Errors, 0 Warnings [Detail] [Expand]
❌
Rule | Message |
---|---|
R4005 - UniqueXmsEnumName |
Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique. The duplicate x-ms-enum name is operatortype New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.exports.json#L648 |
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
/openapi pipeline |
Unrecognized OpenAPI bot command (pipeline). |
Unrecognized OpenAPI bot command (pipeline). |
/openapi pipeline |
Unrecognized OpenAPI bot command (pipeline). |
Unrecognized OpenAPI bot command (pipeline). |
/openapi pipeline |
Unrecognized OpenAPI bot command (pipeline). |
Unrecognized OpenAPI bot command (pipeline). |
Azure Pipelines successfully started running 1 pipeline(s). |
Unrecognized OpenAPI bot command (pipeline). |
Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued. |
Only change is spliting the file, no ARM API review required, Removing the WaitForARMFeedback tag. |
@paornela , can you resolve the lintDiff failures about duplicate Enum name defined? |
Hi @changlong-liu , could you review the breaking change in python SDK? Are they caused by this PR change? |
Hi @raych1 , the breaking changes don't come from this PR. |
@raych1 I checked and the lintDiff failures about duplicate Enum name defined are incorrect as far as I can tell. The changes on this PR do not add a type with the same enum, so I'm not sure why that error is showing up. In the file costmanagment.exports.json, there is only one enum type operationType. In costmanagement.json, there are 2 operationType, but those were not implemented through this PR. Please provide guidance on how to proceed. |
@paornela , it doesn't allow the same enum name across multiple swagger files defined in a tag in readme.md. |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
@raych1 If this were the case, wouldn't it have flagged ExportType, TimeframeType, and more that have the same enum name across both swagger files? Also, when I re-ran the validation checks on OpenApi Hub for this latest commit, there are no lint checker errors. |
You can't have the same enum name with different definition, The reason is the operationType here has two option values while others have only one option |
@jianyexi The goal of this PR is to separate the existing Swagger costmanagement.json into 2 Swagger files without breaking anything. I see what you're saying regarding the two different definitions, but the duplicate enum name "operatorType" already existed in the original swagger before this PR as you can see here. Since this PR did not introduce this change, I am not sure why it is blocking validation here. |
@paornela , the lintDiff failure isn't introduced by your change in this PR. It exists in current swagger file. Two values are different for this same enum name type. e.g. value 1 and value 2 |
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
…rsion stable/2019-11-01 (Azure#10699) * Created Separate Swagger for Exports * add exports swagger to readme.md
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (21 commits) [Hub Generated] Move private branch 'dev-healthcareapis-Microsoft.HealthcareApis-2020-03-15' to public (Azure#10757) added new api version (Azure#10784) updated apispec (Azure#10719) Bump up version number for "old" preview api (Azure#10768) [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (Azure#10699) [ASR][V2A-RCM] Add new properties and provider specific models for V2A RCM. (Azure#10487) Update provisioningStatus field name for assignment (Azure#10754) [Microsoft.ApiManagement][2019-12-01] Content management resources: Collapsed the reference to metadata. (Azure#10755) Add Metrics Advisor API Properties. (Azure#10722) Remove LiveVideoAnalytics Swagger and samples from Azure repo, as this should not be public, will recheckin this to a branch on azure-rest-api-specs-pr repo, and maintain it in that branch. (Azure#10796) Update keys.json (Azure#10495) Add new API version 2020-09-01 (Azure#10737) Corrected Examples for Resource Mover to generate documentation examp… (Azure#10791) Add support for filter by deviceId (Azure#10771) Update openapi-authoring-automated-guidelines.md (Azure#10606) Adding request body for listcredential for Microsoft.Kubernetes (Azure#10766) Add new resource to Microsoft.Sql "ServerTrustGroup". (Azure#10705) add alias for auto_rev_minor_version to fix az CLI linter error (Azure#10789) Update workbooks api to include sourceId (Azure#10781) [NetAppFiles]Anf 6195 swagger restapi to2020 06 01 bugfix (Azure#10753) ...
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.