-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node 18 as a hidden & preview function app stack #6752
Conversation
cc @hossam-nasr, @alrod, @lilyjma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM-- isHidden and isPreview look good, the numbers look right for the node and host versions, defaulting to windows also looks right. That's the extent of my review given what I know. I could've missed something.
(Curious why remoteDedebuggingSupported is false)
Well, first of all I'm mostly just copying what we have for Node 16. Secondly, setting it to @joechung-msft @takyyon this should be good to merge. Anything else we need to do? Our support under the covers in Azure hasn't fully rolled out yet, but I think that's fine considering this will be hidden. |
@ejizba Please rebase your branch with base. Once its upto date and you don't have permissions to push, I can help merge it in. |
@joechung-msft @takyyon @shimedh thank you! Quick question: How much lead time do we generally need in terms of merging a PR and having it fully roll out? Asking for the next PR when we want to unhide this. |
Syncing offline! |
Related to Azure/azure-functions-nodejs-worker#562