Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 18 as a hidden & preview function app stack #6752

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented Jul 6, 2022

@ejizba
Copy link
Contributor Author

ejizba commented Jul 6, 2022

cc @hossam-nasr, @alrod, @lilyjma

Copy link
Contributor

@lilyjma lilyjma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM-- isHidden and isPreview look good, the numbers look right for the node and host versions, defaulting to windows also looks right. That's the extent of my review given what I know. I could've missed something.

(Curious why remoteDedebuggingSupported is false)

@ejizba
Copy link
Contributor Author

ejizba commented Jul 14, 2022

(Curious why remoteDedebuggingSupported is false)

Well, first of all I'm mostly just copying what we have for Node 16. Secondly, setting it to false is accurate IMO (although I don't know if anyone even uses the remoteDedebuggingSupported flag). There's some experimental support in VS Code, but it's pretty limited (only linux dedicated plans). A bit more context here: microsoft/vscode-azurefunctions#1344

@joechung-msft @takyyon this should be good to merge. Anything else we need to do? Our support under the covers in Azure hasn't fully rolled out yet, but I think that's fine considering this will be hidden.

@shimedh
Copy link
Contributor

shimedh commented Jul 14, 2022

@ejizba Please rebase your branch with base. Once its upto date and you don't have permissions to push, I can help merge it in.

@takyyon takyyon enabled auto-merge (squash) July 15, 2022 13:40
@takyyon takyyon merged commit 54f6138 into Azure:dev Jul 15, 2022
@ejizba
Copy link
Contributor Author

ejizba commented Jul 15, 2022

@joechung-msft @takyyon @shimedh thank you!

Quick question: How much lead time do we generally need in terms of merging a PR and having it fully roll out? Asking for the next PR when we want to unhide this.

@ejizba ejizba deleted the ej/node18 branch July 15, 2022 16:40
@takyyon
Copy link
Contributor

takyyon commented Jul 15, 2022

@joechung-msft @takyyon @shimedh thank you!

Quick question: How much lead time do we generally need in terms of merging a PR and having it fully roll out? Asking for the next PR when we want to unhide this.

@joechung-msft @takyyon @shimedh thank you!

Quick question: How much lead time do we generally need in terms of merging a PR and having it fully roll out? Asking for the next PR when we want to unhide this.

@joechung-msft @takyyon @shimedh thank you!

Quick question: How much lead time do we generally need in terms of merging a PR and having it fully roll out? Asking for the next PR when we want to unhide this.

Syncing offline!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants