Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 18 as a hidden & preview function app stack #6752

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Add Node 18 as a hidden & preview function app stack #6752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a40abd0
Add Node 18 as a hidden & preview function app stack
ejizba Jul 6, 2022
8472bf9
remove false flag
ejizba Jul 11, 2022
e2c28c5
Merge branch 'dev' into ej/node18
takyyon Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 43 additions & 2 deletions server/src/stacks/2020-05-01/stacks/function-app-stacks/Node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,47 @@ export const nodeStack: FunctionAppStack = {
displayText: 'Node.js',
value: 'node',
versions: [
{
sortOrder: 4,
displayText: '18',
value: '18',
isDefault: false,
supportedPlatforms: [
{
sortOrder: 0,
os: 'windows',
isPreview: true,
isDeprecated: false,
isHidden: true,
applicationInsightsEnabled: true,
runtimeVersion: '~18',
appSettingsDictionary: {
FUNCTIONS_WORKER_RUNTIME: 'node',
WEBSITE_NODE_DEFAULT_VERSION: '~18',
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: true,
netFrameworkVersion: 'v6.0',
},
},
{
sortOrder: 1,
os: 'linux',
isPreview: true,
isDeprecated: false,
isHidden: true,
applicationInsightsEnabled: true,
runtimeVersion: 'Node|18',
appSettingsDictionary: {
FUNCTIONS_WORKER_RUNTIME: 'node',
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: false,
linuxFxVersion: 'Node|18',
},
},
],
},
{
sortOrder: 0,
displayText: '16',
Expand All @@ -26,7 +67,7 @@ export const nodeStack: FunctionAppStack = {
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: true,
netFrameworkVersion: 'v6.0',
}
},
},
{
sortOrder: 1,
Expand Down Expand Up @@ -159,6 +200,6 @@ export const nodeStack: FunctionAppStack = {
},
},
],
}
},
],
};
57 changes: 56 additions & 1 deletion server/src/stacks/2020-06-01/stacks/function-app-stacks/Node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,61 @@ export const nodeStack: FunctionAppStack = {
value: 'node',
preferredOs: 'windows',
majorVersions: [
{
displayText: 'Node.js 18',
value: '18',
minorVersions: [
{
displayText: 'Node.js 18',
value: '18 LTS',
stackSettings: {
windowsRuntimeSettings: {
runtimeVersion: '~18',
isPreview: true,
isHidden: true,
remoteDebuggingSupported: false,
appInsightsSettings: {
isSupported: true,
},
gitHubActionSettings: {
isSupported: true,
supportedVersion: '18.x',
},
appSettingsDictionary: {
FUNCTIONS_WORKER_RUNTIME: 'node',
WEBSITE_NODE_DEFAULT_VERSION: '~18',
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: true,
netFrameworkVersion: 'v6.0',
},
supportedFunctionsExtensionVersions: ['~4'],
},
linuxRuntimeSettings: {
runtimeVersion: 'Node|18',
isPreview: true,
isHidden: true,
remoteDebuggingSupported: false,
appInsightsSettings: {
isSupported: true,
},
gitHubActionSettings: {
isSupported: true,
supportedVersion: '18.x',
},
appSettingsDictionary: {
FUNCTIONS_WORKER_RUNTIME: 'node',
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: false,
linuxFxVersion: 'Node|18',
},
supportedFunctionsExtensionVersions: ['~4'],
},
},
},
],
},
{
displayText: 'Node.js 16',
value: '16',
Expand All @@ -30,7 +85,7 @@ export const nodeStack: FunctionAppStack = {
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: true,
netFrameworkVersion: 'v6.0'
netFrameworkVersion: 'v6.0',
},
supportedFunctionsExtensionVersions: ['~4'],
},
Expand Down
55 changes: 55 additions & 0 deletions server/src/stacks/2020-10-01/stacks/function-app-stacks/Node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,61 @@ export const nodeStack: FunctionAppStack = {
value: 'node',
preferredOs: 'windows',
majorVersions: [
{
displayText: 'Node.js 18',
value: '18',
minorVersions: [
{
displayText: 'Node.js 18',
value: '18 LTS',
stackSettings: {
windowsRuntimeSettings: {
runtimeVersion: '~18',
isPreview: true,
isHidden: true,
remoteDebuggingSupported: false,
appInsightsSettings: {
isSupported: true,
},
gitHubActionSettings: {
isSupported: true,
supportedVersion: '18.x',
},
appSettingsDictionary: {
FUNCTIONS_WORKER_RUNTIME: 'node',
WEBSITE_NODE_DEFAULT_VERSION: '~18',
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: true,
netFrameworkVersion: 'v6.0',
},
supportedFunctionsExtensionVersions: ['~4'],
},
linuxRuntimeSettings: {
runtimeVersion: 'Node|18',
isPreview: true,
isHidden: true,
remoteDebuggingSupported: false,
appInsightsSettings: {
isSupported: true,
},
gitHubActionSettings: {
isSupported: true,
supportedVersion: '18.x',
},
appSettingsDictionary: {
FUNCTIONS_WORKER_RUNTIME: 'node',
},
siteConfigPropertiesDictionary: {
use32BitWorkerProcess: false,
linuxFxVersion: 'Node|18',
},
supportedFunctionsExtensionVersions: ['~4'],
},
},
},
],
},
{
displayText: 'Node.js 16',
value: '16',
Expand Down
2 changes: 1 addition & 1 deletion server/src/tests/Stacks/2020-05-01/function-app/validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function validateNodeStack(stacks) {
expect(nodeStack.displayText).to.equal('Node.js');
expect(nodeStack.value).to.equal('node');
expect(nodeStack.sortOrder).to.equal(1);
expect(nodeStack.versions.length).to.equal(4);
expect(nodeStack.versions.length).to.equal(5);
expect(nodeStack).to.deep.equal(hardCodedNodeStack);
}

Expand Down
2 changes: 1 addition & 1 deletion server/src/tests/Stacks/2020-06-01/function-app/validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ function validateNodeStack(nodeStack) {
expect(nodeStack.displayText).to.equal('Node.js');
expect(nodeStack.value).to.equal('node');
expect(nodeStack.preferredOs).to.equal('windows');
expect(nodeStack.majorVersions.length).to.equal(6);
expect(nodeStack.majorVersions.length).to.equal(7);
expect(nodeStack).to.deep.equal(hardCodedNodeStack);
}

Expand Down
2 changes: 1 addition & 1 deletion server/src/tests/Stacks/2020-10-01/function-app/validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ function validateNodeStack(nodeStack) {
expect(nodeStack.displayText).to.equal('Node.js');
expect(nodeStack.value).to.equal('node');
expect(nodeStack.preferredOs).to.equal('windows');
expect(nodeStack.majorVersions.length).to.equal(6);
expect(nodeStack.majorVersions.length).to.equal(7);
expect(nodeStack).to.deep.equal(hardCodedNodeStack);
}

Expand Down