Add Node 18 as a hidden & preview function app stack (#6752)

* Add Node 18 as a hidden & preview function app stack * remove false flag Co-authored-by: Krrish Mittal <[email protected]>
Azure · Jul 15, 2022 · 54f6138 · 54f6138
1 parent e1254b7
commit 54f6138
Show file tree

Hide file tree

Showing 6 changed files with 157 additions and 6 deletions.
diff --git a/server/src/stacks/2020-05-01/stacks/function-app-stacks/Node.ts b/server/src/stacks/2020-05-01/stacks/function-app-stacks/Node.ts
@@ -5,6 +5,47 @@ export const nodeStack: FunctionAppStack = {
   displayText: 'Node.js',
   value: 'node',
   versions: [
+    {
+      sortOrder: 4,
+      displayText: '18',
+      value: '18',
+      isDefault: false,
+      supportedPlatforms: [
+        {
+          sortOrder: 0,
+          os: 'windows',
+          isPreview: true,
+          isDeprecated: false,
+          isHidden: true,
+          applicationInsightsEnabled: true,
+          runtimeVersion: '~18',
+          appSettingsDictionary: {
+            FUNCTIONS_WORKER_RUNTIME: 'node',
+            WEBSITE_NODE_DEFAULT_VERSION: '~18',
+          },
+          siteConfigPropertiesDictionary: {
+            use32BitWorkerProcess: true,
+            netFrameworkVersion: 'v6.0',
+          },
+        },
+        {
+          sortOrder: 1,
+          os: 'linux',
+          isPreview: true,
+          isDeprecated: false,
+          isHidden: true,
+          applicationInsightsEnabled: true,
+          runtimeVersion: 'Node|18',
+          appSettingsDictionary: {
+            FUNCTIONS_WORKER_RUNTIME: 'node',
+          },
+          siteConfigPropertiesDictionary: {
+            use32BitWorkerProcess: false,
+            linuxFxVersion: 'Node|18',
+          },
+        },
+      ],
+    },
     {
       sortOrder: 0,
       displayText: '16',
@@ -26,7 +67,7 @@ export const nodeStack: FunctionAppStack = {
           siteConfigPropertiesDictionary: {
             use32BitWorkerProcess: true,
             netFrameworkVersion: 'v6.0',
-          }
+          },
         },
         {
           sortOrder: 1,
@@ -159,6 +200,6 @@ export const nodeStack: FunctionAppStack = {
           },
         },
       ],
-    }
+    },
   ],
 };
diff --git a/server/src/stacks/2020-06-01/stacks/function-app-stacks/Node.ts b/server/src/stacks/2020-06-01/stacks/function-app-stacks/Node.ts
@@ -5,6 +5,61 @@ export const nodeStack: FunctionAppStack = {
   value: 'node',
   preferredOs: 'windows',
   majorVersions: [
+    {
+      displayText: 'Node.js 18',
+      value: '18',
+      minorVersions: [
+        {
+          displayText: 'Node.js 18',
+          value: '18 LTS',
+          stackSettings: {
+            windowsRuntimeSettings: {
+              runtimeVersion: '~18',
+              isPreview: true,
+              isHidden: true,
+              remoteDebuggingSupported: false,
+              appInsightsSettings: {
+                isSupported: true,
+              },
+              gitHubActionSettings: {
+                isSupported: true,
+                supportedVersion: '18.x',
+              },
+              appSettingsDictionary: {
+                FUNCTIONS_WORKER_RUNTIME: 'node',
+                WEBSITE_NODE_DEFAULT_VERSION: '~18',
+              },
+              siteConfigPropertiesDictionary: {
+                use32BitWorkerProcess: true,
+                netFrameworkVersion: 'v6.0',
+              },
+              supportedFunctionsExtensionVersions: ['~4'],
+            },
+            linuxRuntimeSettings: {
+              runtimeVersion: 'Node|18',
+              isPreview: true,
+              isHidden: true,
+              remoteDebuggingSupported: false,
+              appInsightsSettings: {
+                isSupported: true,
+              },
+              gitHubActionSettings: {
+                isSupported: true,
+                supportedVersion: '18.x',
+              },
+              appSettingsDictionary: {
+                FUNCTIONS_WORKER_RUNTIME: 'node',
+              },
+              siteConfigPropertiesDictionary: {
+                use32BitWorkerProcess: false,
+                linuxFxVersion: 'Node|18',
+              },
+              supportedFunctionsExtensionVersions: ['~4'],
+            },
+          },
+        },
+      ],
+    },
     {
       displayText: 'Node.js 16',
       value: '16',
@@ -30,7 +85,7 @@ export const nodeStack: FunctionAppStack = {
               },
               siteConfigPropertiesDictionary: {
                 use32BitWorkerProcess: true,
-                netFrameworkVersion: 'v6.0'
+                netFrameworkVersion: 'v6.0',
               },
               supportedFunctionsExtensionVersions: ['~4'],
             },

diff --git a/server/src/stacks/2020-10-01/stacks/function-app-stacks/Node.ts b/server/src/stacks/2020-10-01/stacks/function-app-stacks/Node.ts
@@ -5,6 +5,61 @@ export const nodeStack: FunctionAppStack = {
   value: 'node',
   preferredOs: 'windows',
   majorVersions: [
+    {
+      displayText: 'Node.js 18',
+      value: '18',
+      minorVersions: [
+        {
+          displayText: 'Node.js 18',
+          value: '18 LTS',
+          stackSettings: {
+            windowsRuntimeSettings: {
+              runtimeVersion: '~18',
+              isPreview: true,
+              isHidden: true,
+              remoteDebuggingSupported: false,
+              appInsightsSettings: {
+                isSupported: true,
+              },
+              gitHubActionSettings: {
+                isSupported: true,
+                supportedVersion: '18.x',
+              },
+              appSettingsDictionary: {
+                FUNCTIONS_WORKER_RUNTIME: 'node',
+                WEBSITE_NODE_DEFAULT_VERSION: '~18',
+              },
+              siteConfigPropertiesDictionary: {
+                use32BitWorkerProcess: true,
+                netFrameworkVersion: 'v6.0',
+              },
+              supportedFunctionsExtensionVersions: ['~4'],
+            },
+            linuxRuntimeSettings: {
+              runtimeVersion: 'Node|18',
+              isPreview: true,
+              isHidden: true,
+              remoteDebuggingSupported: false,
+              appInsightsSettings: {
+                isSupported: true,
+              },
+              gitHubActionSettings: {
+                isSupported: true,
+                supportedVersion: '18.x',
+              },
+              appSettingsDictionary: {
+                FUNCTIONS_WORKER_RUNTIME: 'node',
+              },
+              siteConfigPropertiesDictionary: {
+                use32BitWorkerProcess: false,
+                linuxFxVersion: 'Node|18',
+              },
+              supportedFunctionsExtensionVersions: ['~4'],
+            },
+          },
+        },
+      ],
+    },
     {
       displayText: 'Node.js 16',
       value: '16',

diff --git a/server/src/tests/Stacks/2020-05-01/function-app/validations.ts b/server/src/tests/Stacks/2020-05-01/function-app/validations.ts
@@ -34,7 +34,7 @@ export function validateNodeStack(stacks) {
   expect(nodeStack.displayText).to.equal('Node.js');
   expect(nodeStack.value).to.equal('node');
   expect(nodeStack.sortOrder).to.equal(1);
-  expect(nodeStack.versions.length).to.equal(4);
+  expect(nodeStack.versions.length).to.equal(5);
   expect(nodeStack).to.deep.equal(hardCodedNodeStack);
 }
 

diff --git a/server/src/tests/Stacks/2020-06-01/function-app/validations.ts b/server/src/tests/Stacks/2020-06-01/function-app/validations.ts
@@ -168,7 +168,7 @@ function validateNodeStack(nodeStack) {
   expect(nodeStack.displayText).to.equal('Node.js');
   expect(nodeStack.value).to.equal('node');
   expect(nodeStack.preferredOs).to.equal('windows');
-  expect(nodeStack.majorVersions.length).to.equal(6);
+  expect(nodeStack.majorVersions.length).to.equal(7);
   expect(nodeStack).to.deep.equal(hardCodedNodeStack);
 }
 

diff --git a/server/src/tests/Stacks/2020-10-01/function-app/validations.ts b/server/src/tests/Stacks/2020-10-01/function-app/validations.ts
@@ -167,7 +167,7 @@ function validateNodeStack(nodeStack) {
   expect(nodeStack.displayText).to.equal('Node.js');
   expect(nodeStack.value).to.equal('node');
   expect(nodeStack.preferredOs).to.equal('windows');
-  expect(nodeStack.majorVersions.length).to.equal(6);
+  expect(nodeStack.majorVersions.length).to.equal(7);
   expect(nodeStack).to.deep.equal(hardCodedNodeStack);
 }