[Network] Load Balancer Outbound Rules #7114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williexu
approved these changes
Aug 22, 2018
| if namespace.subnet and namespace.public_ip_address: | ||
| raise ValueError( | ||
| 'incorrect usage: --subnet NAME --vnet-name NAME | ' | ||
| '--subnet ID | --public-ip NAME_OR_ID') | ||
|
|
||
| if namespace.public_ip_prefix: | ||
| if not is_valid_resource_id(namespace.public_ip_prefix): |
There was a problem hiding this comment.
You can combine these two conditions.
| validate_frontend_ip_configs(cmd, namespace) | ||
|
|
||
| if namespace.backend_address_pool: | ||
| if not is_valid_resource_id(namespace.backend_address_pool): |
There was a problem hiding this comment.
You can combine the two conditions
| _set_param(instance, 'backend_address_pool', SubResource(id=backend_address_pool) \ | ||
| if backend_address_pool else None) | ||
| _set_param(instance, 'frontend_ip_configurations', \ | ||
| [SubResource(x) for x in frontend_ip_configurations] if frontend_ip_configurations else None) |
There was a problem hiding this comment.
shorter if this is [SubResource(x) for x in frontend_ip_configurations or []]
| @@ -425,7 +426,7 @@ def _make_singular(value): | |||
| 'inbound_nat_pools': 'inbound-nat-pool', | |||
| 'backend_address_pools': 'address-pool', | |||
| 'load_balancing_rules': 'rule', | |||
| 'probes': 'probe' | |||
| 'probes': 'probe', | |||
tjprescott
added a commit
that referenced
this pull request
Sep 11, 2018
* Bump API version * [Network] Public IP Prefix (#7081) * Initial Work * Finish command work and test. * Add help entries. * Vnet show/list table format. * [Network] Service endpoint policies (#7080) * Intial work * Finish command work and add test. * Remove policy-definition create workaround. * Code review feedback. * [Network] Load Balancer Outbound Rules (#7114) * Initial work on Outbound Rules * Progress on outbound rules. * Final work on LB outbound rules. * Add `--enable-tcp-reset` to inbound-nat-rule, inbound-nat-pool, and rule create/update commands. * Fix 2 Network Live test issues. * [IgniteNetwork] Fix issues with Network Watcher flog-log configure (#7143) * Fix #7065. Fix #7066. * Code review feedback. * [IgniteNetwork] Add `run-configuration-diagnostic` command and fix `test-connectivity` (#7165) * Add run-configuration-diagnostic command. * Add `run-configuration-diagnostic` command. Fix `test-connectivty` command because of SDK breaking change. * [IgniteNetwork] Subnet delegation (#7200) * Subnet delegation support. * Finish work and add test. * Close #7181. (#7205) * Code review comments. * Disable test recordings on IgniteNetwork branch. * Clean up static issues. * Add private WHL for draft SDK. * Fix #7146. Fix #7191. Fix #7213. (#7232) * [IgniteNetwork] DNS Alias Records (#7233) * Initial work. * Add test. * Add checks to DNS test. Add private DNS whl file. * Close #7242. (#7246) * Vnet show/list table format. * Bump API version * [Network] Public IP Prefix (#7081) * Initial Work * Finish command work and test. * Add help entries. * [Network] Service endpoint policies (#7080) * Intial work * Finish command work and add test. * Remove policy-definition create workaround. * Code review feedback. * [Network] Load Balancer Outbound Rules (#7114) * Initial work on Outbound Rules * Progress on outbound rules. * Final work on LB outbound rules. * Add `--enable-tcp-reset` to inbound-nat-rule, inbound-nat-pool, and rule create/update commands. * Fix 2 Network Live test issues. * [IgniteNetwork] Fix issues with Network Watcher flog-log configure (#7143) * Fix #7065. Fix #7066. * Code review feedback. * [IgniteNetwork] Add `run-configuration-diagnostic` command and fix `test-connectivity` (#7165) * Add run-configuration-diagnostic command. * Add `run-configuration-diagnostic` command. Fix `test-connectivty` command because of SDK breaking change. * [IgniteNetwork] Subnet delegation (#7200) * Subnet delegation support. * Finish work and add test. * Close #7181. (#7205) * Code review comments. * Disable test recordings on IgniteNetwork branch. * Clean up static issues. * Add private WHL for draft SDK. * Fix #7146. Fix #7191. Fix #7213. (#7232) * [IgniteNetwork] DNS Alias Records (#7233) * Initial work. * Add test. * Add checks to DNS test. Add private DNS whl file. * Close #7242. (#7246) * Record DNS tests. * Record tests 2018-08-01 * Re-enable tests. Begin re-recording. * Test re-recording. * Re-record test. * Re-record tests. * Re-record tests * Re-record tests * Re-record more tests. Unlimited tests!! * [IgniteNetwork] Read-only support for InterfaceEndpoints (#7272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Standard LB outbound rules. Note: CI will not pass due to SDK not being released. This is a merge to a separate branch (not dev) to facilitate easier code review.
cc/ @christiankuhtz
Closes #6931.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.