Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support classic nsg for az network watcher flow-log configure & show #7066

Closed
zwswim opened this issue Aug 16, 2018 · 2 comments
Closed

support classic nsg for az network watcher flow-log configure & show #7066

zwswim opened this issue Aug 16, 2018 · 2 comments
Assignees
@tjprescott
Milestone
Sprint 45 - Ignite

Comments

@zwswim
Copy link

zwswim commented Aug 16, 2018 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, classic resources are not supported in Azure CLI 2.0. Currently, Azure Network Watcher is trying to launch the feature to "enable flowlog for classic nsg " in Ignite and having CLI support would be desirable.

Describe the solution you'd like

  1. if the NSG name is passed in, a new parameter to indicate which the NSG is a Classic Nsg will be desired. The default value could be false.
  2. if the NSG Resource ID is passed in, CLI should be able to understand whether the NSG is a Classic or Nrp NSG since they have different provider: Microsoft.ClassicNetwork vs Microsoft.Network

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@tjprescott tjprescott added Network az network vnet/lb/nic/dns/etc... Feature labels Aug 16, 2018
@tjprescott tjprescott self-assigned this Aug 16, 2018
@tjprescott tjprescott added this to the Sprint 45 - Ignite milestone Aug 16, 2018
@tjprescott
Copy link
Member

If we are able to support this, we would only allow Classic NSG to be supported via ID. The main technical question is whether we can retrieve the classic NSG to retrieve its location given there is 0 Python SDK support for Classic Azure resources.

@tjprescott tjprescott mentioned this issue Aug 24, 2018
Merged
2 tasks
@tjprescott
Copy link
Member

PR merged. Will be in Ignite release.

tjprescott added a commit that referenced this issue Sep 11, 2018
@tjprescott
Ignite Network Release (#7221)
2d6bcde 
* Bump API version

* [Network] Public IP Prefix (#7081)

* Initial Work

* Finish command work and test.

* Add help entries.

* Vnet show/list table format.

* [Network] Service endpoint policies (#7080)

* Intial work

* Finish command work and add test.

* Remove policy-definition create workaround.

* Code review feedback.

* [Network] Load Balancer Outbound Rules (#7114)

* Initial work on Outbound Rules

* Progress on outbound rules.

* Final work on LB outbound rules.

* Add `--enable-tcp-reset` to inbound-nat-rule, inbound-nat-pool, and rule create/update commands.

* Fix 2 Network Live test issues.

* [IgniteNetwork] Fix issues with Network Watcher flog-log configure (#7143)

* Fix #7065. Fix #7066.

* Code review feedback.

* [IgniteNetwork] Add `run-configuration-diagnostic` command and fix `test-connectivity` (#7165)

* Add run-configuration-diagnostic command.

* Add `run-configuration-diagnostic` command. Fix `test-connectivty` command because of SDK breaking change.

* [IgniteNetwork] Subnet delegation (#7200)

* Subnet delegation support.

* Finish work and add test.

* Close #7181. (#7205)

* Code review comments.

* Disable test recordings on IgniteNetwork branch.

* Clean up static issues.

* Add private WHL for draft SDK.

* Fix #7146. Fix #7191. Fix #7213. (#7232)

* [IgniteNetwork] DNS Alias Records (#7233)

* Initial work.

* Add test.

* Add checks to DNS test. Add private DNS whl file.

* Close #7242. (#7246)

* Vnet show/list table format.

* Bump API version

* [Network] Public IP Prefix (#7081)

* Initial Work

* Finish command work and test.

* Add help entries.

* [Network] Service endpoint policies (#7080)

* Intial work

* Finish command work and add test.

* Remove policy-definition create workaround.

* Code review feedback.

* [Network] Load Balancer Outbound Rules (#7114)

* Initial work on Outbound Rules

* Progress on outbound rules.

* Final work on LB outbound rules.

* Add `--enable-tcp-reset` to inbound-nat-rule, inbound-nat-pool, and rule create/update commands.

* Fix 2 Network Live test issues.

* [IgniteNetwork] Fix issues with Network Watcher flog-log configure (#7143)

* Fix #7065. Fix #7066.

* Code review feedback.

* [IgniteNetwork] Add `run-configuration-diagnostic` command and fix `test-connectivity` (#7165)

* Add run-configuration-diagnostic command.

* Add `run-configuration-diagnostic` command. Fix `test-connectivty` command because of SDK breaking change.

* [IgniteNetwork] Subnet delegation (#7200)

* Subnet delegation support.

* Finish work and add test.

* Close #7181. (#7205)

* Code review comments.

* Disable test recordings on IgniteNetwork branch.

* Clean up static issues.

* Add private WHL for draft SDK.

* Fix #7146. Fix #7191. Fix #7213. (#7232)

* [IgniteNetwork] DNS Alias Records (#7233)

* Initial work.

* Add test.

* Add checks to DNS test. Add private DNS whl file.

* Close #7242. (#7246)

* Record DNS tests.

* Record tests 2018-08-01

* Re-enable tests. Begin re-recording.

* Test re-recording.

* Re-record test.

* Re-record tests.

* Re-record tests

* Re-record tests

* Re-record more tests. Unlimited tests!!

* [IgniteNetwork] Read-only support for InterfaceEndpoints (#7272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjprescott tjprescott

Labels
None yet
Projects
None yet
Milestone
Sprint 45 - Ignite
Development

No branches or pull requests
3 participants
@tjprescott @haroldrandom @zwswim