[Network] Service endpoint policies #7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugangw-msft
approved these changes
Aug 17, 2018
azure-cli2017.pyproj
Outdated
| @@ -13,8 +13,7 @@ | |||
| <LaunchProvider>Standard Python launcher</LaunchProvider> | |||
| <InterpreterId>MSBuild|{54f4b6dc-0859-46dc-99bb-b275c9d0aca3}|$(MSBuildProjectFullPath)</InterpreterId> | |||
| <EnableNativeCodeDebugging>False</EnableNativeCodeDebugging> | |||
| <CommandLineArguments> | |||
| </CommandLineArguments> | |||
| <CommandLineArguments>network vnet subnet create -g tjp-vm --vnet-name vnet1 -n subnet1 --service-endpoints Microsoft.Storage Microsoft.Sql --address-prefix 10.0.0.0/24 --service-endpoint-policy policy1</CommandLineArguments> | |||
There was a problem hiding this comment.
you can back out this change right now, or wait till merge into the dev branch
|
|
||
| # test policy CRUD | ||
| self.cmd('network service-endpoint policy create -g {rg} -n {policy} --tags test=best') | ||
| self.cmd('network service-endpoint policy update -g {rg} -n {policy} --tags test=nest') |
There was a problem hiding this comment.
Please add some validations here for this test case.
Also, are you able to get the wheel file from associated Python SDK PR? If yes, you can put under the privates folder, then CI can run normally.
There was a problem hiding this comment.
Yes, I will add validations. I'm not concerned right now about the CI.
tjprescott
force-pushed
the
IgniteNetwork
branch
from
3eeed74 to
8a930cc
Compare
tjprescott
force-pushed
the
IgniteNetwork
branch
from
8a930cc to
5c596df
Compare
|
Closes #7104. |
tjprescott
added a commit
that referenced
this pull request
Sep 11, 2018
* Bump API version * [Network] Public IP Prefix (#7081) * Initial Work * Finish command work and test. * Add help entries. * Vnet show/list table format. * [Network] Service endpoint policies (#7080) * Intial work * Finish command work and add test. * Remove policy-definition create workaround. * Code review feedback. * [Network] Load Balancer Outbound Rules (#7114) * Initial work on Outbound Rules * Progress on outbound rules. * Final work on LB outbound rules. * Add `--enable-tcp-reset` to inbound-nat-rule, inbound-nat-pool, and rule create/update commands. * Fix 2 Network Live test issues. * [IgniteNetwork] Fix issues with Network Watcher flog-log configure (#7143) * Fix #7065. Fix #7066. * Code review feedback. * [IgniteNetwork] Add `run-configuration-diagnostic` command and fix `test-connectivity` (#7165) * Add run-configuration-diagnostic command. * Add `run-configuration-diagnostic` command. Fix `test-connectivty` command because of SDK breaking change. * [IgniteNetwork] Subnet delegation (#7200) * Subnet delegation support. * Finish work and add test. * Close #7181. (#7205) * Code review comments. * Disable test recordings on IgniteNetwork branch. * Clean up static issues. * Add private WHL for draft SDK. * Fix #7146. Fix #7191. Fix #7213. (#7232) * [IgniteNetwork] DNS Alias Records (#7233) * Initial work. * Add test. * Add checks to DNS test. Add private DNS whl file. * Close #7242. (#7246) * Vnet show/list table format. * Bump API version * [Network] Public IP Prefix (#7081) * Initial Work * Finish command work and test. * Add help entries. * [Network] Service endpoint policies (#7080) * Intial work * Finish command work and add test. * Remove policy-definition create workaround. * Code review feedback. * [Network] Load Balancer Outbound Rules (#7114) * Initial work on Outbound Rules * Progress on outbound rules. * Final work on LB outbound rules. * Add `--enable-tcp-reset` to inbound-nat-rule, inbound-nat-pool, and rule create/update commands. * Fix 2 Network Live test issues. * [IgniteNetwork] Fix issues with Network Watcher flog-log configure (#7143) * Fix #7065. Fix #7066. * Code review feedback. * [IgniteNetwork] Add `run-configuration-diagnostic` command and fix `test-connectivity` (#7165) * Add run-configuration-diagnostic command. * Add `run-configuration-diagnostic` command. Fix `test-connectivty` command because of SDK breaking change. * [IgniteNetwork] Subnet delegation (#7200) * Subnet delegation support. * Finish work and add test. * Close #7181. (#7205) * Code review comments. * Disable test recordings on IgniteNetwork branch. * Clean up static issues. * Add private WHL for draft SDK. * Fix #7146. Fix #7191. Fix #7213. (#7232) * [IgniteNetwork] DNS Alias Records (#7233) * Initial work. * Add test. * Add checks to DNS test. Add private DNS whl file. * Close #7242. (#7246) * Record DNS tests. * Record tests 2018-08-01 * Re-enable tests. Begin re-recording. * Test re-recording. * Re-record test. * Re-record tests. * Re-record tests * Re-record tests * Re-record more tests. Unlimited tests!! * [IgniteNetwork] Read-only support for InterfaceEndpoints (#7272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a merge into a dedicated branch for Ignite networking work. It won't pass CI right now and I'm only looking for code review so that specific features can be reviewed in small pieces instead of a huge PR later.
This adds support for service endpoint policies and policy definitions.
Closes #6932. cc/ @chandrasekarsrinivasan
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.