The argument name in the deprecation warning message should use the format "--foo-bar" instead of "foo_bar"

[bingosummer]

Related command

$ az aks create -g binxi1114 -n binxi111401 --enable-pod-security-policy -c 1
Argument 'enable_pod_security_policy' has been deprecated and will be removed in a future release.
Argument '--enable-pod-security-policy' is in preview and under development.

Extension name (the extension in question)

It's not an issue to a specific extension. It is a common issue.

Description of issue (in as much detail as possible)

I'm working a PR to deprecate the argument '--enable-pod-security-policy', and I get the message like below. The warning message should be "Argument '--enable-pod-security-policy' has been deprecated and will be removed in a future release.". Argument 'enable_pod_security_policy' is not good.

$ az aks create -g binxi1114 -n binxi111401 --enable-pod-security-policy -c 1
Argument 'enable_pod_security_policy' has been deprecated and will be removed in a future release.
Argument '--enable-pod-security-policy' is in preview and under development.

---

[yonzhan]

route to CXP team

[PramodValavala-MSFT]

@bingosummer Thanks for bringing this up! Looks like that is how it is handled in the knack framework (this code here) but looks like if you use the options_list parameter when defining the argument, it would be as expected.

Nonetheless, I believe showing the argument is not best for customers since that would just be confusing. @yonzhan @jiasli Could you share insights on why the default behavior is so?

[bingosummer]

seems options_list doesn't help in my case.

[jiasli]

It is the designed behavior of knack to show argument_dest in the warning message if deprecation target is not specified:

https://github.com/microsoft/knack/blob/cd590312b9b4ea1402d7a0a76814f6ca4da7fab8/knack/arguments.py#L221-L222

        if deprecate_info:
            deprecate_info.target = deprecate_info.target or argument_dest

To override the enable_pod_security_policy in the warning message, please specify

deprecate_info=c.deprecate(target='--enable-pod-security-policy')

Here is an example from resource command module:

azure-cli/src/azure-cli/azure/cli/command_modules/resource/_params.py

Lines 390 to 391 in 5b91300

	c.argument('handle_extended_json_format', arg_type=extended_json_format_type,
	deprecate_info=c.deprecate(target='--handle-extended-json-format/-j'))

Another example from vm command module:

azure-cli/src/azure-cli/azure/cli/command_modules/vm/_params.py

Lines 209 to 210 in 93b5083

	c.argument('for_upload', arg_type=get_three_state_flag(), min_api='2018-09-30',
	deprecate_info=c.deprecate(target='--for-upload', redirect='--upload-type Upload', hide=True),

[bingosummer]

deprecate_info=c.deprecate(target='--enable-pod-security-policy') works.