Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Mark AAD-legacy properties deprecated #5670

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

bingosummer
Copy link
Member

@bingosummer bingosummer commented Dec 29, 2022

This PR marks the parameters --aad-client-app-id, --aad-server-app-id and --aad-server-app-secret deprecated. These parameters will be hidden from the output of az aks create -h.

@ghost ghost requested review from zhoxing-ms and yanzhudd December 29, 2022 09:22
@ghost ghost assigned zhoxing-ms Dec 29, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Dec 29, 2022
@ghost ghost requested a review from yonzhan December 29, 2022 09:22
@ghost ghost added the AKS label Dec 29, 2022
@yonzhan yonzhan added this to the Dec 2022 (2023-01-10) milestone Dec 29, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 29, 2022

AKS

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed due to vm command bump SDK and default API version. Will fix failed test case in some other PR.

src/aks-preview/azext_aks_preview/_params.py Show resolved Hide resolved
@FumingZhang
Copy link
Member

CI failed due to vm command bump SDK and default API version. Will fix failed test case in some other PR.

Fix PR #5830, please rebase from main after the fix is merged.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit 329e3af into Azure:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants