{AKS} Add target for enable_pod_security_policy deprecation information #5550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingosummer
requested review from
andyliuliming and
FumingZhang
as code owners
ghost
requested review from
ghost
assigned 
|
AKS |
FumingZhang
reviewed
Nov 15, 2022
| @@ -315,7 +315,7 @@ def load_arguments(self, _): | |||
| c.argument('pod_cidrs') | |||
| c.argument('service_cidrs') | |||
| c.argument('load_balancer_managed_outbound_ipv6_count', type=int) | |||
| c.argument('enable_pod_security_policy', action='store_true', deprecate_info=c.deprecate(hide=True)) | |||
| c.argument('enable_pod_security_policy', action='store_true', deprecate_info=c.deprecate(target='--enable-pod-security-policy', hide=True)) | |||
There was a problem hiding this comment.
From doc, it's not necessary?
There was a problem hiding this comment.
Not necessary, but:
Without the target, the warning message is Argument 'enable_pod_security_policy' has been deprecated and will be removed in a future release..
With the target, the warning message is Argument '--enable-pod-security-policy' has been deprecated and will be removed in a future release.. I think, this message is more clear.
zhoxing-ms
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Azure/azure-cli#24647
With the fix, the warning message will be
Option '--enable-pod-security-policy' has been deprecated and will be removed in a future release..