Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AKS] Mark "--enable-pod-security-policy" deprecated #5542

Merged
merged 1 commit into from
Nov 15, 2022
Merged

[AKS] Mark "--enable-pod-security-policy" deprecated #5542

merged 1 commit into from
Nov 15, 2022

Conversation

bingosummer
Copy link
Member

@ghost ghost requested review from zhoxing-ms and wangzelin007 November 11, 2022 11:18
@ghost ghost assigned zhoxing-ms Nov 11, 2022
@ghost ghost added this to the Nov 2022 (2022-12-06) milestone Nov 11, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Nov 11, 2022
@ghost ghost requested a review from yonzhan November 11, 2022 11:18
@ghost ghost added the AKS label Nov 11, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 11, 2022

AKS

FumingZhang
FumingZhang approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

To clarify, the deprecated option has no corresponding replacement in CLI. According to the doc, the alternative is to use kubectl to add labels directly to the cluster namespace.

@bingosummer bingosummer mentioned this pull request Nov 15, 2022
Closed
@zhoxing-ms
Copy link
Contributor

@bingosummer If you want to release a new extension version to release this change, please also upgrade the version defined in setup.py

@bingosummer
Copy link
Member Author

@bingosummer If you want to release a new extension version to release this change, please also upgrade the version defined in setup.py

@zhoxing-ms Thanks! The fix doesn't need a release. It can be released with other PR's changes later.

@bingosummer
Copy link
Member Author

@zhoxing-ms Thanks for reviews! Resolved the comments.

@bingosummer
Copy link
Member Author

After removing help, CI raises the below error. Will add them back.

-  FAIL - HIGH severity: missing_parameter_help
    Parameter: aks create, `enable_pod_security_policy` - Missing help
    Parameter: aks update, `enable_pod_security_policy` - Missing help

@zhoxing-ms zhoxing-ms merged commit 9eeaf6c into Azure:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FumingZhang FumingZhang FumingZhang approved these changes

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@karataliu karataliu karataliu approved these changes

@andyliuliming andyliuliming Awaiting requested review from andyliuliming andyliuliming is a code owner

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees

@zhoxing-ms zhoxing-ms

Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Milestone
Nov 2022 (2022-12-06)
Development

Successfully merging this pull request may close these issues.
5 participants
@bingosummer @yonzhan @zhoxing-ms @karataliu @FumingZhang