[ConnectedK8s] Added update command (#3) #2091
Conversation
|
ConnectedK8s |
|
hi @fengzhou-msft could you pls review this PR? thanks |
| c.argument('https_proxy', options_list=['--proxy-https'], help='Https proxy URL to be used.') | ||
| c.argument('http_proxy', options_list=['--proxy-http'], help='Http proxy URL to be used.') | ||
| c.argument('no_proxy', options_list=['--proxy-skip-destinations'], help='List of URLs/CIDRs for which proxy should not to be used.') |
There was a problem hiding this comment.
This is a breaking change. Please evaulate the impact to customers. You may need to keep the old option and add deprecation message before finally removing it if necessary.
There was a problem hiding this comment.
the last version was not published, so there are no customers that would be using it
There was a problem hiding this comment.
#1878, this was the last PR in which the change was added. The version had not been upgraded in setup.py, so i guess it would not have been published right?
|
@fengzhou-msft , @arrownj , Everything is set from our side. Could you review as well? If possible could we get this merged today? We wanted to release this feature next week for customers. |
|
@Anumita version 0.2.3 is released. |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.